wisling / tibiaauto Goto Github PK

Sometimes my connection drops for some reason and Tibia doesn't go to the first screen, where there's the login button.
When this happens TA detects that my character is offline but it can't log back in since it can't find the login button.

My suggestion would be to force a Ctrl+G that reopens the window with characters.
That usually works for me, unless the internet goes down because then I get a new IP and then it no longer works.

According to user Pudiim in one topic (http://tibiaauto.net/forum/viewtopic.php?f=36&p=1099980#p1099980) [Portuguese], several of his makers die because they prioritize using "exura ico" and Mana Potions over Health Potions.

Well...
Then again, CipSoft updated Tibia to a new version.

• Disallow attempting to attach 2 TA instances to the same Tibia client process (it causes the second TA to hang)
• Add ability to launch a client with TA already attached

The same class names persists in almost all modules. It makes code indexing often go wild. Also makes hard to browse through code.

There are some things that a human won't do that TA does, for example:

• Loot things really fast:
  This is self explanatory. I think TA shouldn't loot things that fast. A human would take more time to loot, and since it's a bot, doesn't really matter if you take 500ms to loot each item, instead of looting everything pretty much instantly.
• Use a spell as soon you log in:
  This one happens in a few ways. If your connection drops and the monsters keep attacking you until you log out, you might not die but you might be almost dead. Once TA logs you back in, it starts to use healing spells from the very moment you log in. And a human wouldn't do that, although is more acceptable than the following (because you are kind of expecting your life to be low when you log in again)
  It might also happen if you have a full mana and you set the Mana Burner in Spellcaster. You log in and TA already casts a spell. This one is more concerning because that usually happens near depots and places where there might be more people around, and they notice.
  My suggestion is to just add a 1000~2000ms delay on this module when you log in.
• Try to cast a spell that you don't have, nonstop:
  This one happens if you log in a char of a different vocation or if you just forgot to buy a spell. (happens a lot to me... ahaha)
  A human would notice that they don't have the spell and they would stop casting the spell and go for a different one.
  My suggestion for this one is having a detection of vocation (if that's possible anyways) to make sure TA won't cast a spell of a different vocation and detecting if the spell was bought or not (again, if that's possible to detect) and if wasn't bought, use "smaller" spell (not sure how to say that in English).
  For example: if you a Mage script that tries to use Exura Vita. And then the bot detects that the char didn't buy that spell, then it tries to use Exura Gran, if this one wasn't bought too, it goes with Exura.
  The bot should also show somehow for the user that the spells that he configured weren't bought.

There are probably more things that TA could improve to look more like a human, but these are the ones that I can think of now.

Sometimes, when I wake up in the morning, I go check my bots and some of them are not logged in, and when I go to TA, Auto Login says that it is trying to log in for **** seconds.
I think we should set a timeout for the AutoLogin and then try again if the can't do it within the time limit. :)

Apparently, in some particular spots, Tibia with TA attached has a chance to randomly crash.

Tibia exception handlers points to Player->Control, and sometimes some GUI rendering function. So my best guess is there's a potential stack corruption issue in the injected DLL's hook functions, resulting in this peculiar bug.
Other, though less likely, possibilities are

• a problem in utils library (it's also used by injected DLL),
• some rogue memory write from main TA app

User Makarno_x had an idea for a striker tab in TA.
More information can be seen here: http://tibiaauto.net/forum/viewtopic.php?f=2&p=1100798#p1095671

It is the least ellegant way to close a process.
Either handle the exception, or return a fitting status code.

Guys... It would be awesome if we could add little script snippets and labels in the walker.
Example:

(waypoint)
...
(waypoint)
[script]
  ta.sayNPC("hi")
  ta.wait(300)
  ta.sayNPC("task")
  ta.wait(300)
  ta.sayNPC("yes")
  ta.wait(300)
[/script]
(waypoint)
...
(waypoint)
[label=hunt]
(waypoint)
...
(waypoint)
[script]
  if( cap > 100 )
    ta.goToLabel("hunt")
  else
    ta.goToLabel("depot")
[/script]

I hope you guys get the point... I think a system like this (obviously in such a case, the walker has to be round-robin) present in most bots would make TA much more powerful... We would be able to more easily create scripts that do tasks/quests and things like this...

Since the latest release (2.64.2 for version 10.92) injecting TA in a client using the directx 5 engine crashes the tibia client upon login, or instantly if theres a character already connected. This happens every time, and on different systems.

Following is the exception text displayed on the next client start

+---------------------------------------------------------------
Debug Assertion 10.92 NWin32Exception.cpp 55
Wed Apr 13 14:08:58 2016
Graphic Engine: DirectX5 (0)
Operating System: Windows 7 Home Basic Edition 32 Bit in VEN
Processor: Intel CORE I3-2
Video Card: VIRTUALBO
Last Packet Types: 030 161 160 245 183 184 144 146 147 158
Last Packet: 030 000 000 000 000 000 000 000 000 000 000 000 000 000 000 000
Player Position: [32343,32219,7]
Player Name: <irrelevant>
Player Action: 048 046 048 046 048 046 048 058 055 049 055 049
Player.cpp 344: exception occurred, reason:
Player.cpp 448: exception occurred, reason:
Control.cpp 1742: exception occurred (MaW: 29AA580 MoW: 0 ), reason:
Control.cpp 539: exception occurred (Force?1:0 = 0), reason:
MainWindow.cpp 133: exception occurred (Surface = 1), reason:
GUI.cpp 1822: exception occurred (Surface = 1), reason:
MapWindow.cpp 985: exception occurred (Surface = 1), reason:
MapWindow.cpp 906: exception occurred, reason:
surfaceDX9.cpp 702: exception occurred, reason:
surfaceDX9.cpp 448: exception occurred, reason:
NWin32Exception.cpp 55: win32 exception occurred, reason:
access violation (read attempt at 00000140)
----------------------------------------------------------------

Does anyone have the contact info of Wateva?
The website is offline now and I think he is the only one capable of putting it back online.
The problem is that he didn't visit the forum since March or April.
So I'm guessing he is not aware that the website is offline now.
If someone could just email him that would be great!

@Wisling

Sometimes spell caster won't use healing anymore. Restarting the spellcaster fixes the problem.

TA executable path should be used instead of path in registry.
Tricky part is passing it to the Tibia Client.

• Autolooting should probably end up in a separate module, just with better synchronization to cavebot (would prevent people using both autolooters)
• Autolooter should walk to the body in a preferable time, even if it was killed from the distance

When you remove stuff from Item Config directly in TA and save Item Config and then save the whole script, TA is not changing anything.

Example:

• Open a script;
• Go to Item Config;
• Remove everything from there;
• Save Item Config;
• Save the script;
• Close TA;
• Open TA;
• Load the script;
  Everything that was in Item Config before is still there, no changes were made.

I'm not sure if the changes are actually being made and TA is not saving them in the XML, or if the Item Config is not actually changing.

Tibia implemented a new state called Pending State.
Whenever the Tibia client goes from the Active State to the Pending State, the message of "trying to reconnect" (or something like that) appears and Tibia keeps trying to reconnect, rather than actually logging out.
The problem is that when Tibia is actually able to reconnect automatically, it closes our backpacks.

My solution would be to set a timer on Auto Login that would reopen the backpacks, in case they were closed.
So every X seconds, Auto Login would check if the backpacks are opened, and then would open them again in case they were closed.

It should be possible to store/load configuration files not only per character name.
Preferably, there would be a global, default config file, and ability to create launch profiles, with the selected configuration loaded immediately.

TA could have a new Spell Caster manager which would read a .xml containing all spells from the game separated by classes and inside each class it would be separated by Healing, Strike or AOE like:

<knight>
   <healing>
      <spell name="" cooldown="" manaCost="" />
   </healing>
   <aoe>
   </aoe>
   <strike>
   </strike>
</knight>
<paladin>
</paladin>
<druid>
</druid>
<sorcerer>
</sorcerer>

After reading the .xml, the manager could generate the GUI at runtime.
This way, if a spell is added to the game or it has its cooldown/mana cost updated, the user could just edit the .xml

I'm not sure which triggers are not working, but there's a bunch of topics in the forum saying that they can't make the PK attack to work.
If a player attacks them, it just does nothing.

Also enabling/disabling modules with Auto Go/Log is not working as well.
(at least for the modules that I use)

Multibyte strings are problematic and Microsoft has deprecated support for them.
The whole project should get converted to using Unicode character set.

It should be encrypted using Windows secure storage capabilities.
https://msdn.microsoft.com/en-us/library/windows/desktop/aa380261(v=vs.85).aspx

Because of new layout, TA is no longer fully opening backpacks when logging in.
It is maximizing the "premium features" thingy as well.

Also, but it may have nothing to do with that, it opened fine all my backpacks as long as the main wasn't a Brown Backpack.
It was really bugged opening them when the main was a Brown Backpack.

According to Wisling, any child afx window opened by dialog window ends up crashing TA.

Depositer might try to deposit into guildhall's depot, even if the character cannot enter it.

There's so many places where memory is either explicitly dynamically allocated, or unnecessarily preallocated, where C++ implementation using STL would usually take much less code, less memory, while being faster.

Notable examples:

• Cavebot runtime data
• Modules config parameters mapping (actually this one could be a static char array in each module, simplifying stuff a lot)

http://tibiaauto.net/forum/viewtopic.php?f=1&t=1018653

According to user konrad123666, TA is not minimizing the backpacks on his PACC char. And it only happens in the PACC chars. The FACC ones are fine.

It's probably because since he is premium and his premium char doesn't have that window "Premium Features" open.

Tibia updated to 10.95.
Just content fixes and changes...
Shouldn't be hard for you guys.

By the way: how hard it is to find those IDs?
Because it looks like that I have more free time to do that than you guys.
If you could teach me, simple updates like this one could be done by me... :)

Many users are still reporting issues with starting up TA, including file access violation errors.
TA should be able to startup from normal user. In case it really needs elevated system access - it should query for necessary permissions.

More info:
https://msdn.microsoft.com/en-us/library/windows/desktop/ms717801(v=vs.85).aspx

When TA execution is paused (by a debugger for instance), the client freezes too. It's probably something messed up in inject DLL.

Not sure if you guys keep an eye on the forum regularly or on Tibia's website. So I don't know if guys know when there are updates and stuff... xD

So I decided to create this issue to let you know there has been an update to Tibia. :D

TA is treating the depot boxes as backpacks.
Most backpacks have a limit of 20 slots.
But the Depot Box can have a total of 2000 slots (for FAcc), creating several pages.
We should force TA to keep putting items in one Depot Box until it reaches this limit and only then moving to the next Depot Box.

Either that, or have an option that can put items inside backpacks inside the Depot Boxes.

(I prefer the second option because it helps us botters that have many characters and have to send parcels to our main. It's much easier to move a few backpacks inside a parcel, than having to put all items inside backpacks and then to a parcel)

Items with incorrect letter-case spelling in configuration do not get deposited properly.

• "Auto Research Map" should include compensation for tiles invisibly marked as unwalkable (due to fields or creatures standing there)
• Integrate keep distance into a cavebot, make ability to mark a waypoint it should lure monsters to
• Allow pathing through grass, if machete is available
• Try to move movable, non-walkable items (hardcoded), in addition to optional breeching it (using script)
• Optimize and bugfix the pathfinding algorithm (most notably, fix AStar implementation)
• Do not try to attack a monster that is unreachable
• to be tested and considered if viable at all - Add ability to store a global map, preferably in on-demand loaded chunks instead of a large blob

Many constants through code (most notably, DLL pipe protocol) aren't defined, which makes code much harder to understand, and is more error-prone.

Not CPU-time critical, basic functionalities like "Fluid Drinker", "Auto UH", "Spell Caster", should be remade implementing generic events (hp change, mana change, creature hp change, creature move, etc. - see #32) and preferably, python callbacks. This would allow (and, hopefully, encourage) users to enhance and update basic functions without needing to dwell into C++ and rebuild anything.

DLL should revert all memory changes and unload itself when TA host process closes the communication pipe.

It would be awesome to have a timer trigger on Auto Go/Log.
Something like:
From 6PM to 6:30PM, do something.
That would be specially useful to force our characters to go back to the depot prior to server save.
This would prevent the character to log out in the middle of the hunt and dying when it logs back on and there's a full respawn. (it happens to me quite a lot in OF)

Ideally we would have two different time triggers. One for local time (our computers) and one for the Tibia server (if possible).

• The Tibia server time would be more useful for the server save, since it might vary due to local timezones of each country.
• The local time can be useful for other things, like going to the depot in a given time that we know a player usually logs in to kill us (has happened to me as well haha), or a time that we know that the power is going down as well (at 6PM every single day the power goes down in my friend's house, for example, and he doesn't know why).

What do you think? @Rebell @Wisling

We have spell caster module but not rune thrower, TA only use runes (SD specifically) when "Backattack alien with runes" option is active. We really need a module to use runes with options for area runes, attack runes, heal runes or field runes because this could be very useful for Druid and Sorcerer.

Having it in autologin is a pretty bad idea. Move it to a separate module... or create a built-in python script for it!

http://tibiaauto.net/forum/viewtopic.php?f=1&t=1018898

http://tibiaauto.net/forum/viewtopic.php?f=1&t=1017890
Possibly related to free depotchest scan.

It should be possible to load only some modules configuration from the config file

Hello,

I install tibia auto for 10.92, and download the tibiaauto in github, i copy the archives of tibiaauto-pub to tibiaauto folder, and when i open tibia, and tibia auto in administrator mode the tibia crash in 10 seconds.. whats is happening?

Sorry my poor english.

Thank you.

There are a couple of new potions and it would be good to see those in Fluid Drinker. :)

Currently modules are independently firing own timers/threads and periodically checking stuff to be done.
Much more flexible approach would be making a global event system with all kinds of events (like Auto Go/Log, but even more) and dynamically installed callbacks by any module/script, selecting to be fired either synchronously or asynchronously.
It would also allow modules and scripts to create and trigger any kind of events artificially.

Current scripts integration with core functionalities is very rough.
A better configuration management tool (for eg. supporting lists) is needed.
What's more, script information exposed to TA core could be done much more compact way.
It should preserve old interface, if possible.
See #32.

GUI "Exit" button crashes/hangs TA. Some forced exit methods also don't appear do be fully working. Often tibiaauto.exe process persists in memory until closed using task manager.