winjs / grid Goto Github PK

I don't think you should globally set box-sizing to border-box. This has the potential to conflict w/ other plugins or techniques that developers are using. The grid should be self-contained and only apply styles that are relative to itself.

please consider doing this instead:

.grid, .row, [class*="col-"] { -moz-box-sizing: border-box; // <= Mozilla v.28 -webkit-box-sizing: border-box; // <= IOS4, <= Android 2.3 box-sizing: border-box; }

Is there any way to cause an element to be hidden on specific viewports? for example, a left-toggle refiner menu on a narrow viewport should collapse into the hamburger.

Need to remove all the extra helper css from grid.css for cleanup.

Fix all this crap nowwwww!

I see you're using a .row selector for some of your grid column styles. Is this necessary? You could save file size by removing these.

Change the behavior of the col-1-2 to snap to 100% at 679px breakpoint.

For a 320 viewport, there should be 12px on each side for apps, which is 3.75% (not 5%)

From: Nicholas Rice
Sent: Wednesday, October 22, 2014 3:14 PM
To: Kyle Zinter
Cc: Jeremy Knudsen; Angela Nelson
Subject: RE: MSCOM Mobile Grid

Hey Kyle-

No worries, just wanted to make sure it didn’t fall off 

I’m looking to Jeremy to define that breakpoint, all I have to go off is mobile. > 540px sounds like a good breakpoint though.

I think the desire for Services is to use the ‘fixed margin grid’ (4px gutters). I think that, beyond mobile sizes, they are fine with having 5% margin’s on the edge of the grid content area. But below that, 5% feels too large and they would like to go 4px ‘margin’ as well as having 4px gutters between columns. Is that correct Jeremy?

I believe what you’ve outlined below is what they are looking for (with that fixed margin being 4px). What I don’t know is if this is something other teams are looking for. Before you create it, you may want to run it by your own design team and gather their thoughts.

Thanks Kyle!
Nick

From: Kyle Zinter
Sent: Wednesday, October 22, 2014 3:04 PM
To: Nicholas Rice
Cc: Jeremy Knudsen; Angela Nelson
Subject: Re: MSCOM Mobile Grid

Also, can you let me know which breakpoint specifically we are looking at?

I'm going to do a little work on the grid tonight after this conference is done for the day. I could definitely add in something quick for this then.

I was thinking that under 540px, on the fixed margin grid only, we make the outer grid margins change from percentage to a fixed margin of your choosing. Thoughts?

KZ

From: Kyle Zinter
Sent: Wednesday, October 22, 2014 1:33 PM
To: Nicholas Rice
Cc: Jeremy Knudsen; Angela Nelson
Subject: Re: MSCOM Mobile Grid

Sorry Nick, not ignoring you. At a conference this weekend.

Is this in regards to outside margins of the whole grid? We have a fixed margin grid offering, if we just want to do it on that, I think that probably makes a lot of sense but I would probably think we should not do it on the true fluid offering.

We should have a chat about this. If we think it should be default behavior or not. This is certainly something that is very easy to accommodate but do we want to or just have an override provided?

KZ

From: Nicholas Rice
Sent: Wednesday, October 22, 2014 12:11 PM
To: Kyle Zinter
Cc: Jeremy Knudsen; Angela Nelson
Subject: RE: MSCOM Mobile Grid

Ping!

From: Nicholas Rice
Sent: Tuesday, October 21, 2014 10:05 AM
To: Kyle Zinter
Cc: Jeremy Knudsen; Angela Nelson
Subject: MSCOM Mobile Grid

Hey Kyle-

Jeremy’s design team has an ask that, at mobile sizes (Jermey, can you clarify at which breakpoint this you mean? 320?), the “margin” grid actually switches from 5% margins to a 4px margin. The reason for this is that, at those sizes, explorations have shown that the margins are pretty huge. Their ask is that we would align to the Metro 2.0 grid at mobile sizes.

Is this something we can accommodate with your grid? Is this something MSCOM designers have considered and might also desire?

Thanks Kyle!
Nick

Is it for those devs that work with winjs. Ok. Navs are generated. Scripts and styles included from cdn. And then yes the grid issue arises. As UWP is pixel based correct me if I am wrong - which I am not quite sure but obviously certain - a dev starts to search for precooked css solutions/recs/specs. Is this the one? Might it be helpful to mention in the desc of the project?

You guys may want to replace line 1526
<script src="http://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js" > </script>

With this
<script src="http://ajax.aspnetcdn.com/ajax/jQuery/jquery-2.1.1.min.js" > </script>

From
http://www.asp.net/ajax/cdn#jQuery_Releases_on_the_CDN_0

Fix all this crap nowwwww!

Similar to the Starbucks Style Guide, place the top debug/toolbox buttons inside a toggle-able, fixed-position menu.

For example:

I'd like to add vertical spacing for tiled layouts, in which we need the vertical spacing between cells to be equal to the horizontal spacing. For example, the grid should allow us to create layouts that look like the image below, where the horizontal and vertical arrows are equal in length.

I plan on sending our a pull request with this addition, but I wanted to figure out the best way to solve it first.

Option 1

Users can add .vertical-spacing to their grid element or individual row. This will work much like the existing fixed-* helpers.

Option 2

We'll add a vertical-spacing boolean to config.scss, which users can turn on if they want vertical spacing.

From the users perspective, option 1 seems better in every way: option 2 forces them to apply the rule to the entire webpage, and forces them to rebuild the grid.

Let me know which option is better and I'll submit the PR.

Move css off actual row/cols up to grid so it can just toggle the whole grid

Fix all this crap now!

Currently breakpoints are set up at 320px, 540, 768, 992, 1200. Will send email til we have consensus inside team.

Having issues with columns not changing direction when using dir='rtl'. It appears that columns still render in an left to right fashion with their content being successfully rendered in right to left.

This issue appears only on IE10. In IE11 this is not an issue. I have debugged the issue in IE10 and IE11 and don't anything from a content perspective from my site that could cause this issue.

Thanks for looking into this.

Fix all this crap nowwwww!

Unhandled exception at 0x6E5A3E1B (edgehtml.dll) in iexplore.exe: 0xC00000FD: Stack overflow (parameters: 0x00000001, 0x06CC2FE0)

Links under the https://github.com/winjs/grid#ie8-support section are broken.

Currently they are written as:

[https://github.com/scottjehl/Respond](Respond.js)

While they most likely are meant to be:

[Respond.js](https://github.com/scottjehl/Respond)

The grid should not be setting vertical padding & margins. Vertical spacing should determined by the content of a grid, not the grid itself.

.grid:
change: margin: 0 auto
to: margin-left: auto; margin-right: auto;

change: padding: 0 1em; padding: 1vw;
to: padding-left: 1em; padding-left: 1vw; padding-right: 1em; padding-right: 1vw;

.grid.fixed
change: padding: 0 2px;
to: padding-left: 2px; padding-right: 2px;

.grid.fixed .row
change: margin: -2px;
to: margin-left: 2px; margin-right: 2px;

.grid.zero-margin .row
change: margin: 0;
to: margin-left: 0; margin-right: 0;

.grid .row
change: margin: 0 -1em; margin: 0 -1vw; margin-bottom: 0;
to: margin-left: -1em; margin-left: -1vw; margin-right: -1em; margin-left: -1vw;

.grid .row.content-flush
change: margin: 0 -2em; margin: 0 -2vw;
to: margin-left: -2em; margin-left: -2vw; margin-right: -2em; margin-right: -2vw;

[class*="col-"]
from: padding: 1em 1em; padding: -webkit-calc(1em + 0.5vh) 1vw; padding: calc(1em + 0.5vh) 1vw;
to: padding-left: 1em; padding-left: 1vw; padding-right: 1em; padding-right: 1vw;

I think that's it... Basically, we should only be setting horizontal margins and padding.