lint issues about react-quiz-component HOT 17 CLOSED

@viditagrawal56 Those are required to notify users for misconfigurations. You can set no-console to off in eslint config.

from react-quiz-component.

you may disable this lint at this moment. I'll pick it up later on.

from react-quiz-component.

please disable it. We already have dompurify.sanitize in rawMarkup so it's fine.

dangerouslySetInnerHTML={rawMarkup(...)}

from react-quiz-component.

Assign this issue to me. I can do it

from react-quiz-component.

@vidhuUC assigned.

from react-quiz-component.

@vidhuUC any updates?

from react-quiz-component.

Hey @wingkwong as the assignee has not responded can you assign me this issue I would love to work on it!

from react-quiz-component.

@viditagrawal56 assigned.

from react-quiz-component.

hey @wingkwong The lint gives warning to remove the console.error lines. Should I just directly remove them or are they useful?

from react-quiz-component.

Hey @wingkwong the lint is giving an error that the line extends the length limit of 120. The line that exceeds this limit is an answer to a question so I cant remove anything from the line to make it fit the limit of 120. So should I just increase the limit?
If yes, then what should the new limit be?

from react-quiz-component.

Hey @wingkwong the dangerouslySetInnerHTML property is setting off a warning, to fix it I think it will require DOMPurify to be imported to sanitizes the HTML before using the dangerouslySetInnerHTML.
This will require the dompurify to be installed.
So should I install dompurify or just disable the specific lint?

from react-quiz-component.

@wingkwong the use of confirm in the code gives the no-restricted-globals lint error. Should I create a separate confirmation modal or just disable the lint?
I'll Just list all the lint errors that are yet to fix and you can just tell me which ones to disable and for which error should I fix the actual code so that we both don't waste our time asking again and again 😅:-

1. no-restricted-globals
2. no-shadow
3. no-shadow
4. react/no-array-index-key
5. no-restricted-syntax (iterators/generators require regenerator-runtime, which is too heavyweight for this guide to allow them. Separately, loops should be avoided in favor of array iterations)

I don't understand the 5th one can you please help me 🙏

from react-quiz-component.

@viditagrawal56 disable first. I'll take a look later. please note down all the errors / warnings for those you've disabled. Thanks.

from react-quiz-component.

@viditagrawal56 leave 5th one to me.

from react-quiz-component.

@wingkwong Sorry for not understanding, you mean disable the first lint error right?
Or do you mean I should just disable all the lint errors except the fifth one and make a note of all the disabled errors?

from react-quiz-component.

@viditagrawal56 yes disable only the fist one. for no-shadow and react/no-array-index-key, they can be fixed. If you have discord, free feel to ping me here for live discussion if necessary.

from react-quiz-component.

@wingkwong ok thanks!

from react-quiz-component.