Minimal benefit to bundling these things together.

Need to update the README

https://www.tweag.io/posts/2019-06-27-cpp-considered-harmful.html

I think the best way of doing this is to drop support for older libs in a new major version release.

https://pusher.com/docs/channels/library_auth_reference/rest-api#post-batch-events-trigger-multiple-events-

Could export them in an Internal.* module.

It brings in much too many deps for a library. Go for something more low-level. http-client may be a good options.

It currently uses this for the Arbitrary instances. It may make more sense to have newtypes in the tests.

One that works in IO and does not MonadReader.

Based on arguments in https://www.reddit.com/r/haskell/comments/64ui11/reasons_i_dislike_type_synonyms/.

It's mainly validation that needs to be tested. Will need to create functions that take get/post operations as dependencies, and also provide "default" functions that use the operations from Pusher.HTTP.

See suggestion here: https://blog.pusher.com/unit-testing-io-in-haskell/#comment-2280443222

https://pusher.com/docs/channels/using_channels/encrypted-channels

Running it currently results in the log lines

Can't open log file "log/access.log".
Exception: log/access.log: openFile: does not exist (No such file or directory)
Logging to stderr instead. **THIS IS BAD, YOU OUGHT TO FIX THIS**

i.e. it complies with ormolu.

To catch any compile time errors.

Makes them more flexible and reduces coupling.

Could be useful for getting data out of return types. Look into: https://github.com/ekmett/lens/wiki/How-can-I-write-lenses-without-depending-on-lens%3F

http-client is TCP only

See: https://github.com/pusher/pusher-http-ruby#receiving-webhooks

It should just be Text. Allowing any Text is less typesafe, but more extensible and consistent with other Channels SDKs.

Need to wrap the API documented here: https://pusher.com/docs/push_notifications/reference/server_api

If you want to get involved and have any questions, let me know.

Have a Channel, PrivateChannel, and PresenceChannel types (latter two automatically handle prefixing).

This should help prevent spelling mistakes in channel names.

We should leave this to the server. e.g. validating length chans > 10.

Current get the warning during stack sdist:

'ghc-options: -Wall -Werror' makes the package very easy to break with future GHC versions because new GHC versions often add new warnings. Use just 'ghc-options: -Wall' instead.

Change parseChannel into a Read instance.

Can do validation on the channel name when parsing. Only problem is that people can construct a Channel directly that is invalid, so this probably isn't the way to too. Probably be best to make Channel data constructor private, and create a getChannel function that does the validation.

I think Credentials should be inlined (particularly because I don't think "Cluster" is a credential)

https://www.haskell.org/cabal/users-guide/file-format-changelog.html

Pusher has deprecated this.

In the post, get method link has address of the master tree of the git repo, which is misleading since post is from 29 September 2015, and many has been changed since then.

I suggest making link a constant by using the following link, which is the repo state from the last commit before writing time of the post:

https://github.com/pusher-community/pusher-http-haskell/blob/3498b74afccef0424766370b3a797cbaa946f472/src/Network/Pusher/Internal/HTTP.hs#L48

Probably best to use Network. Maybe Web.

It would be nice to switch to a well known style that can be enforced with a tool.

I just noticed the compile failure below with GHC 7.8/base-4.7's default install-plan; I haven't investigated further yet

Configuring component lib from pusher-http-haskell-1.1.0.4...
Preprocessing library pusher-http-haskell-1.1.0.4...

src/Network/Pusher.hs:81:8:
    Could not find module ‘Control.Monad.Trans.Except’
    It is a member of the hidden package ‘transformers-0.5.2.0’.
    Perhaps you need to add ‘transformers’ to the build-depends in your .cabal file.
    It is a member of the hidden package ‘transformers-0.4.3.0’.
    Perhaps you need to add ‘transformers’ to the build-depends in your .cabal file.
    It is a member of the hidden package ‘transformers-compat-0.5.1.3’.
    Perhaps you need to add ‘transformers-compat’ to the build-depends in your .cabal file.
    Use -v to see a list of the files searched for.

PS: GHC 7.8's default install-plan most likely picked transformers-0.3, so this may just be a matter of tightening the lower bound on transformers

Show is meant to render runnable Haskell code that is isomorphic to the Read instance. I need to fix this in this library.

Use a cabal flag to build examples.

For example Errors and Channels/Events etc.

The Readme says... "This is currently in the alpha stage of development."

But the version (1.2) indicates ... "We're good to go!"

Which is true? (If alpha, please let me know how I can help bring it up to snuff.)