williewillus / botania-fabric-issues Goto Github PK

Tested on the beta snapshot posted on 11-25-2020

Figure out the vanilla system and port our blockstate and model datagens to it.
As a sanity check, when you run the data generator you should see no functional changes in the output for the blockstates/ and models/ folders.

Blocks #1, #19, #29

(sorry for putting that on the wrong tracker first oops)
Force Relays will disappear when pushed by a piston.

• Place Force Relay
• Optional: Bind
• Push with Piston

Hopperhocks will void items when the attempt to merge stacks.
If a stack of an item it is picking up already exists in an inventory, the picked up item will simply disappear, unless the inventory stack is full, then it will make a new stack.

To reproduce:

• Place hopperhock next to a chest
• Drop a single grass block and wait for it to be picked up
• Drop a more grass blocks
• View chest

Registration is out right now
Consider removing item requirement

Look into https://github.com/FabLabsMC/banner-plus-plus

Makes the game crash with ugly noclassdeffounds and mixin apply errors instead of a nice loader error, just a little oversight

Tested on the beta snapshot posted 11-25-2020

https://pastebin.com/5aHuyT8n

Requires FabricMC/fabric#1178

Manifests as a ton of stuff (spreader inside, curio renders, etc.) being missing model

Minecraft 1.16.3
Fabric Loader 0.10.8
Fabric API 1.16.4-0.27.1
Curios API 1.16.3-0.0.10
Patchouli 1.16.2-44
Libblockattributes 1.16.4-0.8.4
Botania 1.16.3-410

Steps to reproduce: Start the server
Result: Crashes with no class error class 310
Log: https://pastebin.com/0eQjvjQf

using 410-fabric-snapshot.jar in #betas

• place corporea index
• place a master spark on top of it
• relog (due to the hitbox shenanigans, might not have to do this after the fix) relogging appears to be required as of VazkiiMods/Botania@34d64cc
• perform a request at the corporea index
• deadlock

Looks like calling ServerChunkManager#getChunk from a packet handler explodes. In Forge this probably used an event that got executed on the main thread wait it still needs to cancel

Complete stacktrace: https://paste.ee/p/kXq2g

Stacktrace of the server thread:

"Server thread@18302" prio=5 tid=0x43 nid=NA waiting
  java.lang.Thread.State: WAITING
	  at sun.misc.Unsafe.park(Unsafe.java:-1)
	  at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
	  at java.util.concurrent.CompletableFuture$Signaller.block(CompletableFuture.java:1693)
	  at java.util.concurrent.ForkJoinPool.managedBlock(ForkJoinPool.java:3323)
	  at java.util.concurrent.CompletableFuture.waitingGet(CompletableFuture.java:1729)
	  at java.util.concurrent.CompletableFuture.join(CompletableFuture.java:1934)
	  at net.minecraft.server.world.ServerChunkManager.getChunk(ServerChunkManager.java:113)
	  at net.minecraft.world.chunk.ChunkManager.getWorldChunk(ChunkManager.java:14)
	  at net.minecraft.world.World.getEntitiesByClass(World.java:720)
	  at vazkii.botania.common.impl.corporea.CorporeaHelperImpl.getSparkForBlock(CorporeaHelperImpl.java:144)
	  at vazkii.botania.common.block.tile.corporea.TileCorporeaBase.getSpark(TileCorporeaBase.java:24)
	  at vazkii.botania.common.block.tile.corporea.TileCorporeaIndex$InputHandler.onChatMessage(TileCorporeaIndex.java:376)
	  at net.minecraft.server.network.ServerPlayNetworkHandler.handler$zkc000$handleCorporeaRequest(MixinServerPlayNetworkHandler.java:26)
	  at net.minecraft.server.network.ServerPlayNetworkHandler.onGameMessage(ServerPlayNetworkHandler.java:1035)
	  at net.minecraft.network.packet.c2s.play.ChatMessageC2SPacket.apply(ChatMessageC2SPacket.java:31)
	  at net.minecraft.network.packet.c2s.play.ChatMessageC2SPacket.apply(ChatMessageC2SPacket.java:12)
	  at net.minecraft.network.NetworkThreadUtils.method_11072(NetworkThreadUtils.java:20)
	  at net.minecraft.network.NetworkThreadUtils$$Lambda$5742.551374760.run(Unknown Source:-1)
	  at net.minecraft.server.ServerTask.run(ServerTask.java:17)
	  at net.minecraft.util.thread.ThreadExecutor.executeTask(ThreadExecutor.java:136)
	  at net.minecraft.util.thread.ReentrantThreadExecutor.executeTask(ReentrantThreadExecutor.java:22)
	  at net.minecraft.server.MinecraftServer.executeTask(MinecraftServer.java:749)
	  at net.minecraft.server.MinecraftServer.executeTask(MinecraftServer.java:1724)
	  at net.minecraft.util.thread.ThreadExecutor.runTask(ThreadExecutor.java:109)
	  at net.minecraft.server.MinecraftServer.method_20415(MinecraftServer.java:729)
	  at net.minecraft.server.MinecraftServer.runTask(MinecraftServer.java:723)
	  at net.minecraft.util.thread.ThreadExecutor.runTasks(ThreadExecutor.java:119)
	  at net.minecraft.server.MinecraftServer.method_16208(MinecraftServer.java:709)
	  at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:663)
	  at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:224)
	  at net.minecraft.server.MinecraftServer$$Lambda$5282.1403924920.run(Unknown Source:-1)
	  at java.lang.Thread.run(Thread.java:748)

Minecraft 1.16.3
Fabric Loader 0.10.8
Fabric API 1.16.4-0.27.1
Curios API 1.16.3-0.0.10
Patchouli 1.16.2-44
Libblockattributes 1.16.4-0.8.4
Botania 1.16.3-410
Chest Cavity 1.16.3-2.0.0 (and same results with latest 1.16.4-2.2.2)

Steps to reproduce: Create or load a single player world
Result: Immediately see "Saving World" and game closes
Log: https://pastebin.com/Dpw4keQ2 (line 188)

https://cdn.discordapp.com/attachments/481719529337258004/799025083062026330/2021-01-13_15-19-31.mp4

Look into https://github.com/JamiesWhiteShirt/reach-entity-attributes/

Tested on latest fabric pack

Nontrivial, requires support for arbitrary recipe remainder items. Consider implementing FabricMC/fabric#50 (comment)

Fix all commented-out code for datagens and get them running somehow (probably via a dev-only command).

While getting generated data from forge mostly works, it breaks when things use forge tags, so we probably want to do it ourselves.

Additionally, model datagenerators rely on exclusively forge code right now, and it would be nice if they're refactored into portable, vanilla-based code.

Tested on the beta snapshot posted on 11-25-2020

Bunch of lines being dumped of the form:
[20:35:42] [main/ERROR]: Parsing error loading custom advancement botania:recipes/botania/quartz_sunny: Unknown item tag 'forge:gems/quartz'

Minecraft 1.16.4
Fabric 0.10.8
Fabric API 1.16.4-0.27.1
Curios 1.16.3-0.0.10
Patchouli 1.16.4-48
Lib Block Attributes 1.16.4-0.8.4
Botania 1.16.4-411 Fabric
crash-2020-12-29_18.15.46-server.txt

Server crashes when mana spreader attempts to place mana in a mana pool. No Class Defined: class_638. Only happens on dedicated, no crash in single player.

Tested on the beta snapshot posted on 11-25-2020

Tested on the beta snapshot posted on 11-25-2020

Tested on the beta snapshot posted on 11-25-2020

Noticed this on the botania-fabric testing server (might be a crossmod thing, then)

But if you pick up an item, the Pure Daisy particles appear through blocks during the duration of the item pickup. Same for mana burst particles.

Tested on the beta snapshot posted on 11-25-2020

Lexica complains about failed instantiation: https://pastebin.com/CuS4SidW

Exoflames will crash the game when supplied with mana

crash-2021-01-16_12.25.46-server.txt

Exoflame more like Crashdagame haha amirite gamers

There might be an API in FAPI for this

If too hard, consider holding this off until 1.17 which definitely has vanilla API's for this

Botania: Botania-1.16.3-410-FABRIC-SNAPSHOT.jar
Fabric API: [1.16.4] Fabric API 0.26.3
Curios: curios-fabric-0.0.10-1.16.3.jar
Patchouli: Patchouli-1.16.2-44-FABRIC.jar
Lib block: [1.16.4] v0.8.4

Don't seem to be able to craft the petal apothecary. It's entry in the Lexica is also busted.

PR general hook to FAPI if possible

May be difficult

Crash occurs when the table receives enough mana but before the livingrock is placed
Tested on the 11-27-2020 beta

https://pastebin.com/SQp8mdSk

Relics, terra pick, etc.

Tested on the beta snapshot posted on 11-25-2020
Update 02-05-2021: Tested a subset, everything I tested has been marked as working. Further tests required to confirm the rest

• No curios render at all
• Flügel Tiara gliding doesn't work, timer doesn't count down
• Sashes give way too much jump boost (Soujourner's gives 5.5 blocks height, Globetrotter's gives 9.5)
• The following don't do anything:
• • Snow pendant
• • Pyroclast pendant
• • Tainted Blood pendants
• • Tiny Planet charm
• • Invis cloak
• • The Spectator
• • Third Eye
• • Diva charm
• • Far Reach ring
• • Magnet ring
• • Swimming ring
• • Jump pendants
• Crimson pendant/Odin ring still displays fire after leaving e.g. lava
• Magnet rings don't pull when active; after throwing an item they never reactivate
• Cloaks of Judgement don't have any cooldowns between triggers
• When placing with the Loki Ring, blocks are placed at every location except the clicked one
• Odin Ring doesn't give +20HP

I was collecting flowers for my Flower Bag when suddenly it crashed. Worked moments before with one type of flower, then switched to another and crash.

Botania: Botania-1.16.3-410-FABRIC-SNAPSHOT.jar
Fabric API: [1.16.4] Fabric API 0.26.3
Curios: curios-fabric-0.0.10-1.16.3.jar
Patchouli: Patchouli-1.16.2-44-FABRIC.jar
Lib block: [1.16.4] v0.8.4
Crash log: https://pastebin.com/ivwMvr9q
Latest log: https://pastebin.com/4X66ahN1

This might be difficult

Tested on latest fabric pack

https://github.com/Vazkii/Botania/blob/0261fff9df53883df368d9ec3f586e17fa609413/src/main/java/vazkii/botania/common/integration/curios/CurioIntegration.java#L109

Tested on latest fabric pack

Tested on latest fabric pack

Botania: Botania-1.16.3-410-FABRIC-SNAPSHOT.jar
Fabric API: [1.16.3] Fabric API 0.25.0 build 415
Curios: curios-fabric-0.0.10-1.16.3.jar
Patchouli: Patchouli-1.16.2-44-FABRIC.jar
Lib block: [1.16.2/1.16.3] 0.8.2

Crash log: https://pastebin.com/r8pSn49h

Doesn't even get to the Mojang loading screen.

Tested on the beta snapshot posted on 11-25-2020

The Soujourner's Sash manually changes the player's step height instead of using EAMs with the step height entity attribute library. For compatibility with other mods, it should use this.