widmann / firfilt Goto Github PK

Would be great if the option to call this function on certain channels only, e.g....

EEG = pop_eegfiltnew(EEG, 'locutoff',0.5,'plotfreqz',1,'channels', {'Oz'});

...would be documented among the optional iputs in the function header/help (and in the command window output/feedback).

We might want to move this function to a private folder?

/System/Volumes/Data/data/matlab/eeglab/plugins/firfilt/firgauss.m and /Applications/MATLAB_R2021b.app/toolbox/signal/signal/firgauss.m

System information:
MATLAB Version: 9.6.0.1072779 (R2019a)
Operating System: Microsoft Windows 10 Work Station Version 10.0 (Build 17134)
Java Version: Java 1.8.0_181-b13 with Oracle Corporation Java HotSpot(TM) 64-Bit Server VM mixed mode
Parallel Computing Toolbox Version 7.0 (R2019a)
EEGLAB v14.1.2

When running pop_eegfiltnew from cmd line with nargin = 7, the following error occurs:

Undefined function or variable 'revfilt'.

Error in pop_eegfiltnew (line 148)
    if nargin < 5 || isempty(revfilt)	

It seems the logic here is checking for an undefined variable. Commenting out lines 148-164 does the trick.

Transfered from Bugzilla https://sccn.ucsd.edu/bugzilla/show_bug.cgi?id=1963

Filter order (filter length - 1) is computed automatically (no value in GUI or also CLI) the transition band width is computed before it is checked whether filter order is actually even (mandatory). In case not, it is rounded up to the next even integer. Thus, true transition band width is minimally smaller than expected.

Documentation inconsistent with function behavior - switch high pass and low pass parameters

Hello,

I'm on my first eeglab project, and I'm having an eeggiltnew() error at line 175 while using the GUI. This happens after trying to apply an 8th order notch filter on a .study file that contains 10 datasets.

pop_eegfiltnew error: argument 'filtorder' must be numeric,
This is not a bug (Error occured in function pop_eegfiltnew() at line 175)

I typed 58 for lowpass, 62 for highpass, 8 for filter order, and enabled the notch option.

I'm comparing this filter against others so I need to report the filter order. If I cannot use an 8th order filter, I'd like to know if there's a way to get the default order.

Any answers appreciated. Thank you.

I encountered this error when I was filtering，please help me！thanks