The unifi-dns from wicol

Support stopping container gracefully

Docker can't stop the container gracefully and will use SIGKILL (exit code 137).
I believe this is due to not handling the signal SIGTERM in the shell script.

Nice! Could this be run as an onboot script?

Per here: https://github.com/boostchicken/udm-utilities/tree/master/on-boot-script

Would it be possible to just change this to an onboot script and store the files on the device so that it doesn't have to run as a docker image? My understanding is that this persists until firmeware update and the on boot script stuff runs automatically on every restart.

Would be an awesome and simple way to make this work...

Name and Hostname should be used

The NAME only seems to appear with an Alias defined. Would be helpful to enable the "Hostname" entry as an option. At least in the initial runs it can be used to help identify unknown items. Not all my bulbs and other devices are reporting correctly.

Nice work. I'm modifying the script to add a log.warn which provides details on each device to help me figure out what some of them are.

Add Support for cloudkeys running Unifi OS?

Cloudkeys (inc Gen 2 that I have) were recenly updated to Unifi OS. The script does not appear to work with these?
https://community.ui.com/questions/CloudKey-Gen2-updated-8443-not-working-anymore-reset-still-same-issue/c384eca4-d754-4cec-9518-161ca2552fd6

the default UNIFI_BASEURL includes port 8443 whereas the new OS no longer has that open; all services are consolidated on port 443
(Leaving a trailing / on the URL confuses the path handling sending it to a 404 page, it'd be nice to handle that case)
Fixing the URL to point to 443 sends the JSON decoder into a spin:

/usr/local/lib/python3.9/site-packages/urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host 'cloudkey'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings,
  warnings.warn(,
/usr/local/lib/python3.9/site-packages/urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host 'cloudkey'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings,
  warnings.warn(,
Traceback (most recent call last):,
  File "/app/./get_unifi_reservations.py", line 80, in <module>,
    for c in get_clients():,
  File "/app/./get_unifi_reservations.py", line 45, in get_clients,
    clients = get_configured_clients(s),
  File "/app/./get_unifi_reservations.py", line 24, in get_configured_clients,
    return r.json()["data"],
  File "/usr/local/lib/python3.9/site-packages/requests/models.py", line 900, in json,
    return complexjson.loads(self.text, **kwargs),
  File "/usr/local/lib/python3.9/json/__init__.py", line 346, in loads,
    return _default_decoder.decode(s),
  File "/usr/local/lib/python3.9/json/decoder.py", line 337, in decode,
    obj, end = self.raw_decode(s, idx=_w(s, 0).end()),
  File "/usr/local/lib/python3.9/json/decoder.py", line 355, in raw_decode,
    raise JSONDecodeError("Expecting value", s, err.value) from None,
json.decoder.JSONDecodeError: Expecting value: line 2 column 1 (char 1),

LMK if I can collect some more logs to debug further

wicol / unifi-dns Goto Github PK

unifi-dns's People

Contributors

Stargazers

Watchers

Forkers

unifi-dns's Issues

Support stopping container gracefully

Nice! Could this be run as an onboot script?

Name and Hostname should be used

Add Support for cloudkeys running Unifi OS?

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent