wi-ry / misc-powershell Goto Github PK

Running New-RandomString2 doesn't include numbers in the passwords generated, but it should.

Need to look into why at some point

With some tweaks to the code, I think this script could check multiple subreddits. I feel like that would be smart, especially when combined with making the naming of files be human-readable, at that would catch crossposts and eliminate duplicates.

per my understanding, this script:

1. Downloads JSON
2. Looks for URLs within JSON
3. checks URLs for a specific string (using a regex)
4. Counts the number of hits
5. Provides a status to the user via commandline (number of images to download, and percentage completed).
6. Validates that the already-downloaded images are of specified resolution, and deletes them if not.

What it does not do is, interpret the JSON a PowerShell object, using the ConvertFrom-JSON cmdlet.

I think refactoring the code to use ConvertFrom-JSON could improve things. For example, the script could name the files based on the Title of the Reddit thread, rather than the original filename (which is randomized or serial-numbered, not human-readable).

It may also allow filtering on keywords, tags, or resolutions of images based on the properties available within the JSON. As I haven't implemented this myself, I can't say for sure, but I'd wager at least some of this would be easy enough to do.

Alternatively, the script could be reimplemented to use a Hashtable. This would give a similar result.

By design, this script only downloads files with names like *.JPG. Should a file be named *.JPEG it will not be processed. PNG files will also not be processed.

I'm working on a way to fix that.

There's a significant block of code in this script which appears to be present specifically to check that files are no smaller than the specified minimum Height and Width parameters.

The Height and Width values of the images are contained within the JSON:

data.children.data.preview.images.source.height
data.children.data.preview.images.source.width

We can filter out files that are below the minimum specified by the input parameters, just have to rework a bit of the code. I'll see what I can do.