whiteoutmashups / mockroutingpack Goto Github PK

It would be really nice from a testing perspective is the safe_launcher did not ask for permission when built against mock routing. If we could also make it headless, it would make integration into CI systems much easier. This seems like the sort of thing that it might be worth getting help from upstream on.

As with #1, I don't have time to devote to this right now, but I wanted to share my thoughts anyway.

I wanted to download the MAC-OSX code but it just spins. Do you have instructions for manual downloading ?

It would be nice to have a single script that could do everything that you need to build a safe_launcher with mock routing. A thumbnail sketch of how to do this is:

• Add a git submodule for both safe_core (now called safe_client_libs on github) and safe_launcher pinned to some known-good commits. This will make sure that updates to the upstream repos do not break anything.
• Write a script that checks to make sure that node, npm, cargo, and rustc are installed and have the right versions. If any checks fail the script should print links to the best place to install the various tools from.
• Actually run all of the build steps (cargo build, copying the build artifact, npm install, ...).

I have a lot on my plate at the moment, so I won't be able to get to this soon, but I can certainly provide advice if anyone wants to tackle it. I can also just attack it when things cool down a little for me.