The finagle-kubernetes-resolver from whisklabs

finagle-kubernetes-resolver's People

Contributors

Stargazers

Watchers

finagle-kubernetes-resolver's Issues

Need to log endpoint name when error happened.

Need to add here endpoint name.

finagle-kubernetes-resolver/src/main/scala/com/whisk/k8s/resolver/PollingEndpointWatch.scala

Line 25 in 2dc2529

logger.error(e, "Error in polling")

Why: no addresses returned by k8s api when service not ready.

Example:

curl -H "Authorization: Bearer $(cat /var/run/secrets/kubernetes.io/serviceaccount/token)" https://$KUBERNETES_SERVICE_HOST:$KUBERNETES_PORT_443_TCP_PORT/api/v1/namespaces/default/endpoints/segmentation-server-thrift -k
{
  "kind": "Endpoints",
  "apiVersion": "v1",
  "metadata": {
    "name": "segmentation-server-thrift",
    "namespace": "default",
    "selfLink": "/api/v1/namespaces/default/endpoints/segmentation-server-thrift",
    "uid": "a9ce8f88-a253-11e9-b564-06f9eb752e9c",
    "resourceVersion": "650393",
    "creationTimestamp": "2019-07-09T14:13:02Z",
    "labels": {
      "app": "segmentation-server-thrift",
      "env": "dev"
    }
  },
  "subsets": [
    {
      "notReadyAddresses": [
        {
          "ip": "172.19.166.38",
          "nodeName": "ip-172-19-179-27.eu-west-2.compute.internal",
          "targetRef": {
            "kind": "Pod",
            "namespace": "default",
            "name": "segmentation-server-thrift-6f6c454f9d-jskvr",
            "uid": "a9c344be-a253-11e9-b564-06f9eb752e9c",
            "resourceVersion": "650392"
          }
        }
      ],
      "ports": [
        {
          "name": "thrift",
          "port": 50054,
          "protocol": "TCP"
        }
      ]
    }
  ]
}```

Recommend Projects