wheely / ember-dialog Goto Github PK

Ember dialog sets target key of controller to the dialog. This prevents from makking transitionToRoute calls inside accept function.

Is there any work around for this.

• List of a Presenter and Manager Events
• Closing Dialog Programmatically (link to Creating Notices)

Hi,

I'm trying to use ember-dialog in my project, but when dialog is appearing at screen I can't close it (using OK button or X icon or clicking outside dialog).
In Event Listeners tab there is no click event on OK button

Environment data:

Ember             : 2.11.2
jQuery            : 3.1.1
Ember Dialog      : 3.0.0-rc.8

It's depends on Ember version or this is a bug somewhere in plugin?

Service's name dialogManager should be in environment settings.

Hi,

I'm upgrading ember-cli to 2.13, but it seems that ember-dialog does't work with the latest version of ember-cli, there is an error:

[email protected] requires the host to use ember-cli-babel@5. To use ember-cli-babel@6 please upgrade ember-cli-htmlbars-inline-precompile to 0.4.

The ember-cli-htmlbars-inline-precompileis conflicted. I saw the package.json has been updated and fixed this issue, would you mind to publish this change?

• What is presenter
• What is dialog manager
• How does they work
• What is context and options
• What options presenter has
• Concept of dialog lifecycle

• How to include styles to the project
• What classes dialog has and for what they're responsible
• How to animate dialog behaviour
• How to add and use new dialog layouts

To able to do like that:

<button {{action 'showModal'
                 'entry-form-view'
                 'controller:entry'
                 type="confirm" title="New entry"
}}>Reply</button>

I've ran into the problem of using ember-dialog with [email protected]. Seems the Ember Component does not have template property anymore, and the dialogs show up without body. While with the previous version of [email protected] it works fine.

You may reproduce the problem so:

app/components/foo-bar.js

import Ember from "ember";
import hbs from 'htmlbars-inline-precompile';

Ember.Component.extend({
  template: hbs`A TEMPLATE`
})

app/components/foo-bar.hbs

BEGIN {{yield}} END

Ember v2.9.1 will output: BEGIN A TEMPLATE END, but Ember v2.10.10 will output: BEGIN END

• Include ember-validation to the project as devDependency
• Creating page and link for it
• Add example of data binding
• Add example of closing interruption if form is not valid

As we just did a deploy to production using the plugin we ran into problems. Afaik the current implementation is dependent on Ember.Handlebars.compile which is discouraged #ember-cli/972.

We managed to get it working by customising our built-in Assets http://www.ember-cli.com/#customizing-a-built-in-asset, although I consider this solution as temporary.

Sections:

• Creating Dialog From a Template
• Creating Dialog From a Controller
• Creating Dialog From a Component

• #46 - Tutorial: Customizing dialog
• #47 - Tutorial: Presenter and Dialog Manager
• #49 - Tutorial: Creating Your First Dialog
• #50 - Tutorial: Creating Dialog Templates
• #51 - Tutorial: Listening Events
• #52 - Tutorial: Interrupt Closing
• #45 - Cookbook: Working with forms
• #55 - Cookbook: Creating Notices
• #56 - Cookbook: Showing Server Errors
• #58 - Cookbook: Animation

Scheduling into the 'sync' run loop queue is deprecated. [deprecation id: ember-metal.run.sync]

https://github.com/wheely/ember-dialog/blob/master/addon/services/dialog.js#L335

Some parts may be used from the page Cookbook/Your first dialog.

TypeError: Invalid Fullname, expected: type:name got: template:

Do you have documentation how to test component/controllers which use your dialog service?
And also do you have documentation how to test a templates/component/forms inside a dialog?
Can you provide some test helpers for integration and acceptance tests?

When dialog appear, the first input element, in it, gets focus. Occures even when dialog contains a select element higher.

• Escape button should close dialog window.
  • For alert dialog it should be accept closing
  • For confirm dialog it should be decline closing
  • For blank dialog it shouldn't close it
• Enter button should close dialog window
  • For alert dialog it should be accept closing
  • For confirm dialog it should be accept closing
  • For blank dialog it shouldn't close it
• Make tests for it
• Add tutorial page "Hotkeys"

Disclaimer: I am posting this issue here becaus the project ember-cli-dialog does not have an issue tracker.

I installed ember-cli-dialog, build my project, and immediately I get the following error in my console:

Error: Cannot call `compile` without the template compiler loaded. Please load `ember-template-compiler.js` prior to calling `compile`.

And no modules can be loaded (it's broken). There is no way to use this project!

The above is using ember install ember-cli-dialog and it installed version 0.0.6.

I then tried against the latest commit in ember-cli-dialog beta1 and the latest commit in ember-dialog beta. With this configuration, there is no immediate error, but this error comes up as soon as I call this.get('dialogManager').confirm(message):

Error: You have to include `ember-template-compiler.js` file to compile templates on fly. If you don't want to, you should provide a view instead or template name.