Git Product home page Git Product logo

Comments (7)

whawker avatar whawker commented on May 16, 2024 2

Published as 1.3.2, thanks for the heads up and debugging.

from react-jsx-highcharts.

whawker avatar whawker commented on May 16, 2024

Hmm I'm not sure why the reference would be deleted. I've never seen that before.

What version of React are you using?

from react-jsx-highcharts.

sradevski avatar sradevski commented on May 16, 2024

I am not at work currently so I can't check, but since I upgraded our dependencies just few days ago it should be 15.6.1.

from react-jsx-highcharts.

whawker avatar whawker commented on May 16, 2024

Ok thanks, by any chance is the component mounted, then unmounted almost immediately? I can't think of many reasons why this.chart would be undefined.

from react-jsx-highcharts.

sradevski avatar sradevski commented on May 16, 2024

I didn't really spend a lot of time debugging, I just added an additional check so I can continue with development, but I can have a look if it helps.

from react-jsx-highcharts.

sradevski avatar sradevski commented on May 16, 2024

I found the cause of it. I have wrapped the chart in another component, that only renders its children when the status is not loading. It seems React instantiates the children before they are rendered, and then immediately unmounts them, before the this.chart object is created. If I take <HighGmsChart ... /> out of the StatusWrapper component, it works as expected. This is because isLoading and errorMessage are set from the Redux state, which causes a re-render almost instantly as the values change when the fetch request is sent.

<StatusWrapper
          isLoading={isAnalysisDataFetching}
          errorMessage={analysisDataError}
          <HighGmsChart height={450} seriesData={seriesData} />
</StatusWrapper>

Render method of StatusWrapper:

...
<div style={style}>
      {Spinner || ErrorMessage || children}
</div>

Although it is possible to handle this by react-jsx-highcharts users, I think this should be gracefully handled by the library. What do you think?

from react-jsx-highcharts.

whawker avatar whawker commented on May 16, 2024

Interesting, I didn't know about that React behaviour.

Yep I'll wrap the componentDidUnmount in an if statement and push out a new release.

from react-jsx-highcharts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.