Comments (13)
@whawker I guess the v5 could be released, what do you think?
from react-jsx-highcharts.
v5 is now released
from react-jsx-highcharts.
Testing this version now and it looks good so far 🙂
from react-jsx-highcharts.
Testing this version now and it looks good so far 🙂
Nice! Did you test with react v18?
from react-jsx-highcharts.
Yes, using React 18. Had to hold off on Highcharts 10 though due to some issues with offline exporting that we haven't solved yet.
UPDATE: Sorted out the exporting issues (was missing a Highcharts module), so now we're happily running on all the latest.
from react-jsx-highcharts.
@whawker do you mind if I release the v5?
from react-jsx-highcharts.
I tried to upgrade to highcharts v10.1.0, and tests started to fail, so maybe the v5 shouldn't be released yet :(
from react-jsx-highcharts.
I can't reproduce the test failures in normal react app. Those tests probably fail because jsdom doesn't set width and height for elements.
The error:
TypeError: Cannot read properties of undefined (reading 'length')
47 | // they can be accessed
48 | if (axis.plotLinesAndBands && axis.plotLinesAndBands.length > 0) {
> 49 | axis.update(updateProps, true);
| ^
50 | } else {
51 | axis.update(updateProps, false);
52 | chart.needsRedraw();
at a.length [as setTickPositions] (../../node_modules/highcharts/highcharts.src.js:20183:25)
at a.setTickPositions [as setTickInterval] (../../node_modules/highcharts/highcharts.src.js:20087:17)
at a.setTickInterval [as setScale] (../../node_modules/highcharts/highcharts.src.js:20560:21)
at setScale (../../node_modules/highcharts/highcharts.src.js:30727:21)
at Array.forEach (<anonymous>)
at a.forEach [as redraw] (../../node_modules/highcharts/highcharts.src.js:30725:17)
at a.redraw (../../node_modules/highcharts/highcharts.src.js:21978:21)
at update (src/components/Axis/Axis.js:49:14)
at commitHookEffectListMount (../../node_modules/react-dom/cjs/react-dom.development.js:23049:26)
at commitPassiveMountOnFiber (../../node_modules/react-dom/cjs/react-dom.development.js:24821:11)
at commitPassiveMountEffects_complete (../../node_modules/react-dom/cjs/react-dom.development.js:24781:9)
at commitPassiveMountEffects_begin (../../node_modules/react-dom/cjs/react-dom.development.js:24768:7)
at commitPassiveMountEffects (../../node_modules/react-dom/cjs/react-dom.development.js:24756:3)
at flushPassiveEffectsImpl (../../node_modules/react-dom/cjs/react-dom.development.js:26990:3)
at flushPassiveEffects (../../node_modules/react-dom/cjs/react-dom.development.js:26935:14)
at ../../node_modules/react-dom/cjs/react-dom.development.js:26725:9
at flushActQueue (../../node_modules/react/cjs/react.development.js:2665:24)
at act (../../node_modules/react/cjs/react.development.js:2580:11)
at ../../node_modules/@testing-library/react/dist/act-compat.js:57:25
at renderRoot (../../node_modules/@testing-library/react/dist/pure.js:159:26)
at Object.rerender (../../node_modules/@testing-library/react/dist/pure.js:178:7)
at Object.rerender (test/components/PlotBandLine/PlotBandLineLabel.integration.spec.js:74:15)
from react-jsx-highcharts.
Test failure in [email protected] is a bug in highcharts itself:
highcharts/highcharts#17300
from react-jsx-highcharts.
@whawker As the bug is reported to highcharts and it doesn't trigger in browser, I think we could make a release. Do you mind if I release v5 final?
As #364 shows, it fixes problems with React 18.
from react-jsx-highcharts.
Happy to push v5 out!
from react-jsx-highcharts.
@whawker can you please upgrade the reproduction template in https://stackblitz.com/edit/base-chart-example to new version. Here is my fork of it with React 18 createRoot https://stackblitz.com/edit/base-chart-example-rnw6ff?file=index.js
from react-jsx-highcharts.
@anajavi updated the examples repo 👍
from react-jsx-highcharts.
Related Issues (20)
- TypeScript type for react-jsx-highmaps HOT 6
- Bug When Rendering Chart in Test HOT 2
- Add ColorAxis component causes error in highcharts.js HOT 2
- I would like to know the x-axis plot band widths dynamically with events redraw and load HOT 6
- Vertical zoom navigator
- Cannot read properties of undefined (reading 'forExport') in Next HOT 3
- Setting draggableY to plotOptions not working correctly HOT 2
- React Native support
- Using canvas or SVG to draw on a Chart HOT 2
- Enabled not working with plotOptions using Highcharts HOT 2
- Change the range of the chart from the code HOT 1
- Extending HIghcharts with addHighchartsMore causes error HOT 1
- `ordinal` does not work for X axis. HOT 2
- How to use custom highchart colors cssNames?
- Ability to export a graph HOT 6
- Chart prop 'zoomType' not working with Highcharts 10.2.1 HOT 4
- Chart updates without animation if zones is provided on a series
- Show and hide series with costume buttons ?
- <LineSeries data={values} /> to have multiple dashStyle in single series HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-jsx-highcharts.