Comments (3)
Hi @prioritylabs
Thanks for the info. The problem is here - https://github.com/wellcometrust/timeline/blob/master/src/js/embed.js#L153
Need to consider protocol as well as other link props.
It works over http:
http://wellcomelibrary.org/collections/digital-collections/makers-of-modern-genetics/genetics-timeline/
I will fix this. Thanks!
from timeline.
Hi @jennpb - seeing as this is now a wellcometrust repo, I didn't accept my own pull request (#8). I have deployed the fix to wellcomelibrary.org though, as https://github.com/wellcomelibrary/dds-ecosystem/pull/23.
from timeline.
from timeline.
Related Issues (11)
- API? HOT 3
- Running in localhost HOT 1
- Video support?
- Timelines with many events spanning a short period HOT 2
- Cross Platform Build HOT 4
- Vertical timeline
- Convert to run from IIIF manifest with navDate
- Incompatibilities when deploying on another site
- Our site using a modified version of Wellcometrust timeline viewer.
- We've uncovered a display problem with the timelines function on both websites. They've stopped working on Chrome, Safari, and FF, but still work fine on MS Edge HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from timeline.