Git Product home page Git Product logo

Comments (3)

tomcrane avatar tomcrane commented on August 21, 2024

Hi @prioritylabs
Thanks for the info. The problem is here - https://github.com/wellcometrust/timeline/blob/master/src/js/embed.js#L153

Need to consider protocol as well as other link props.

It works over http:
http://wellcomelibrary.org/collections/digital-collections/makers-of-modern-genetics/genetics-timeline/

I will fix this. Thanks!

from timeline.

tomcrane avatar tomcrane commented on August 21, 2024

Hi @jennpb - seeing as this is now a wellcometrust repo, I didn't accept my own pull request (#8). I have deployed the fix to wellcomelibrary.org though, as https://github.com/wellcomelibrary/dds-ecosystem/pull/23.

from timeline.

tomcrane avatar tomcrane commented on August 21, 2024

@edsilv FYI - fixed in #8

from timeline.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.