wednesday-solutions / go-template Goto Github PK

Background

Repo github.com/wednesday-solutions/go-template depends on github.com/agiledragon/[email protected].

https://github.com/wednesday-solutions/go-template/blob/master/go.mod#L8

However, comparing version v2.2.0 of github.com/agiledragon/gomonkey from proxy.golang.org and github, there are inconsistencies.

commit time of the copy on github.com

"committer": {
      "name": "agiledragon",
      "email": "[email protected]",
      "date": "2021-08-16T15:49:31Z"
    }

commit time of the copy on proxy.golang.org

{"Version":"v2.2.0","Time":"2021-08-13T12:46:58Z"}

So the checksum from the code in github does not match the checksum saved in sum.golang.org. The v2.2.0 tag of github.com/agiledragon/gomonkey might have been retagged after a minor edition on github. I guess you use proxy.golang.org to get dependencies, but that also shows that your project is depending on the copy of github.com/agiledragon/[email protected] before its edition. Depending upon such inconsistent tag version may also result in some unexpected errors as well as build errors due to different proxy settings.

For example, when someone who does not use proxy.golang.org, say GOPROXY=direct, attempts to get github.com/agiledragon/[email protected], the following errors occur.

go: downloading github.com/agiledragon/gomonkey/v2 v2.2.0
go: github.com/agiledragon/gomonkey/v2@v2.2.0: verifying module: checksum mismatch
        downloaded: h1:SXUF5UN7ZH67ORjFK+e1FoFRZczCSVUvwTywNY2+fcg=
        sum.golang.org: h1:QJWqpdEhGV/JJy70sZ/LDnhbSlMrqHAWHcNOjz1kyuI=

SECURITY ERROR
This download does NOT match the one reported by the checksum server.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

For more information, see 'go help module-auth'.

So, this is a reminder in the hope that you can get rid of this unreliable version of project github.com/agiledragon/gomonkey.

Solution

1. Bump the version of dependency github.com/agiledragon/gomonkey

I would recommend bumping the version of github.com/agiledragon/gomonkey to a new release to ensure dependency copy in proxy.golang.org and github in sync.

References

• https://proxy.golang.org/

I was trying to setup this template by following the getting started on the README.

I tried running pre-commit-setup.sh with bash but it exited with non-zero return code. brew wasn't found on my system.

Is this template expected to be used on MacOS only? If not can we have the pre-commit installation done by pip? I hope python comes by default on MacOS?

Requesting feedback.