webkom / brus Goto Github PK

• Remove documentation from urls.py
• Maybe create a custom login view
• Remove static urls from production
• Remove the settings/settings.py file
• Remove celery options
• Change ALLOWED_HOSTS default in production.py
• REMOVE ABAKUS_TOKEN from opensource repository (base.py, production.py) 👊
• Restrict to Webkom group (django-auth-abakus)
• settings/init.py line 14 lego?
• templates/brus/index.html line 98-114?
• liste/models.py line 35-52?

Consider adding isort, flake8, tox and a readme.

This ensures validation. Should be used for the Person model :)

• ModelForm for AddNameForm
  https://docs.djangoproject.com/es/1.9/topics/forms/modelforms/#modelform
• Make use of the ModelForm in views.py instead of Persons.objects.create()
  https://docs.djangoproject.com/es/1.9/topics/forms/modelforms/#the-save-method
• Maybe refactor to AddPersonForm?
• Maybe unique=True in name field on Persons
• Use crispy forms on the addForm

I think we should add a readme and licence file to this repository 😇

opensource ftw!

@tmsolber @hanswilw