prj-rev-bwfs-tea-cozy's People
prj-rev-bwfs-tea-cozy's Issues
Alt text
prj-rev-bwfs-tea-cozy/tea cozy/index.html
Line 48 in 02d140c
All images should have descriptive alt text. The visually impaired rely on alt text through the use of screen readers on their computers and mobile devices.
Summary
Overall met expectations.
You were close visually to the mock. Visually, your issues had to do with not constraining your divs with width and centering it. The other issues are more on fundamentals and some common conventions on building a website. These mistakes are common in the beginning and go away with some experience.
To prepare you for the final projects, look at media queries. See if you can make this site fit inside of a mobile device by using one. You will be doing this heavily in your final projects.
https://developer.mozilla.org/en-US/docs/Web/CSS/Media_Queries/Using_media_queries
Item class.
prj-rev-bwfs-tea-cozy/tea cozy/index.html
Line 47 in 02d140c
The only time you use the .item class in your CSS was to target the image, why not give the image a class directly? Specificity might make a difference when your projects are larger in complexity.
Display:block on divs
All divs by default have display: block. This is redundant and unnecessary to write. A use case for when want to display: block a div, typically happens you used a different display option and need to change it back to block for a media query. You will be doing this heavily in these final projects.
Use relative urls for your links otherwise they won't work.
Currently, the path to your CSS file is linked directly to your computer. Unless I am physically at your computer, your CSS won't be viewable and it will not work on any web servers. This is how it looks like on my screen.
In general, you want to use the relative url, that is in relation to the location of the file you write this in. Your link corrected below.
Site is repeating and off center in different locations.
Screenshot below. If for some reason you didn't notice this and you were programming on a small laptop, realize that they tend to have lower resolution screens. Have to program as though people have different screen sizes and be mindful of that. Also, You have to think as div as the main container for each section and the reason why I am mentioning this is that you set the width of your .our class to 1200px, but you didn't do that for the mission div. As a result, the div stretches out like this. Had you done this with the mission class everything inside of that would say at that within width.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.