weberbox / pifire-android Goto Github PK

The app seems to keep crashing in Android 12. Sorry dont have anymore details.

Describe the bug

OK, I am not sure if this is expected behavior, but when I was trying to setup the Android App today - I found that I couldn't manually enable OneSignal in the WebUI settings page.

And when I went to look at the app.py code, I found that it only had the following for OneSignal setup - but no input for enabling.

		if('delete_device' in response):
			DeviceID = response['delete_device']
			settings['onesignal']['devices'].pop(DeviceID)

		if('edit_device' in response):
			if(response['edit_device'] != ''):
				DeviceID = response['edit_device']
				settings['onesignal']['devices'][DeviceID] = {
					'friendly_name' : response['FriendlyName_' + DeviceID],
					'device_name' : response['DeviceName_' + DeviceID],
					'app_version' : response['AppVersion_' + DeviceID]
				}

Or, was this by design? I can get the app to connect to my server if I go and manually update my settings.

Steps to Reproduce

1. In PiFire WebUI, go to settings > notify
2. Toggle enable for OneSignal
3. Save

Try to connect via App, and it will fail.

Expected Behavior

No response

PiFire Android Version

v1.4.1

PiFire Server Version

v1.3.1

Mobile Device

Nexus 7

Additional Context

No response