webdevlabs / phreak Goto Github PK

I've noticed this issue when passing cached objects to anonymous functions for routing like
$router->get('/some', function () use ($someting) {});
the Stash caching library is unable to serialize() complicated Closure's in routes.
The problem is visible when we use ($something) and if $something is a cached object inside DI Container.
Normaly we don't need to do this. We can just pass a Controller class instead of objects inside anonymous functions. This is the correct usage: $router->get('/some', ['App\Class','myMethod']);

The solution is to avoid using Closures for Routes.

This issue is described at http://php-di.org/doc/php-definitions.html as
Be also aware that it isn't possible to add definitions to a container on the fly when using a cache
Phreak! uses caching for the Router inside a Dependency Injection Container, so all routes are resolved inside the cached container.
Thats why Phreak! stands above the other frameworks in the SPEED competition.
This voids to the described issue. However it's only a problem if you want to use $container->set() function inside your scripts.

SOLUTION: You can manualy modify and disable the Router resolver behaviour from system/RouterResolver.php.