netError.xhtml broken about webconverger-addon HOT 16 CLOSED

I saw this and was wondering what was going on.

from webconverger-addon.

I'll check on this.

from webconverger-addon.

I updated wget 'http://mxr.mozilla.org/mozilla-central/source/docshell/resources/content/netError.xhtml?raw=1' -O netError.xhtml and I still get entity errors. E.g. &nssFailure2.longDesc2;

Hate XML. :P

from webconverger-addon.

I downloaded FF30 source and it's &nssFailure2.longDesc; not &nssFailure2.longDesc2;.

HAH

from webconverger-addon.

I forgot we override those files. Why do we do that again?

from webconverger-addon.

I'm not sure you need to override those files anymore. Looking at the history, any changes you made don't apply anymore except maybe the:

• setTimeout(location.reload(), 3000);
• setTimeout(location.reload, 10000);

?

from webconverger-addon.

It looks like you override it specifically so it will retry? I think I can do that without touching the source file. I'll check.

from webconverger-addon.

Thanks, I updated the #30 pull request fixing my silly mistake. Watching football and coding is tricky. ;)

Perhaps we can pencil in "without touching the source file" as a future re-factoring effort?

from webconverger-addon.

Perhaps we can pencil in "without touching the source file" as a future re-factoring effort?

Yes.

from webconverger-addon.

Ok, can you please merge my pull request #30 ?

from webconverger-addon.

Ok, can you please merge my pull request #30 ?

I don't know how to do that locally, but looking at the diff, the problem is you have:

location.reload()

when it should be

location.reload

which is what it was originally.

from webconverger-addon.

oh, WTF, I changed it from location.reload to location.reload() and I thought it started working.

Maybe I should look again at this tomorrow. Grrr.

from webconverger-addon.

Well, with location.reload(), the reload happens every time the page loads, so it just constantly reloads.

So it could look like it was working :)

from webconverger-addon.

Yes, I want it to constantly reload, well every 10 seconds....

from webconverger-addon.

Changing it back to location.reload will do that. That function will be called every 10 seconds.

The parens made it get called immediately.

from webconverger-addon.

I changed it back to location.reload in my working dir and it doesn't retry every 10 seconds. Just stays on the netError page. Am I going crazy? Can you reproduce?

Otherwise stick with location.reload() ??

from webconverger-addon.