Shift click on a link opens new window about webconverger-addon HOT 6 CLOSED

There's a Firefox function called "whereToOpenLink" that does this. So we would need to override this in wc.js. Something like:

function ourWhereToOpenLink( e, ignoreButton, ignoreAlt ) {
var where = theirWhereToOpenLink(e, ignoreButton, ignoreAlt);
if (where == "window") {
where = "tab";
}
return where;
}

var theirWhereToOpenLink;
var theirWhereToOpenLink = whereToOpenLink;
whereToOpenLink = ourWhereToOpenLink;

The other possibilities for where are:
current, tabshifted, tab, save, window

We might want to handle those as well.

tabshifted is a new tab in the background.

from webconverger-addon.

"var theirWhereToOpenLink;" looks weird... surely that can't be the way one overrides? 😕

Anyway, I hope we can get a solution together quickly. This one is high priority.

from webconverger-addon.

Well we need to override their function, but we still need to call their function. I don't know of any other way to do that.

from webconverger-addon.

Ok, could you please flesh it out and I'll happily test it and try improve on it. Got to teach me to fish a bit maybe. ;)

from webconverger-addon.

Well there isn't much to flesh out :).

So basically the situation here is that Firefox has a function that attempts to figure out where to open a link:

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/utilityOverlay.js#114

We have two choices.

1. Implement our own version of that function (which might not be terrible - it doesn't do much).
2. Override that function with our own version that calls it and then modifies the results that we don't like (which is what I wrote).

There's not really a way to make it more elegant...

from webconverger-addon.

Well, I can make it look more elegant:

var ffWhereToOpenLink = whereToOpenLink;

whereToOpenLink = function(e, ignoreButton, ignoreAlt) {
var where = ffWhereToOpenLink(e, ignoreButton, ignoreAlt);
if (where == "window") {
where = "tab";
}
return where;
}

This is my final version. It should cover our needs.

from webconverger-addon.