Numerous CSS tests are incorrectly marked as failing in Edge due to Ahem anti-aliasing on Windows about wpt HOT 7 CLOSED

There are a few places where command line arguments can be added. The main one for Edge is here:

Due to the chrome_executor_kwargs call, things added to Chrome will also apply to Edge. So if Chrome would have the same problem on Windows, I think adding the arguments to Chrome would make the most sense.

If this issue is somehow specific to the CI environment, another option is to add things here:

I don't think that's the case, but for Taskcluster we have some additional command line arguments for Chrome and Firefox, so it's a possibility.

from wpt.

Thanks @KurtCattiSchmidt! WebKit has apparently also disabled anti-aliasing for Ahem: WebKit/WebKit@605fcea. So I think it's reasonable to go with approach (1).

from wpt.

Thanks @foolip, I will make these changes in WPT once my Chromium CL lands. This does indeed impact Chrome on Windows, so I'll make the change there too.

from wpt.

Thanks to @gastonrod for bringing this to my attention! CC @alisonmaher @bfgeek @drott

from wpt.

Can we explore combining 1 and 2 more? Safari still disables Ahem antialiasing without any flag guard. Firefox disables AA as a combination of a preference setting and a family name match.

I would find generally enabling this by family name a surprising effect, I am okay doing a combination of 2 and 1 (like FF): Disabling antialiasing for Ahem, under a flag guard, even if that unfortunately means the WPT runner configuration would have to be adapter.

@foolip, would you have any pointers as to where the WPT runner launch parameters for Edge on Windows can be configured?

from wpt.

@KurtCattiSchmidt have you been able to see if the fix worked yet?

from wpt.

@KurtCattiSchmidt have you been able to see if the fix worked yet?

Yes! I had to wait for the 126 release, which is now in Beta. The individual cases that I've been tracking are now marked as passing in Edge.

@foolip - is there an easy to determine exactly how many passes are due to this change?

from wpt.