Comments (17)
It seems that the failing commit b119144 (with 10 canceled checks) in #42345 was successfully squashed and merged (or registered or embedded) .
So, I am closing this issue now.
Thank you @foolip and @whimboo for your assistance. This is appreciated.
from wpt.
@TalbotG I don't know what the problem is. But what we usually do is to close and reopen a PR to re-trigger all the checks. That's the first thing that I would suggest to do. If that doesn't help maybe someone else has more ideas.
from wpt.
I see that the checks are passing on the PR now.
In https://github.com/web-platform-tests/wpt/runs/25140134004 (for commit b119144) I think the problem was actually that the Taskcluster tasks were cancelled for some reason.
Closing this as the problem did not persist.
from wpt.
I see that the checks are passing on the PR now.
@foolip Philip,
Where exactly do you see that the checks are passing or have passed?
When I visit b119144 I see:
"
Some checks were not successful
10 cancelled, 1 queued, and 3 successful checks
"
and when I visit
https://github.com/web-platform-tests/wpt/runs/25140134004
I see a red circle with some green at top-left corner
The commit is preceded by a red "x" in the #42345 page
[Addendum]
I see Azure Pipelines / Azure Pipelines
started 2d 15h m and s ago
!
It does not perform or execute.
[/Addendum]
from wpt.
what we usually do is to close and reopen a PR to re-trigger all the checks
@whimboo Henrik,
Please visit #45943 and support item 2 because what you suggest is not in documentation and, in my opinion, it should.
from wpt.
@TalbotG if I scroll to the end of #42345 I see "All checks have passed". That's because the tip of the PR branch is now commit 48b9f4a, any failures previously don't block the PR.
from wpt.
if I scroll to the end of #42345 I see "All checks have passed".
I do see "All checks have passed" but that is for the last commit, which is commit 48b9f4a .
When I visit again b119144 I still see:
"
Some checks were not successful
10 cancelled, 1 queued, and 3 successful checks
"
When I visit again
https://github.com/web-platform-tests/wpt/runs/25140134004
I still see a red circle with some green at top-left corner.
any failures previously don't block the PR.
But what about commit b119144 ? It will not register. It will not modify the tests. Submiting the PR will not register, will not embed commit b119144
There are 18 commits in PR42345. Only 17 commits will modify the tests. The commit b119144 will not modify the tests because of what I quoted up here.
from wpt.
The "Re-run all checks" button does not work for a particular, specific commit. It only works for the last commit.
from wpt.
What does "This run will be cleaned up after 10 days based on your project settings." mean?
I see this in
https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=123694&view=results
from wpt.
At the bottom of the page
b119144?diff=split&w=0
I see 10 comments of failures: "Uh oh! Looks like an error! Details Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes: (...)" which must be related to my attemps to re-run the checks for commit b119144
from wpt.
taskcluster/github does not have sufficient scopes and is missing the following scopes: (...)" which must be related to my attemps to re-run the checks for commit b119144
Yes, that is correct. As I stated earlier you have to close and reopen the PR to trigger the checks again.
from wpt.
Henrik,
I closed and reopened Pull Request 42345 a few min ago. The 19 Continuous Integration checks started, ran (but I did not see which commit it was running on) and when I visit again b119144 , I still see:
"
Some checks were not successful
10 cancelled, 1 queued, and 3 successful checks
"
and still see a red circle with some green at top-left corner in
https://github.com/web-platform-tests/wpt/runs/25140134004
from wpt.
@TalbotG the PR is once again passing the checks. If you get it reviewed and still can't merge it, let me know and I can check why CI is failing.
from wpt.
Philip,
I am mostly concerned about the changes, the modifications in commit b119144 if I review and approve the PR. I want the changes and modifications (removing the margin-top as the label given to the commit states) to be registered, to be carried over (I can not find the correct verb here) when I approve and merge the #42345.
Anyway... I will try to approve and to merge the #42345 tomorrow.
from wpt.
@TalbotG if the checks are passing on the pull request and you squash all the commits when you merge, then none of the original commits will really matter. The CI failures that were on the branch also don't get in the way of merging as long as they're fixed in subsequent commits.
from wpt.
as long as they're fixed in subsequent commits
I do not know for sure if they were fixed in subsequent commits. In my opinion, they were not.
I just approve the whole #42345 a few min. ago. [fingers crossed]
I will close this Issue as soon as I know for sure that the failing commit b119144 (with 10 canceled checks) in #42345 was successfully squashed and merged (or registered or embedded) .
from wpt.
Sounds good. Thanks for letting us know!
from wpt.
Related Issues (20)
- Apple apn
- Firefox Android runs missing since July 16
- css/css-text-decor/text-decoration-underline-position-vertical-ja.html uses inconsistent font across test & reference HOT 2
- WebCrypto X25519 wrong algorithm test does not work properly
- Miiiii
- problem
- "wpt manifest" should be able to update manifest for directories of interest only HOT 4
- D
- Chrome stable and experimental runs missing as of August 5th HOT 1
- WebDriver BiDi support in testdriver needs documentation HOT 5
- Move unofficial masonry proposal tests to a different folder HOT 6
- third_party/pdf.js is old
- wpt.live links to a directory, it should link to a service to run wpt live in your browser HOT 1
- xhr/request-content-length.any.html is flaky on Safari and Chrome, not Firefox
- WebKitGTK experimental runs missing since August 13 HOT 1
- [css-view-transitions-2] navigation/hide-before-reveal.html appears to expect the inbound VT to be cancelled before pagereveal. HOT 3
- element-request-fullscreen-timing.html is non-functioning
- REGRESSION(980adbd): Edge runs failing HOT 1
- Color serialization with channel keywords and calc HOT 1
- `browsingContext.navigationStarted` for the initial navigation to `about:blank` HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wpt.