wearenewt / nonfungibletime Goto Github PK

Motivation: Avoid using contractions in names

• CantBuyYourOwnToken --> CanNotBuyYourOwnToken
• TokenDoesntExist --> TokenDoesNotExist

Implements the tabs component and display & filter NFTs accordingly.

ethers + typechain setup

Query test contract on Mumbai

If a wallet has not minted or own a single nft, we should display appropriate messages / design for it.

Current:

Actual:

Finish card design for individual NFTs

We'll need an event for the setSvgGenerator function to keep the nft uris up-to-date on the subgraph. Otherwise the new generator will only take affect if a Redeem event triggers a uri refresh.

Mint, update buying conditions, and redeem sections all need a styling overhaul

Approve the collection contract to spend user tokens through a permit signature instead of approval transaction.

Aave Reference implementation:

• Contract: https://github.com/aave/aave-v3-core/blob/dd52d07f704ae44a6382f68f0df2542268bab79b/contracts/protocol/pool/Pool.sol#L164
• Signature Generation: https://github.com/aave/aave-utilities/blob/6f0dda83c4f458932fb096b6a95608e122a50ca4/packages/contract-helpers/src/v3-pool-contract/index.ts#L370

Create UI elements

Add as parameters to graphql queries

Profile page loading screen even though there's nothing to load

Switch marketplace, profile, single NFT, and accepted currency queries to suscriptions for content updates without requiring a page refresh

When minting a new NFT, the royalty field might be confusing to people. We should add a tooltip to let people know that this a percentage of secondary sales which will be sent to the creator

Decide on what filter options to expose on V1.

• Only shows for sale
• Text search field
• Search for address

Côte d’Ivoire, Cuba, Belarus, Iran, Iraq, Liberia, North Korea, Sudan, and Syria

Optional date selector for setting the availability window

Update the mint validation logic

Should also handle one sided cases

Underline the currently selected page in the top panel with animation on hover

Bug
the popup view does not go away after successful minting and does not reload to the profile page or to the newly minted nft page (on Brave)

Expected behavior
[P0] Modal disappears after user approves transaction on Metamask
[P1] Loading animation then a 'confirmed' animation when the transaction is complete

On NFT Details page

Calls changeTokenBuyingConditions

The subgraph provides a lot of advantages to directly calling smart contracts, especially for the public marketplace, but can be unreliable at times especially on low block-time networks.

It would be a good idea to have a fallback mode which relies only on contract queries. Currently the only way to fetch details for a single NFT is calling the tokens(tokenId) function. To support an RPC mode, view functions would need to be added to fetch aggregated data:

Profile: Return array of token info for all nfts owned or created by a user.

Marketplace: Return array of token info for all tokens. Maybe this should just be disabled in RPC mode and link to Opensea + block explorer link instead? An RPC mode marketplace would be very inefficient because it would be need to be updated in intervals (not real-time) and this view function doesn't scale well with number of NFTs.

What we did at aave(before we moved to ipfs) was a little overkill i guess as you only need to check an api: https://gitlab.com/aave-tech/aave-protocol-v2/aave-api/-/merge_requests/121/diffs#cfc52d8c1aa3a8090df907edcef08d50e385637d_58_56 this was the pr for when i removed it - not sure if that's any help as it's embeded in pretty convoluted code.

Essentially how it works:

you do a call to the trm api https://gitlab.com/aave-tech/aave-protocol-v2/aave-api/-/merge_requests/121/diffs#ce4c406461c08272bb32bd2f12ac68ec5ffbef85_101_0 with an address which will return this type of response

export type TRMScreeningType = {
  address: string; // '149w62rY42aZBox8fGcmqNsXUzSStKeq8C';
  blockchain: string; // 'bitcoin';
  asset: string; // 'BTC';
  riskScore: string; // 'HIGH';
  riskIndicators: RiskIndicatorType[];
  entities: TRMEntityType[];
};

on aave-ui we only checked the "riskScore" which contains values from LOW to SEVERE. When the riskScore was SEVERE we blocked the ui.

as this api wasn't very quick we added a caching on top to only check an address every 24h or so

Currently we only display a text under the image, but would be better to have a better design for it.

Not for sale:

Already redeemed:

Symbol $BUSY

Name BusyAfCollection ?

Motivation: methods in the ERC-721 standard are named as refering to the token itself. For example, mint instead of mintToken, transfer instead of transferToken, etc. Even when some of our custom methods follow that rule, like redeem instead of redeemToken, we have some others that not.

• buyToken --> buy
• changeTokenBuyingConditions --> changeBuyingConditions
• changeTokenRoyaltyReceiver --> changeRoyaltyReceiver

For minting contract input and parsing contract data, duration is measured in seconds, not hours

Connect to https://thegraph.com/hosted-service/subgraph/wearenewt/non-fungible-time-mumbai

And create queries for fetching marketplace and profile NFTs

Add privacy policy when finished (Jim will give OK): https://ethlend.sharepoint.com/:w:/s/Projects/ESQrldNcNYVEqZmphDFqFsoBYkHswfX8dJDTknSahgfNjw?e=v8HgfJ

Add loading effects to components which fetch subgraph data

Temporarily added in most places where loading is required

Add functional modal for creating new NFT

Improve styling of this form in general:

Certain inputs will lead to a gas estimation error and not let you mint the NFT. Need to figure out what the error cases are and add error messages to the frontend.

On NftDetails page, add a query to fetch 3 most recent nfts from the creator and display cards in bottom panel

Accepted payment tokens is a setting shared by all users. This should be fetched once from the subgraph and exported from the app data provider to be used in the NftDetails page.

Display in AddressInfo

Reference use-get-ens in Aave UI

For favicon and site header

Inidividual NFT view, from Figma design

Route from Profile or Marketplace

Use TxResponse object to show submitted, confirmed, etc. when submitting transactions

A separate page for the T&C: https://ethlend.sharepoint.com/:w:/s/Projects/EVjiCBExDdRGjL5MqfTurJYBggDmcN-3-Och9zUHs7iqrw?e=5goBV6

Jim will give OK on final copy

So a user can burn a wrong/messed-up token, instead of holding it for ever

After wallet is connected, clicking on the top right icon should bring a dropdown menu with options to disconnect wallet or go to profile page ("/profile")

totalSupply to get the token quantity excluding burned ones and totalIssued to get the token quantity including the burned ones

Refresh metadata in the following events:

• TokenBuyingConditionsChanged (as it could change the rotation of the newt depending on forSale value)
• TokenRedeemed (as it should close newt eyes)

• Minter field in order to be accessible on-chain to build things on top
• Minter trait in the tokenURI in order to being able to filter by it in third party martketplaces

Create, sell, redeem, and buying condition updates

Currently only base tokens are supported as payment currencies. The contract helper is setup to generate an approval tx, the tx logic on the NftDetails just needs to be updated to trigger the approval before the buy transaction