Git Product home page Git Product logo

Comments (3)

wconrad avatar wconrad commented on July 24, 2024

Thank you for the report. That behavior is not normal at all.

The code raising the exception in server.rb is shutting down a socket:

  def close_socket(socket)
    if socket.respond_to?(:shutdown)
      socket.shutdown    # raises Errno::ENOTCONN sometimes
      socket.read
    end
  ensure
    socket.close
  end

My guess is that:

socket.shutdown
socket.read

should become:

socket.shutdown rescue nil
socket.read rescue nil

Which, in fact, is pretty much what Ruby 2.0's ftp client does.

If you'd like to try that fix yourself and let me know how that goes, that'd be helpful. In the mean time, I'm going to try to get this to happen in my environment, add a test for it, and make the fix.

from ftpd.

directionless avatar directionless commented on July 24, 2024

I had also worked around it by adding a rescue to the whole if socket.respond_to?(:shutdown) block, but this way passes the tests as well.

thanks!

from ftpd.

wconrad avatar wconrad commented on July 24, 2024

Thank you for your help, and for trying ftpd.

from ftpd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.