CPU usage pegged at 100% about ftpd HOT 9 OPEN

from ftpd.

Even w/o any connections, simply starting the server by running bin/fptdrb, here's what top shows:

PID    COMMAND      %CPU TIME     #TH   COW     #PORT MEM    PURG   CMPRS  STATE    UID  #WQ  BOOSTS                %CPU_ME
17058  ruby         94.2 02:02.52 3/1   237     24    8960K  0B     0B     running  5322 0    *0[1]                 0.00000

from ftpd.

The problem was a busy-loop in bin/ftpdrb.
I can't release a new gem right now--something in my test/release setup for ftpd has gone wrong, and I can't troubleshoot it right now.

from ftpd.

Yes, I just confirmed that too. Here:

    def run
      puts "FTP server started. (Press CRL+C to stop it)"
      connection_info.each do |key, value|
        puts "#{key}: #{value}"
      end
      $stdout.flush
      begin
        loop{}
      rescue Interrupt
        puts "\nClosing FTP server..."
      end
    end

What's your proposed fix? I think the easiest would be to simply change that loop to a call to the server thread's join method.

from ftpd.

Added a pull request.

from ftpd.

I think your fix is fine. I'll probably back out my fix and accept your PR after I get some of ftpd's housekeeping taken care of.

from ftpd.

I've released a new version of the gem which includes my fix for this issue. Leaving this issue open tor remind me to replace it with your fix.

from ftpd.

Did you ever consider my fix?

from ftpd.

@pcbeard I would love to use your fix. I haven't pulled it in because my upkeep of ftpd stopped when recent versions of Ruby broke the double-bag-ftps gem that ftpd uses for ftps support, and I don't know what the fix for that is. I suppose I could officially not support more recent Ruby versions, but that bothers me.

from ftpd.