watersedge / l1j-en Goto Github PK

Add this functionality and ensure it influences damage given/taken.
Probably should at least reduce the very high regen before doing so.

Note: The Asian L1J teams have been working on this feature and it's
probably best to just see if they can come up with a working version of it
instead of duplicating effort.

Mob able to shoot pc, but pc unable to shoot mob, due to a formula that
results in different return values when input locations are swapped. See
glanceCheck().

What steps will reproduce the problem?
1. Go to Giran Caves 4f
2. Atack the boss (who at the beggining is in assesin morph)
3. Each time h change shape game crashes (Assesin->Giant->Ancient Giant)

What version of the product are you using? On what operating system?

US Official Client in Windows XP SP 2

Please provide any additional information below:

Each time the boss changes shape the game crashes 


P.S.: This happened to me too with the mobs in Lastavard Castle, when the
change to souls, but i haven't tested it again in the last 2 weeks.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

This quest npc, id 71075, sometimes (or always?) spawns in impossible to
get to locations on Pirate Island. I've seen it hung on the edge of a cliff
once, but reachable, and on the beach once where it couldn't be reached.

Please use labels and text to provide additional information.

Currently always reports an insufficient level message.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

Using the pet menu and designate target, players can make pets attack other
players in towns.

Please use labels and text to provide additional information.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

Demon temple area mops have no drops, maybe others. 

Please use labels and text to provide additional information.

NC added a ranged skill to all 3 regular giant types to counter all the
cliff-leveling in Twilight Mountains.

Make mp consumed 0, roughly half-screen range, medium probability. Perhaps
add server code to disable when in melee range. Possibly increase drops
slightly to compensate.

Query droplists for all wand drops of quantity greater than 1 and set their
counts to 1.

NPC in ToS does not teleport you to earring NPC when you have enough karma.

Note: Earring NPCs were added pre-EpU merge and still work.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

Silence, freeze, para and maybe others don't seem to be working against
other players. I think darkwolf may have fixed this in lindc's codebase,
I'll check that soon

Please use labels and text to provide additional information.

Probably not a big deal since no one goes there, but SI/HV dungeons have
weird spawn, like skeletons and such. If spawn is corrected, check the boss
spawns and drops for all mops on the dungeon maps.

Pathfinding's determination of a path being passible on certain map
conditions is incorrect. Examples: MLC 4f, FI cliffs, a few spots in DV,
and also some building walls like gereng's house and skt shop.

Selected comments:

1. House walls seem like they should be in the current maps though, so
might be worth looking into whether mop movement is ignoring whatever cell
type they are.  

The cliffs being traversable by mops is probably not a map data bug, but
the fact that the pathfinding interprets two impassable cells in a vertical
line as being passable when the surrounding cells are.

Remove extra high pet regen so pets are killable in PvP. We do want higher
than live regen, but not quite as high as it currently is.

Also, Insure proper damage given/taken when fighting PCs/mops.

Note that this is more complicated than just changing the dmg multiplier.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

this skill is missing in the db, and learning causes the character to be
unable to log in

Please use labels and text to provide additional information.

Beholder, wicked behold, medusa should cast c-p. Basi, cocktrice should
cast stone.

Note: if a new skills table entry is required, be sure to add after id 11000.

Elemental falldown does seem to apply -50 in the caster's element, but once
the spell times out, the char's resistance doesn't return to normal (at
least until a restart).

I reviewed up to Issue 76 on the LinDC issue list and migrated them over
here. Someone still needs to review and migrate the rest. 

Be sure to migrate over any useful comments as well.

What steps will reproduce the problem?
1. teleport isnt right and the landing zones are not good and ships are 
not driving how they should do because now they dont dock on the docks but 
in the middle of the sea and then teleports you too the land.


i can fix this but need acces first

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

At different times regen just stops working for a bit, then comes back
later, sometimes accompanied by dc's but not always.  I haven't been able
to tie it in with any exceptions thrown in the logs or anything. Not sure
whats up, still looking for signs.


Please use labels and text to provide additional information.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

logs are almost useless for tracking things when there are no time stamps

Please use labels and text to provide additional information.

What steps will reproduce the problem?
1. server. 
3.

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?


Please provide any additional information below.

food should be at the beginning of a new character 17% not 9%. 

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

on some deaths due to crashes or dc's, it almost seems as if players are
losing double the xp that they should.  Hard to track and hard to confirm,
but its been reported to me several times and db backup histories tend to
support what they claim.

Please use labels and text to provide additional information.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

I'm not sure if this is just a random bug or exploit, but I witnessed
someone pk a player 3 times back to back without going chao.  After a
restart, and another kill, they went chao that time.

One person tells me there's a program that suspends packets or something
that can cause this as a cheat, but I'm not sure.  

I can't seem to repeat it on my char, but I did personally see this player
do it a few times.  

Please use labels and text to provide additional information.

What steps will reproduce the problem?
1. Hit a player
2. go pink
3. cant warp without a restart

What is the expected output? What do you see instead?
Anytime a player goes pink (and chao I guess), they can not warp until
after a restart, even if they've returned to blue. The server reports
"can't warp in current state" to the player when they try

Please use labels and text to provide additional information.

Casting life stream on a tile works, but the status message indicates "The
spell failed."

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

We talked about this once and I was wary to have any sort of automatic
kicking, but after some thought I think it would be nice as an option.  No
gm's may be around when any duping happens to catch it until after a lot of
damage is done.  I think the risk of a false positive (that could be easily
fixed once a gm is around) is worth not having the hassle of a rollback any
time a duper gets on.

I think all dupe attempts are being caught by the server, but it still
depends on someone being there to see it.  This would fix that


Please use labels and text to provide additional information.

Submitted by Lysandria

What steps will reproduce the problem?
1. Delving into the ant caves seems unchanged until floors 7-8. New 
creatures have been added in EP6/EPU
2. Quest Gatekeeper Ant could not be located with a large party scouting 
on many floors at the same time

What version of the product are you using? On what operating system?

I want to say it was Giant Ant Scout or Ant Scout, tho I'm probably wrong.
LineageDB 
mentions the name may be Gatekeeper Ant but isn't conclusive. 

Oren NPC wells un-enchanted items, gypsy town NPC has no items. 

Note: Weapon gamble should be a chance of a weapon from -5 to +5 with
emphasis on the lower end.

Need the id for the sound effect, and then add to L1SkillUse.java.

Also, the cast animation should be sent prior to the invis kicking in. On
live, you can see a split second of casting prior to the PC disappearing.

What steps will reproduce the problem?
1. see the tele lady in giran
2. choose entrance to dragon valley
3.

What is the expected output? What do you see instead?

It just does nothing, acts like you didn't click it

Please use labels and text to provide additional information.

submitted by retrib:

What steps will reproduce the problem?
1. server logs need time stamps
2.
3.

What is the expected output? What do you see instead?

The logging is decent, but logs without timestamps are pretty useless if
you're trying to track back to when a certain event happened. I'm
requesting a time stamp ability be added (as an option or by default)

Please use labels and text to provide additional information.

I'm marking this as an enhancement with a high priority. If you want
details on why I believe this is extremely important, catch me on msn.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

Silence and dk pot are working against players in towns and I assume any
safety zone.  I'm not sure, but I think its the same for freeze and para as
well, maybe others (any non dmg dealing spell probably)  

This shouldn't be the case and is being used to grief players. 

Please use labels and text to provide additional information.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

Bapho, Elindere, and someone in the caspa group cause client crashes. I
believe it's related to their casting

Please use labels and text to provide additional information.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

I believe this should be enchantable safely to 6, but 'nothing happens'
when you try to enchant it.  

Please use labels and text to provide additional information.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

Trading 150(?) medals to the npc gets you a surprise box which should open
for a random prize.  I get 'you cannot use this item' errors with it

Please use labels and text to provide additional information.

What steps will reproduce the problem?
1. enter haunted house
2. some of the tele locations will cause crashes
3.

What is the expected output? What do you see instead?

I believe the haunted house is functional other than this. Some of the tele
spots/traps/portals/whatever they are cause a client crash.

This is a required step to obtaining dolls which I get a lot of questions
about, so I'm marking as high priority.

Please use labels and text to provide additional information.

What steps will reproduce the problem?
1. server
2. bug or clitch
3. overspam of the ip connections


What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?
latest version. windows xp prof with service pack 3.

Please provide any additional information below.

go ingame and then do restart, press 1 time on cancel. 
then openup a new client login and go ingame.
then go too the other client press your character and you are 2 times 
ingame.

What steps will reproduce the problem?
1. go find dark elder
2.
3.

What is the expected output? What do you see instead?

he spams his chat message way too much

Please use labels and text to provide additional information.

Spawn isn't as unpredictable as it is on live. Some cases of this: 

1. Many spawns don't have a high enough random location setting. All
additional spawns added from in-game (e.g. the SC spawn, extra fire eggs,
etc) need to be redone into more general spawns. Most dungeon floor spawns
are OK though.

2. Spawn locations aren't re-randomized on respawn. For example, if you
create a random spawn for all across mainland Aden, they will occur, but
respawns will always happen within the same few cells until a reset occurs
and re-randomizes these locations. This kinda noobs out events where you
want random spawns - people can just bookmark a spawn location when found,
and return after a the respawn time elapses. 

3. FI is the most predictable, and as a result, the most boring, farming
spot in game (mostly due to the above issues).

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

any offensive action should cancel the spell.  This is broken for pvp and pve.

It's a pretty major flaw for pvp so marking it as critical  

Please use labels and text to provide additional information.

After talking to an NPC with a dialog depth > 1 (any dialog where you click
on a response link), the poly morph list will there after be replaced by
that dialog (usually after a teleport takes place)

A workaround for this: enter combat mode and attempt restart, which will
fail. then reuse poly scroll.

Comments carried over:

1. The problem here is that the client is never informed that the dialog
has ended. On live, if you exit a specific radius away from an NPC the
dialog auto-closes. That means the server is sending some additional server
packet to inform the client that the NPC dialog has ended. This may also
occur after the client closes the dialog. If we knew what packet/opcode
that was, we could keep track of the last NPC conversed with and auto-send
it with some distance to NPC check while handling move packets and when
teleports occur. I believe that the ItemUse packet isn't sent from the
client until the user actually selects a poly, so we can't do it there.
Pretty complicated solution, but that's probably why all PSes have this bug.

2. On second thought, we can probably get around this even easier (again,
if we knew the packet/opcode that reset the dialog status) if we sent it
after teleportation occurs.

All project documentation needs to be reviewed for current accuracy. The
FAQ is excluded from this since it was just written last week.

Some things that should be done:

1. Rewrite the Server Setup Guide to be in line with current update process.
2. Move some of the info on the main page to the FAQ.
3. Clean up or remove etc/linux_server_setup.txt. Maybe just combine this
with the Setup Guide.

Note: Please don't work on this if you're incapable of proper
grammar/spelling (since it will just make us look stupid).

The new NPC named "Suspicious Orc Merchant Parum" in Gludin gives some
client-crashing item. This item wasn't named, so is currently called
"unknown_new". Probably should disable whichever trade dialog generates
that item.

Needs confirmed.

If true, it probably just got clobbered in some merge and the stacking code
for it can be dug up from an old LinDC version.

1. Endia doesn't spawn
2. NPC item exchange after Endia step doesn't accept item.

Note: Endia NPC added in EpU merge. Need to check if she spawns now and
whether the above steps now work.

Looks like l1j finally got around to their own implementation of the fix we
did for issue 84 in the lindc codebase. The two conflict, so we should
remove our custom fix for this bug.

Current code results in a dual message for this buff.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

not sure if this was an intentional 'fix' in the jp codebase or what not,
but I don't believe we should implement it, or at least let it be a
configurable option.


Please use labels and text to provide additional information.

Kamyla teleport added in update 28, which got us another step father. But
now the dungeon it teleports you to is missing an NPC named Francisco.

Has not been investigated since EpU merge.

What steps will reproduce the problem?
1. Get a pet fox, or fox npc (or high fox)
2. Fight it or with it
3.

What is the expected output? What do you see instead?

Foxes fire spells (I believe) cause client crashes.

Please use labels and text to provide additional information.