Git Product home page Git Product logo

shoginet's People

Contributors

justremember avatar llighterr avatar theyobots avatar wandererxii avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar

Forkers

llighterr justremember lidevelopers apetresc assmod theyobots srimethan ddugovic

shoginet's Issues

Shoginet leaving behind a lot of zombie processes

I'm running Shoginet through the Docker container. After a few days, I will invariably end up with some non-trivial number of zombie YanaeuraOu processes:

$ ps aux | grep 'Z'
USER         PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
root       20469  0.0  0.0      0     0 ?        Z    Sep10   0:00 [YaneuraOu-by-gc] <defunct>
root       21216  0.0  0.0      0     0 ?        Z    Sep10   0:00 [YaneuraOu-by-gc] <defunct>
root       21252  0.0  0.0      0     0 ?        Z    Sep10   0:00 [YaneuraOu-by-gc] <defunct>
root       21256  0.0  0.0      0     0 ?        Z    Sep10   0:00 [YaneuraOu-by-gc] <defunct>
root       21258  0.0  0.0      0     0 ?        Z    Sep10   0:00 [YaneuraOu-by-gc] <defunct>
root       21260  0.0  0.0      0     0 ?        Z    Sep10   0:00 [YaneuraOu-by-gc] <defunct>
root       21262  0.0  0.0      0     0 ?        Z    Sep10   0:00 [YaneuraOu-by-gc] <defunct>
root       21268  0.0  0.0      0     0 ?        Z    Sep10   0:00 [YaneuraOu-by-gc] <defunct>
root       21275  0.0  0.0      0     0 ?        Z    Sep10   0:00 [YaneuraOu-by-gc] <defunct>
root       21293  0.0  0.0      0     0 ?        Z    Sep10   0:00 [YaneuraOu-by-gc] <defunct>
root       21315  0.0  0.0      0     0 ?        Z    Sep10   0:00 [YaneuraOu-by-gc] <defunct>
apetresc  953706  0.0  0.0   6300  2488 pts/2    S+   02:34   0:00 grep Z

This usually indicates a bug in the parent process, not catching the return code of the child processes it fork()ed.

It's not a huge deal, zombie processes don't take up any significant resources and I can always just periodically restart the container. Just kind of annoying, and probably an easy fix.

Repeated game analysis

Hello,

I've noticed that shoginet frequently analyses the same game twice in a row.
Here is an example log:

Python:           3.8.5 (with requests 2.22.0)
EngineDir:        /home/foo/shoginet
StockfishCommand: ./YaneuraOu-by-gcc
Key:              (none)
Cores:            1
Engine processes: 1 (each ~1 threads)
Memory:           256 MB
Endpoint:         https://lishogi.org/fishnet/
FixedBackoff:     False

### Starting workers ...

><> 1: Started YaneuraOu NNUE 6.00 64AVX2, threads: + (1), pid: 89745
><> 1: Analysing: https://lishogi.org/hgSuDfBa#104
[fishnet v1.0.0] Analyzed 23 positions, crunched 19 million nodes
><> 1: Analysing: https://lishogi.org/hgSuDfBa#89 
[fishnet v1.0.0] Analyzed 38 positions, crunched 37 million nodes
><> 1: Analysing: https://lishogi.org/hgSuDfBa#74
[fishnet v1.0.0] Analyzed 53 positions, crunched 57 million nodes
><> 1: Analysing: https://lishogi.org/hgSuDfBa#59
[fishnet v1.0.0] Analyzed 68 positions, crunched 77 million nodes
><> 1: Analysing: https://lishogi.org/hgSuDfBa#44
[fishnet v1.0.0] Analyzed 83 positions, crunched 95 million nodes
><> 1: Analysing: https://lishogi.org/hgSuDfBa#29
[fishnet v1.0.0] Analyzed 98 positions, crunched 116 million nodes
><> 1: Analysing: https://lishogi.org/hgSuDfBa#14
[fishnet v1.0.0] Analyzed 113 positions, crunched 137 million nodes
><> 1: Analysing: https://lishogi.org/hgSuDfBa#0 
><> 1: https://lishogi.org/hgSuDfBa took 473.5s (3.70s per position)
><> 1: Analysing: https://lishogi.org/hgSuDfBa#125                                               
[fishnet v1.0.0] Analyzed 132 positions, crunched 160 million nodes
><> 1: Analysing: https://lishogi.org/hgSuDfBa#102
[fishnet v1.0.0] Analyzed 155 positions, crunched 182 million nodes
><> 1: Analysing: https://lishogi.org/hgSuDfBa#87 
[fishnet v1.0.0] Analyzed 170 positions, crunched 207 million nodes
><> 1: Analysing: https://lishogi.org/hgSuDfBa#72
[fishnet v1.0.0] Analyzed 185 positions, crunched 231 million nodes
><> 1: Analysing: https://lishogi.org/hgSuDfBa#57
[fishnet v1.0.0] Analyzed 200 positions, crunched 254 million nodes
><> 1: Analysing: https://lishogi.org/hgSuDfBa#42
[fishnet v1.0.0] Analyzed 215 positions, crunched 280 million nodes
><> 1: Analysing: https://lishogi.org/hgSuDfBa#27
[fishnet v1.0.0] Analyzed 230 positions, crunched 307 million nodes
><> 1: Analysing: https://lishogi.org/hgSuDfBa#12
[fishnet v1.0.0] Analyzed 245 positions, crunched 334 million nodes
><> 1: Analysing: https://lishogi.org/hgSuDfBa#0 
><> 1: https://lishogi.org/hgSuDfBa took 473.4s (3.70s per position)
><> 1: Analysing: https://lishogi.org/QCfGyeIO#61
[fishnet v1.0.0] Analyzed 261 positions, crunched 361 million nodes
><> 1: Analysing: https://lishogi.org/QCfGyeIO#46
[fishnet v1.0.0] Analyzed 276 positions, crunched 386 million nodes
><> 1: Analysing: https://lishogi.org/QCfGyeIO#31
[fishnet v1.0.0] Analyzed 291 positions, crunched 415 million nodes
><> 1: Analysing: https://lishogi.org/QCfGyeIO#16
[fishnet v1.0.0] Analyzed 306 positions, crunched 446 million nodes
><> 1: Analysing: https://lishogi.org/QCfGyeIO#1 
[fishnet v1.0.0] Analyzed 321 positions, crunched 479 million nodes
><> 1: Analysing: https://lishogi.org/QCfGyeIO#0
><> 1: https://lishogi.org/QCfGyeIO took 252.4s (3.88s per position)
><> 1: Analysing: https://lishogi.org/QCfGyeIO#49
[fishnet v1.0.0] Analyzed 338 positions, crunched 505 million nodes
><> 1: Analysing: https://lishogi.org/QCfGyeIO#34
[fishnet v1.0.0] Analyzed 353 positions, crunched 535 million nodes

Build issues on macOS

Hi!
I'm so excited to see the new shoginet feature, and how fast lishogi evolves.😊

Now about the build. I was following the how to setup instructions,
and found out the build script is not supporting Mac well.

It requires a few changes to be fully compatible:

  1. this check should be updated with Mac-specific logic
  2. It requires gcc by default. It took me some time to understand why the build is failing. Maybe it makes sense to point that in README.
  3. On this line it expects a bit different naming convention for Mac. Probably I messed up the fishnet.ini config file. Forcing the YaneuraOu-by-gcc helped here as a quick fix.

But after that, it worked like a charm.👌

To summarize, all the issues are not hard to fix.
I think I could even create PR with the changes, just wanted to discuss it beforehand.👍🏻

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.