walidcherhane / rc-toastr Goto Github PK

Just noticed that the background colors set to transparent for no reason and that causes issues with any other buttons

Thanks for this great library.
There is a bug you should be aware of. when I use the loading() method if the given promise has been rejected it throws an error that should not be thrown because of using try..catch.
The error() callback must be called without any error.
I believe that you should remove the throw err on the last line to fix the bug.
Regards, Javad Moradkhah.

npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^18.2.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.0.0" from [email protected]
npm ERR! node_modules/rc-toastr
npm ERR!   rc-toastr@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps

The package is nice and clean with minimal configuration! It's better if we have the dependencies updated.