walfie / gbf-raidfinder Goto Github PK

On initial launch, if the user is following multiple bosses, some columns may be missing initial backfill tweets.

Hi Walfie,

I've set up an instance of gbf-raidfinder on my own server and so far it appears to run splendidly - thank you very much. I am just wondering is there any licensing and attribution issues I need to be aware of?

Case in point, the docker image as well as the sbt package generated from the main repository contains a google analytics ID which I assume belongs to you. Am I allowed to strip this out or replace it with my own?

Thanks again
Laforet

Occasionally all the <li> elements in a column are re-rendered, which isn't a huge deal performance-wise since columns usually only have 50 items at max. However, this causes tweets to reset their "copied" state (where they're greyed out after clicking on them).

Dear Developers,

I tried to setup my own raid finder on Heroku. Based on the "one-button" setup, it line up smoothly.

However, I cannot see any bosses on list to select. Could you tell how to fix this problem?

Should I manually add name of bosses?

twitter formatting changed as of about an hour ago (41 min ago?) (in this software, none of the tweets are showing up. I suppose because of stricter matching...)

参加者募集！参戦ID: id raid

->

id :参戦ID 参加者募集！raid

100 tweets are fetched each tick. If more than 100 new tweets are made per tick, the stream might never catch up. Not sure how likely this is, but seems low priority.

When the user first opens the site, they get bombarded with notifications for old tweets.

Backfill tweets should not trigger notifications on initial load.

it never change from this

Need to figure out how to use the polyfill correctly

Currently only Japanese tweets are supported. The English raid tweets streams could probably even use the actual streaming API, since the words are space-separated.

If the server is deployed with a new version, the client should know to refresh to get the latest version.

This can be done if I actually bother to use versions:

• On websocket connect, server sends its current version
• Client compares to its own version
• If server version is higher, display a message to the user

This assumes client and server are deployed together (currently they are)

Every once in a while, the full boss list doesn't get loaded when the page first loads.

Slightly annoying but can be resolved with the "reload bosses" button, so not high priority.

Hello walfie,
recently days I'm working on writing a RaidFinder with Node.js and I found a problem:
How to track Twitter Stream use keyword: "参加者募集！".
Because in Twitter official guide#track, it says "Non-space separated languages, such as CJK are currently unsupported. " And when I use the API, it works absolutely likes what the docs said.
But when I'm reading this project's source code, I found you just set ""参加者募集！" OR "I need backup!"" as the default default search terms.(in TwitterSearcher.scala)
Could you tell me some ideas about this problem?
Thanks a lot.

Unless i'm at the page and click a notification, it never copies the code. For example, if i'm browsing tweetdeck or any other site except raidfinder, clicking on notification does nothing.

However if i'm at the raidfinder site and click on the notification for raids, it works and copies the code.

As mentioned, it's an issue with Firefox. I tested with chrome and it was fine with it. I hope you can look into it.

Some people like having notification sounds

Idk if it's just me having this problem but it worked the first time i clicked the desktop notification to copy the raid ID, but it hasn't worked since (i.e. it only worked once, doesn't copy raid ID ever again on subsequent notifications)

I am using Firefox on Windows 7

My problem is that I could normally open the site but it shows infinite loading screens (currently happened only on my home internet and mobile LTE.: http://i.imgur.com/OhQTaJu.png)

A few weeks ago I was unable to access the website from my home internet (It was working fine on my dorm internet.) so switched to the mobile data and it worked. Today I can't access the website using my mobile data, so I connected to a VPN and it became working again.
Is it an IP ban and I tripped some flags?

If you use the twitter refresh in-game and add the text
参加者募集！参戦ID：[RAID CODE] [RAID NAME]
eg
参加者募集！参戦ID：114514810
Lv100 ケルベロス
(found at https://twitter.com/megakureiXrdR/status/807071380277579776/photo/1)
it shows up in the raid listing even if the tweet is removed (image: http://i.imgur.com/3iAFJLu.png, I was testing to see how the cerberus one showed up and added a fenrir one by accident. Deleted the tweet but the listing still remains 2 days later.)

Hi,
Thanks for making wonderful tool.

Although, I have some problem using this tool in pc.
After click "+" Button at bottom right cornor, I saw empty list of bosses list.
Chrome's Developer Tool shows as below

WebSocketClient.scala:37 
WebSocket connection to 'ws://gbf-raidfinder.aikats.us/ws/raids?keepAlive=true' failed: Error during WebSocket handshake: net::ERR_CONNECTION_RESET

Ls @ WebSocketClient.scala:37
Ks @ WebSocketClient.scala:83
Hk @ RaidFinderClient.scala:44
Ck @ Application.scala:22
Bk.init @ Application.scala:16
(anonymous function) @ (index):54

WebSocketClient.scala:37 
WebSocket connection to 'ws://gbf-raidfinder.aikats.us/ws/raids?keepAlive=true' failed: Error during WebSocket handshake: net::ERR_CONNECTION_RESET
Ls @ WebSocketClient.scala:37
(anonymous function) @ WebSocketClient.scala:71
bx.Ra @ AnonFunctions.scala:10
(anonymous function) @ package.scala:33

BTW, using in mobile phone have no problems though.
If you think that's this issue is not related with your tool, please feel free to close or delete it.
It might cause from my ISP.
Thank you.

Values like "Lv100 ユグドラシル・マグナ" are showing up, but only on Heroku (not locally). Most likely an encoding problem, where the default isn't set.

Whenever a websocket client disconnects, "Child terminated, stopping" appears in the server logs. It doesn't seem to really affect anything, but should maybe investigate.

Seems to happen for all English raids. I personally tested this and the tweets without their Japanese names as a message didn't show up.

Maybe a checkbox on each column

On iOS Safari (10.3, since 10.0)

• Tapping a Tweet does not copy raid code to clipboard
• Tapping a Tweet zooms to the pseudo input element

First, thank you for this awesome service and opensource it!

I read the docs/implementation.md and it is said that

Note that we can't use 参加者募集！ -- which is in all Japanese raid tweets ......

But according to current source code, it looks like we can use 参加者募集！ directly, doesn't it?
(by #122)

It's kind of confusing.

Currently the boss list is refreshed every time the menu is opened, which is wasteful (could be a few kB each time). Should figure out a better refresh mechanism.

Currently, bosses are removed periodically if they aren't seen in a while (currently 6 hours). Some high-level bosses are rarely seen, so it could be a long time before they're seen again.

Suggestion is to never purge bosses that are lv100+

Thanks for all the hard work : ) all the raids seem to be available except for Kirin (黒麒麟). Will this be added in the future?

When raidfinder is opened on iOS Safari browser, all settings and subscriptions are reverted back to default when the page refresh or reopened. Seem to be new issue.

The current logic is to keep lv100 bosses around forever, but there have been a lot of lv100 event bosses lately. Ideally they wouldn't be kept around forever, but maybe just have a higher TTL for them (a month?)

Hi Walfie, any chance Viramate web API will be implemented? You can find it on Viramate > Options > Web API.

Someone did a grease monkey addon for it,
https://greasyfork.org/pt-BR/scripts/30760-gbf-raidfinder-viramate-web-api-integration/code

Thanks!

Dear Developers,
I have read the code, but is any of this can implent to VPS?
Like digital ocean; https://www.digitalocean.com/

Also is there any tips for host in VPS?

Need suggestion here

*Awesome it is 👍 for using Scala language;
I'm thinking if any language there, I can use for

Tweetdeck has multiple column width options:

• wide - 350px
• medium - 310px
• narrow - 270px

Currently gbf-raidfinder is using 350px width.

Currently the page just uses a blank favicon. Would be nice to have an actual favicon.

Currently if an exception occurs, the code just retries the request on the next tick. Maybe this should be adjusted to account for rate limit errors.

Not high priority since the default is about half the maximum limit.

When highlighting text inside a raid tweet, the text gets unhighlighted immediately (when moving focus to the textarea to copy the raid ID).

Would be nice to say that a Japanese boss and an English boss are actually the same, and return them in the same column.

Ideally this could be done without hardcoding boss name mappings (so event bosses can be handled automatically) but I'll do the hardcoding if I can't think of another way.

If a boss isn't seen in 12 hours, it's removed from the boss list. This helps remove event bosses from the list after events are over. Some low level bosses also get tweeted so infrequently that they get removed. The bug is that they don't come back if someone tweets the English version of the boss, only the Japanese one.

This doesn't matter too much since the bosses that people care about are fine, but might be nice to address.

The English images are shifted slightly to the left, which messes up the image comparison (which uses strict equality for hashes at the moment).

Weird that the new images suddenly have this, whereas the past two sets of guild wars bosses (and all standard bosses) worked perfectly.

JP	EN
Lv30 アーフラー	Lvl 30 Ahura
Lv40 アーフラー	Lvl 40 Ahura
Lv50 ベオウルフ	Lvl 50 Grendel
Lv60 ベオウルフ	Lvl 60 Grendel

when using http://gbf-raidfinder.aikats.us/

you will see this pop up in the js console:

HtmlHelpers.scala:40 [Deprecation] Using the Notification API on insecure origins is deprecated and will be removed in M61, around September 2017. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.

so likely in this month, the Notifications while using this website will likely be broken in Chrome at some point.

If the server is restarted, all known bosses are cleared. It would be nice to maintain the boss list, to be reused when the server comes back online.

Currently there's no real way to check how many people are using the site.

Expose a GET endpoint that will return the list of known bosses, so it can be queried without needing a websocket connection.

Would be nice to have a README or something

Allow users to input their own custom search terms. The client code already allows this, but there's no way to do it via the UI.

Dark backgrounds are nice sometimes.

Material Design Lite doesn't have a dark style, so it's more effort than just dropping in a different CSS file.

Show desktop notifications when certain raid bosses (as selected by the user) are tweeted about.