waelalnadeem / hyf-javascript-2 Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 1.0 14 KB

HTML 5.98% CSS 5.55% JavaScript 88.47%

hyf-javascript-2's People

Contributors

Watchers

Forkers

ghenowa

hyf-javascript-2's Issues

Indicating the attribute of object with loop, here not recommended

Instead of looping through all keys and doing checks per key (Line 38, 43)

hyf-javascript-2/Week 1/Homework4.js

Lines 36 to 51 in 3a3ad0e

 for (data in book) { 

 if (data !== "title"){ 

 var list = document.createElement("li") 

 list.classList.add("list") 

 } else { 

 var list = document.createElement("h2") 

 list.classList.add("head") 

 } 

 list.textContent = book[data] 

 booksDetails.appendChild(list) 

 }

You could use the attributes of the object directly, It is more consistent and faster, specially you are placing HTML elements per key, usually we are not sure of the order of the keys in an object.

Using getElementById is recommended

In lines

hyf-javascript-2/Week 1/Homework4.js

Lines 31 to 33 in 3a3ad0e

 var body = document.getElementById("main") 

 let booksDetails = document.createElement("ul") 

 main.appendChild(booksDetails)

Variable body is declared but not used.
Then you used main you maybe meant to use body.
Luckily the variable name main matches the id of the element, so it works, but it is not recomended to use it, see https://www.w3.org/TR/html5/browsers.html#named-access-on-the-window-object

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.

Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

TensorFlow

An Open Source Machine Learning Framework for Everyone

Django

The Web framework for perfectionists with deadlines.

Laravel

A PHP framework for web artisans

D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

web

Some thing interesting about web. New door for the world.

server

A server is a program made to process requests and deliver data to clients.

Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

Visualization

Some thing interesting about visualization, use data art

Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.

Microsoft

Open source projects and samples from Microsoft.

Google

Google ❤️ Open Source for everyone.

Alibaba

Alibaba Open Source for everyone

D3

Data-Driven Documents codes.

Tencent

China tencent open source team.

	for (data in book) {

	if (data !== "title"){
	var list = document.createElement("li")
	list.classList.add("list")


	} else {
	var list = document.createElement("h2")
	list.classList.add("head")

	}
	list.textContent = book[data]
	booksDetails.appendChild(list)

	}

	var body = document.getElementById("main")
	let booksDetails = document.createElement("ul")
	main.appendChild(booksDetails)