Git Product home page Git Product logo

Comments (8)

vr000m avatar vr000m commented on July 23, 2024

Perhaps adding *Info instead of *Stats seems more appropriate as these dictionaries do not contain any metrics or statistics.

  • RTCCodecInfo
  • RTCIceCandidateAttributeInfo

OTOH, RTCCertificateStats could be RTCCertificateInfo for the same reason. I do not feel strongly about it.

from webrtc-stats.

jan-ivar avatar jan-ivar commented on July 23, 2024

@vr000m I follow your reasoning, however, anything returned from getStats is stats IMHO, not attributes, info or attribute-info. Dictionaries may grow over time and add more data, so I for one would rather see our types here reflect inheritance (RTCStats).

from webrtc-stats.

alvestrand avatar alvestrand commented on July 23, 2024

My personal leaning would be towards "info" - if one wants to know the inheritance hierarchy, one should walk the prototype chain, not try to parse names.
Names need to be 1) unique and 2) memorable. But I can't bring myself to feel strongly about this.

from webrtc-stats.

jan-ivar avatar jan-ivar commented on July 23, 2024

@alvestrand dictionaries don't have prototypes. Since there's very little enforcement of this inheritance in JS, I would recommend name consistency here. See also w3c/webrtc-pc#275

from webrtc-stats.

alvestrand avatar alvestrand commented on July 23, 2024

If we want to make this a principle, the document needs to state that it is.
I think we should accept the principle.

from webrtc-stats.

alvestrand avatar alvestrand commented on July 23, 2024

Principle seems to be that *Attribute and *Info should go, and *Stats should be added.

from webrtc-stats.

alvestrand avatar alvestrand commented on July 23, 2024

RTCIceCandidateAttributes -> RTCIceCandidateStats is done in #36

from webrtc-stats.

vr000m avatar vr000m commented on July 23, 2024

Closing this issue, since both inconsistencies are now resolved.

from webrtc-stats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.