w3c / ash-nazg Goto Github PK

Not sure if this is related to the repo manager per se, or just how it's been hooked up specifically to this repo, but: doing a PR on w3c/Mobile-A11y-Extension#9 resulted in an IPR failure (as I was, at the time, not part of the correct contributors list); trying to now trigger a revalidation on https://labs.w3.org/hatchery/repo-manager/pr/id/w3c/Mobile-A11y-Extension/9 i just get a "Cannot convert undefined or null to object" error and nothing further happens...

I'm trying to import the feature-policy repo into the WICG, and the repo-manager (silently) fails to do so.
Looking at the console, I see app.js:3 Uncaught TypeError: o.default.findDOMNode is not a function

@dontcallmedom - can you please take a look? Thanks in advance! :)

If I force-push to a PR's branch, the bot doesn't set any status for the new commit.
Perhaps the bot isn't listening for all the relevant GitHub events?

There is markdown in those files...

Can we please give "ash-nazg" a more obvious name? I can't ever remember what this thing is called and I tend to waste disproportionate amounts of time trying to find it.

Hi!

When I spot an issue, I'd like to be able to get to the GitHub repo quickly to raise a new issue or do a pull request. There is no link from ash-nazg to the repo. I suggest a footer that says "Questions or comments? Please let us know on the GitHub Repo for ash-nazg."

Ian

eg, using mocha for the server side.

Getting a 500 error importing a repo:

TypeError: Cannot read property &#39;name&#39; of undefined<br> &nbsp; &nbsp;at andify (/u/lab/ash-nazg/gh.js:69:82)<br> &nbsp; &nbsp;at Object.GH.createOrImportRepo (/u/lab/ash-nazg/gh.js:112:33)<br> &nbsp; &nbsp;at Object.GH.importRepo (/u/lab/ash-nazg/gh.js:90:14)<br> &nbsp; &nbsp;at /u/lab/ash-nazg/server.js:217:31<br> &nbsp; &nbsp;at /u/lab/ash-nazg/node_modules/async/dist/async.js:486:20<br> &nbsp; &nbsp;at /u/lab/ash-nazg/node_modules/async/dist/async.js:1074:13<br> &nbsp; &nbsp;at /u/lab/ash-nazg/node_modules/async/dist/async.js:952:25<br> &nbsp; &nbsp;at eachOfArrayLike (/u/lab/ash-nazg/node_modules/async/dist/async.js:990:13)<br> &nbsp; &nbsp;at eachOf (/u/lab/ash-nazg/node_modules/async/dist/async.js:1052:9)<br> &nbsp; &nbsp;at _asyncMap (/u/lab/ash-nazg/node_modules/async/dist/async.js:1067:9)

Repo I was trying to import:
https://github.com/WICG/memory-pressure/

Due to the bug #4 , I ended up importing repos from my own account (forks of the right repos) in ash-nazg, which I would prefer to remove from the list of managed repositories; I haven't found a way to do that in the current UI.

The system answers:
[[
User foobar is known to the system. You can edit that account.
]]

when the user pull request is classified as "unknown".

That's because the association with the W3C account is missing.

We should improve the message...

https://labs.w3.org/hatchery/repo-manager/pr/id/w3c/webauthn/451 isn't allowing me to proceed to mark non-substantive, because it's showing the error "Cannot read property 'groupType' of undefined." and is stuck loading.

When accessing:
https://labs.w3.org/hatchery/repo-manager/pr/id/w3c/browser-payment-api/525

I am getting:
"undefined is not an object (evaluating 'e.pr.groupDetails[0].groupType')"

In both Chrome and Safari:

Problem: If I web search for site:w3.org ash-nazg, I am able to find the https://labs.w3.org/hatchery/repo-manager/ home page, however, it has a bit of a random unofficial "labs.w3" look and feel, with no context for how or why you're supposed to use it.

Presumably this is documented somewhere already (or should be).

Could the https://labs.w3.org/hatchery/repo-manager/ home page explicitly link to how and why you're supposed to use it?

Thanks!

Some repos move from one WG to another; the admin interface should allow that operation.

I keep getting
"JSON.parse: unexpected character at line 1 column 1 of the JSON data"
when adding webperf repos...

When trying to load https://labs.w3.org/hatchery/ash-nazg/pr/last-week, I get an error message stating "can't convert undefined to an object".

The console has the following stack trace:
13:49:42,359 TypeError: can't convert undefined to object
Trace de la pile :
[14]</v</<.value/t<@https://labs.w3.org/hatchery/ash-nazg/js/app.js:2:8333
[14]</v</<.value@https://labs.w3.org/hatchery/ash-nazg/js/app.js:2:7803
[103]</</w._renderValidatedComponentWithoutOwnerOrContext@https://labs.w3.org/hatchery/ash-nazg/js/app.js:7:2158
[103]</</w._renderValidatedComponent@https://labs.w3.org/hatchery/ash-nazg/js/app.js:7:2411
[141]</</r.measure/i@https://labs.w3.org/hatchery/ash-nazg/js/app.js:9:3382
[103]</</w._updateRenderedComponent@https://labs.w3.org/hatchery/ash-nazg/js/app.js:7:1632
[103]</</w._performComponentUpdate@https://labs.w3.org/hatchery/ash-nazg/js/app.js:7:1379
[103]</</w.updateComponent@https://labs.w3.org/hatchery/ash-nazg/js/app.js:7:700
[141]</</r.measure/i@https://labs.w3.org/hatchery/ash-nazg/js/app.js:9:3382
[103]</</w.performUpdateIfNecessary@https://labs.w3.org/hatchery/ash-nazg/js/app.js:6:31655
[147]</</i.performUpdateIfNecessary@https://labs.w3.org/hatchery/ash-nazg/js/app.js:9:9879
s@https://labs.w3.org/hatchery/ash-nazg/js/app.js:9:16820
[169]</</o.perform@https://labs.w3.org/hatchery/ash-nazg/js/app.js:10:2860
[169]</</o.perform@https://labs.w3.org/hatchery/ash-nazg/js/app.js:10:2860
[153]</</<.perform@https://labs.w3.org/hatchery/ash-nazg/js/app.js:9:18332
[153]</</R@https://labs.w3.org/hatchery/ash-nazg/js/app.js:9:18515
[141]</</r.measure/i@https://labs.w3.org/hatchery/ash-nazg/js/app.js:9:3382
[169]</</o.closeAll@https://labs.w3.org/hatchery/ash-nazg/js/app.js:10:3608
[169]</</o.perform@https://labs.w3.org/hatchery/ash-nazg/js/app.js:10:2940
[119]</p.batchedUpdates@https://labs.w3.org/hatchery/ash-nazg/js/app.js:7:27005
u@https://labs.w3.org/hatchery/ash-nazg/js/app.js:9:17278
r@https://labs.w3.org/hatchery/ash-nazg/js/app.js:9:12885
[152]</</f.enqueueSetState@https://labs.w3.org/hatchery/ash-nazg/js/app.js:9:14686
[100]</</r.prototype.setState@https://labs.w3.org/hatchery/ash-nazg/js/app.js:6:22733
[14]</v</<.value/<@https://labs.w3.org/hatchery/ash-nazg/js/app.js:2:6433
1 app.js:1:596
[1]</t.exports.error() app.js:1
[19]</t.exports.catchHandler() app.js:2

Now that the affiliation and participations of an account are checked live (per #56), it is no longer necessary or useful to associate a github account with a group; instead, edit user should offer to link the account to a w3c one either via the login, the id or some other sort of magic (email address? link to github account?)

Right now, the W3C API probably doesn't allow this though.

Would've been nice if there was a way to setup a default CG and/or org when importing a repo, as to minimize the number of clicks during the import process.

Currently, when importing a repo, one has to remember the repo name and exact spelling. While there are worse things in the world, it'd be nice if the UI autocompleted that piece of info.

Not all GH users share their email address in the GH public API, but getRepoContacts only look there to send emails in case of notification needs.

It could also look in:

• our local db if the user is known (which is likely)
• in the W3C API (once we have a way to retrieve w3c users from GH accounts)

see #65

WICG/resize-observer#27 was accidentally marked as non-substantive, and there's no obvious way to revert it back to substantive status. Is it possible to manually revert it somehow?

A user is correctly associated with Member and W3C group, but the IPR check fails with this message:
"Error: Could not retrieve email addresses from repos contacts"

Hi all,

Please add functionality to let me delete users. I want to delete, for example:
https://labs.w3.org/hatchery/ash-nazg/admin/user/gestrade

(Due to my error)

Thank you,

Ian

On the Add User page [1], please make it clearer that you are looking for a GitHub identity, not a W3C identity. I suggest these changes:

Old: Pick user name to add
New: Provide a GitHub user name to add the user

Old: user name
New: GitHub user name

Ian

[1] https://labs.w3.org/hatchery/ash-nazg/admin/add-user

For example, Googlers aren't allowed to give away write access, which this tool currently wants in order to auto-create repositories.

https://labs.w3.org/hatchery/repo-manager/pr/id/w3c/FileAPI/42

The repo-manager refuses to allow this pull request to be marked as non-substantive.

Suggested by @deniak; cf “Create a GitHub File Explorer Using Vue.js”.

(I'm not sure yet about the real value of such a feature; unless we augment GitHub's interface with more features related to ash-nazg's goals, a link to the repo would do instead?)

https://labs.w3.org/hatchery/repo-manager/pr/id/w3c/webpayments-core-messages/5

doesn't do anything when one tries to mark this PR as non-substantive. Note that the PR author doesn't appear as contributor in ash-nazg.

When importing a repo, the current contact in the w3c.json is the person that imported the repo (I think - it's always my user name. Could also be hardcoded :D)

It'd be great to have some UI that enables determining the contact at import time.

In WGs, organizations make commitments that encompasses any essential claims that applies in the said specification.

We should be able to note a user's organizational affiliation without going through group membership

The repo manager is failing to import a new repo for me, and seems like the guilty resource is https://labs.w3.org/hatchery/repo-manager/api/orgs which is returning a 500.

Can anyone take a look?

A given user can have different affiliations per group. The W3C systems already support the case where one is an invited expert in one WG, but represents their company in a CG (see #28).

Ideally, at some points, the W3C systems will also support an even more flexible approach where a user can have a different affiliation for any kind of group. If at all possible, ash-nazg should be built along that principle.

Attempting to revalidate https://labs.w3.org/hatchery/repo-manager/pr/id/w3c/browser-payment-api/450 gives an empty error

When someone's affiliation changes, or when their participation to a group changes, the PR validation needs to take it into account.

This could be done in two ways:

• either, always check at PR validation time the current status of a given contributor (right now, it is only done when the contributor is added to the system)
• or rely on a hook from the W3C API to update the database-cached information on a contributor

If I understand correctly, ideas for enhancements, bugs, the roadmap — those are kept in the file TODO.txt and in DEVELOPMENT.md, section “suggested improvements”.

I suggest we file one issue here for every idea/bug, and get rid of that copy. It will make it easier to have a clear picture of what's ahead, triage bugs, split the work among the team, and get stats on progress.

I'm happy to do that myself if you like the idea, @darobin.

Some PRs are only typos and don't need to stay flagged as problematic. It would be nice to have the ability to tell ash-nazg that a PR can be safely ignored

The system emits an inscrutable error message when trying to associate a github profile with a w3c user account whose only affiliation is of invited expert.

The problem is that it assumes that Invited Expert is not a relevant affiliation, which is correct for CGs but incorrect for WGs.

The bigger problem is that it assumes one affiliation per user (but that'll be in a separate issue).

Instead of taking the principal email associated with a team user's github account for the account listed in w3c.json, the system should allow team to specify a different email address.

1. Be an active W3C member and contributor
2. Submit a pull request, e.g. w3c/mediacapture-image#173
3. Have 'ipr' trigger a failure with a details link requiring a login / and authorizing many permissions.

Expect:

• Actionable summary of how to correctly register contributor status. And, ability to do so.

Actual:

• Details are not provided, just a log in page with text that indicates significant permissions are required without justifying them.

This site is essentially an application built on top of GitHub. As such, in order for it to work, you need to log into it using your GitHub credentials.

Given that the actions we need to carry out are fairly extensive, the level of permissions we require is relatively high. Worry not, we promise to almost never use it for anything evil.

Go ahead and log in using GitHub.

• Permissions requested by this app are overly broad, including read and write all public repository data.

Suggestion:

• Explain in the details page what the IPR validation is.
• Explain steps to correctly register.
• Do not require overly broad account permissions to do so.

I was trying to import several WebRTC/DAP repos in a row using https://labs.w3.org/hatchery/ash-nazg/repo/import and hit the following bugs:

• after having imported the first repo, the account selector (which was set on "w3c") reverted to my own account ("dontcallmedom"), and didn't let me set it back to "w3c"
• if you hit "import" without having selected a group, it reports an inscrutable JSON error; I guess the group selector should be marked "required"

It would also be nice if the input field for repos had an autocomplete on the known repos for the said account.

w3c/vc-data-model can't be imported because VC WG isn't listed in https://labs.w3.org/hatchery/repo-manager/repo/import

• @liamquin

reported by @plehegar

When importing the repository "scroll-animations" from WICG, I get the following error from the ash-nazg interface:

JSON Parse error: Unexpected identifier "TypeError"

The repo is here:
https://github.com/WICG/scroll-animations

Hi,

in some groups there are a large number of repos, and a small number of people dealing with them.

It would be really helpful if I could set a repo to automatically notify me when an IPR check is failed so I go look at the problem…

React shows this error on the client's console:

Warning: render(): Rendering components directly into document.body is discouraged,
since its children are often manipulated by third-party scripts and browser extensions.
This may lead to subtle reconciliation issues.
Try rendering into a container element created for your app.

Fix that.

It would be great to see the open pull requests only on groups where the viewer is chair or team contact; or to filter them by group.