w1nt3r-eth / hot-chain-svg Goto Github PK

When the contract reverts, we render undefined :/

Wonder if any work has been done on a script to generate the solidity version with all the concatenations by just providing regular svg code?

solc is easy to install but slow.

Sometimes it's useful to log some stuff from the contract. I see 2 ways we could support that:

1. Add VM hooks that call a native function (similar to the way Hardhat does it, could even reuse their console.log)
2. Emit a Solidity event and parse it from the transaction receipt

This function compares two strings by taking the keccak256 of their abi.encodePacked()ings.

We know the input type of keccak256 is bytes and string is easily converted to bytes by simple casting.

So this comparison can be made where each parameter is digested by keccak256(bytes(PARAM)).

This gives an equivalent correct check and saves gas drastically, as abi.encodePacked is really a superfluous operation here.

Granted, this function may be for validation during "callstatic" svg renderings, but even in that context gas savings may be ideal especially if the rendering of the artwork hits close to the available gas allowance of the queried provider.

Not very familiar with the ethereum/vm, so I haven't been able to figure this out yet...

Is it possible to use a random address for each of the 250 text tokens?