vuestorefront / redis-driver Goto Github PK
View Code? Open in Web Editor NEWMOVED to https://github.com/vuestorefront/vue-storefront/tree/legacy/packages/redis-driver
License: MIT License
MOVED to https://github.com/vuestorefront/vue-storefront/tree/legacy/packages/redis-driver
License: MIT License
Actually we are caching all the params url. But it's not good
Imagine a common use case with redirection from partners annonce with an ID in the used by Google Tag Manager for example ( Client side usage ).
We are duplicating all of theses urls in the redis storage.
One solution would be to add an allowParamsUrl
in the config.
{
allowParamsUrl: ['q', 'prices', 'colors', .... ]
}
With that even with a random param in the url we will render the same cached page.
No response
We should not cache any error pages ( 404, 500... )
Actually even if the rendering contains an error, the page are put in cache.
const content = await render();
const tags = getTags();
if (!tags.length) {
return content;
}
------> We should check if there is an error in `content`<-----
// We could add "await" here, but saving content in cache doesn't have to block the request
client.set(
key,
content,
tags
);
Add a check for content.error
variable and do not cache the response.
Hit a 404 page.
2.4.3
16
Chrome
macOS
No response
In the header of storefront ui theme there is user icon which has autenticated/not authenticated states.
If the page was cached when user was not authenticated you will always see not authenticated state on first load or vice versa
Cached pages should ignore user state and show current state of user state and not cached one.
No response
Custom integration
16.13.1
Edge
macOS
No response
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.