Git Product home page Git Product logo

configs's Introduction

configs's People

Contributors

dependabot[bot] avatar meteorlxy avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

configs's Issues

Closing the useless promise-function-async

@typescript-eslint/promise-function-async is useless with the following rules after type checking, and it's improving bundle size.

  • no-floating-promises: This ensures any floating promise being specially marked, so that developers can not make async actions in a sync function by mistake
  • explicit-function-return-type: This ensures that any function is already marked async or sync with "its return type", so that people will not mistakenly use a async function by thinking it sync.

Under this view, the @typescript-eslint/promise-function-async is useless at least seems to me, and could create possible fail positives with the following:

let promise: Promise<void> | null;

const failPositive = () => promise

image

So I am suggesting closing this issue as it has negative influence with output code also no known benifit (at least seems to me)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.