vtoubiana / qookiefix Goto Github PK

Hi!
While browsing I noticed this:

I am confused on which one to use ;)
Thanks for your work so far!

If user opts-out the banner is likely to reappear within 24 hours. The extension should keep a list of websites on which the user opted-out and hide the banner on those sites.

Translating the string "Je refuse" in the user's language would be nice (at least fallback to English).

Should we use the browser's language, or the one from Quantcast popup (if it ever differs from the browser, I didn't test)?
First solution is bundled with WebExtensions and easy to implement, the second one would require us to detect the language used...

Bonjour,

Pensez-vous qu'il est possible de refuser automatiquement par défaut le consentement sur un site intégrant la solution Quantcast ?

Merci

Code is small and simple, and the extension targets recent browsers, so jQuery is not needed.

This would make the extension lighter and the code faster.

A PR is on its way 😉

Thanks for that wonderful addon.

The MutationObserver seems always observing the document.body.
Why not call disconnect [1] when the refuse button has been shown to avoid unnecessary observation afterward ?

[1] https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver/disconnect

Looks like it doesn't work since few days now.
It says:

Uncaught TypeError: window.__cmpui is not a function

But the accept button has window.__cmpui("updateConsentUi",2) so the refuse button should work too with window.__cmpui("setAndSaveAllConsent",!1)

While debugging #7 I realized that if you click on the "More options" link to see what cookies are set (and/or uncheck manually some of them), when you go back the button added by the extension disappears.

For instance, the site "makeuseof" uses another type of cookie banner.

MDN docs states that "The mutation events have been marked as deprecated" and "The practical reasons to avoid the mutation events are performance issues and cross-browser support".

They should be replaced by Mutation Observers.

A PR is on its way as well 😉