vordgi / nimpl-classnames-minifier Goto Github PK

https://github.com/vordgi/classnames-minifier/releases/tag/0.1.4

Part of #35

With reserved class some classes can be used twice

On build I have this error:

17:44:29 #12 0.774 Error: EBUSY: resource busy or locked, rmdir '/app/.next/cache'
17:44:29 #12 0.774 at rmdirSync (node:fs:1229:10)
17:44:29 #12 0.774 at _rmdirSync (node:internal/fs/rimraf:235:5)
17:44:29 #12 0.774 at rimrafSync (node:internal/fs/rimraf:193:7)
17:44:29 #12 0.774 at node:internal/fs/rimraf:253:9
17:44:29 #12 0.774 at Array.forEach ()
17:44:29 #12 0.774 at _rmdirSync (node:internal/fs/rimraf:250:7)
17:44:29 #12 0.774 at rimrafSync (node:internal/fs/rimraf:193:7)
17:44:29 #12 0.774 at Object.rmSync (node:fs:1278:10)
17:44:29 #12 0.774 at validateDist (/app/node_modules/classnames-minifier/dist/lib/validateDist.js:44:22)
17:44:29 #12 0.774 at new ClassnamesMinifier (/app/node_modules/classnames-minifier/dist/ClassnamesMinifier.js:14:40) {
17:44:29 #12 0.774 errno: -16,
17:44:29 #12 0.774 syscall: 'rmdir',
17:44:29 #12 0.774 code: 'EBUSY',
17:44:29 #12 0.774 path: '/app/.next/cache'
17:44:29 #12 0.774 }

Why does it try to remove .next/cache?

Hi!

When the minifier detects changes in the configuration, it cleans the build folder (by default this is .next).

In Vercel and localhost it is ok. But our dev pipeline works like this:

1. on the first machine (bitbucket pipeline) the build occurs.
2. the build is sent to the second machine (hosting).
3. on the second machine (hosting) the start occurs.

At the moment of start, the plugin deletes the build folder and we get this:

I'm not sure if the plugin does useful work in runtime, or only in buildtime/devtime? If only in buildtime/devtime, is it possible to check this somehow and skip the work when starting the production server (next start)?

After update to version 3.1.0

I'm getting an error when building:
classnames-minifier: Invalid configuration. Valid keys are: prefix, reservedNames, cacheDir, distDir. See https://github.com/vordgi/classnames-minifier#configuration

const withMinifier = classnamesMinifier({
  distDir: 'dist',
  prefix: 'x',
});

In version 3.0.0, is ok

Build is failing when using next/font

"next-classnames-minifier": "^2.0.0",

Hey!

First thank you for this package!

I got a problem: in addition to CSS modules, I use a small number of global classes. Specifically, the class of the current locale. These are short two letter classes. Minified classes began to overlap with them quite quickly.

Do you have any options to solve this problem?

I see two potential options:

1. provide the options to set a disallowlist of minified classes (rude and dangerous).

2. provide the option to set a prefix and/or postfix, for example, so that all minified classes begin with _.

Do not use while

https://github.com/vordgi/classnames-minifier/releases/tag/0.1.3

Next time Next.js will create the "About" page first and those classes will be created for that page, but "Home" page with the same classes will be read from the page

->

Next time Next.js will create the "About" page first and those classes will be created for that page, but "Home" page with the same classes will be read from the cache

Part of #35

Cleaning the build folder every time is too inconvenient; in general, a normal caching mechanism is needed

Stop defining every character in the class on every call. The previous characters are already known. The algorithm needs to be optimized.
Add support for numbers

Save option for specific configuration.

Improve readme.

Support Template strings

Hello, thanks for the useful package!

I have a problem – I'm using several fonts on my Next.js website, especially Geologica and Nunito Sans with several weights. After building app with this package, all the fonts are getting the same className, so every text on the page gets the same font.

This is how it looks in dev tools:

Seems like every font overwrites previously created class.