voidcosmos / npkill Goto Github PK

When is gemkill, pubkill, headerkill, pykill coming? :)

Describe the bug
when trying to execute the command npkill from any folder returns an error.
throw errnoException(err, 'spawn');

Expected behavior
Should allow me to select node_modules folders and delete

Screenshots
If applicable, add screenshots to help explain your problem.

• OS: Windows 7
• Version 0.3.0

Hi!
Thanks to your project, I've deleted some heavy node_modules and that's great, but I found a possible improvement:
When you try to delete a large directory, the removing process can take a few seconds, and there is no interaction from the app and it seems like it doesn't respond (I thought Space isn't working and I tried Enter or cmd+enter),

It will be nice to add some kind of text (or progress bar?) to show user, that action is performed

Hi.

I run sudo npkill.

releasable space is 471.05 gb, but I have only 250 gb on my Mac Mini's SSD drive.

Hi!

Cool project -- was just giving it a shot, kinda amazing how some of the modules folders add up in size...

Was doing what I usually do (I use console programs/interfaces a lot) ... and went to hit Page Up/Page Down to navigate ... and then also hit Home/End to navigate. To my surprise, nothing happened!

I had a quick look in the code, looks like there isn't a page up function really. I didn't look at the code in-depth yet to have enough information to recommend an implementation, but functionally, I think it might be nice to:

• Bind [PgUp] and [PgDn] (the actual keys) to a page up/down
  • Alternatively (or additionally, maybe?) , if it's not possible to bind those keys, perhaps a capital letter [J] and [K] for page up/down...
• Bind [Home] and [End] to jump to the top and end of the list
  • Alternatively/Additionally, consider maybe binding other commonly used keys to jump to top ... [j] / [k] are vi/vim/nvim-esque commands ...
  • Maybe [H] for "Jump to top of screen" and [L] for "Jump to bottom of screen" (but not "Top of entire list" and "Bottom of Entire list"...)
  • Maybe [g] (lowercase) for "Top of entire list" and [G] for "Bottom of entire list" (this would be vi/vim/nvim-esque - and also "less"-esque.)
• [This just came to mind, didn't yet search this...] some key to change the sort order once the program is running as opposed to having to start it all over again (maybe [s]? to just cycle through different sorting methods?)

Hi,
funny project and I think I can help you with your Improve performance even more! roadmap point.

Use fd as an alternative to find with cross platform compatibility.

First of all.. this is a fantastic idea for a tool, thank you!

Describe the bug
Installed npkill on my Windows 10 machine and tried running it for the first time but I get this error:

TypeError: this.stdin.setRawMode is not a function
    at Controller.setRawMode (C:\nvm\v12.7.0\node_modules\npkill\lib\controller.js:142:20)
    at Controller.prepareScreen (C:\nvm\v12.7.0\node_modules\npkill\lib\controller.js:116:14)
    at new Controller (C:\nvm\v12.7.0\node_modules\npkill\lib\controller.js:40:14)
    at Object.<anonymous> (C:\nvm\v12.7.0\node_modules\npkill\lib\index.js:18:22)
    at Module._compile (internal/modules/cjs/loader.js:777:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:788:10)
    at Module.load (internal/modules/cjs/loader.js:643:32)
    at Function.Module._load (internal/modules/cjs/loader.js:556:12)
    at Function.Module.runMain (internal/modules/cjs/loader.js:840:10)
    at internal/main/run_main_module.js:17:11

To Reproduce

1. Install [email protected] on Windows 10
2. Run npkill
3. See error

Expected behavior
npkill CLI interface

Screenshots

• OS: Windows 10 Professional 1903, build 18956.1000 (insiders fast ring)
• npkill version: v0.3.0
• NodeJS version: 12.7.0

Additional context

Describe the bug
Running npkill resulted in prompts for access to my: contacts, pictures, and calendars. I promptly stopped the process!

To Reproduce
Steps to reproduce the behavior:

1. Launch terminal.app or iTerm2 (v3.3.7)
2. $ npx npkill
3. See screenshot:
   

Expected behavior
Yes, by running npkill I granted access to my system. However, I didn't expect the package or its dependencies to be compromised by malware.

Screenshots

• OS: MacOS Mojave 10.14.6 (18G1012)
• Version Latest (not installed)

It deleted all the content that I had in my desktop (images, videos, etc) and screwed up a lot of my tooling.

I do not know where the bug is but I can with certainty tell you that it does not delete only node_modules and npm packages.

I only have to blame myself for trusting such a flag in the first place, but it may be nice to add a warning sign that this is performing a hard delete on whatever it finds.

Can the entire row be highlighted so it is easier to read how much space that particular row takes up.

Few days ago, I released nmc on github. It's a go project that aim to provide a simple command line to list all of the node_modules in a folder and delete all of them.

Basically it's the same idea that npkill with a lot less features 😅

This morning when I saw your project in trending I find it very cool to see exactly what I wanted to do, already done 👍
Good job !
Tell me how I can help 😃
I will archive my project and will put some efforts in yours instead 😃

Is your feature request related to a problem? Please describe.
This utility currently uses Space as the key to delete files. It goes against virtually all other file list utilities (e.g. ranger file manager, ncmpcpp MPD client) that use space to tag an item, then another key binding (usually d) to delete tagged items.

It might lead to surprises if an user does not throughly read the instructions and expect same bindings as other apps.

Describe the solution you'd like
Change the Space key binding to mark an entry, and move deletion to another key.

Additional context

• ranger default config
• ncmpcpp key bindings (scroll down to Keys - Browser)

Is your feature request related to a problem? Please describe.
No.

Describe the solution you'd like
It would be cool to select multiple directories and then delete them all at once.

Describe alternatives you've considered
...

Additional context
...

Describe the bug

1. The folder, releasable space and space saved are always 0 or nothing.
2. The list of folders is blank after search, but appears when you cursor down.

To Reproduce

1. create a new zsh shell
2. change to projects directory
3. run npx npkill

Expected behavior
Expected to see folder sizes and list of folders after search completes

Screenshots

• OS: MacOS 10.14.6
• Version (ran with npx npkill)

Most terminal apps allow to use j and k for navigation through the list. I was surprised that it doesn't work here.

Thanks :)

Describe the bug
My MAC only has 500 GB of hard disk 😅

• OS: macOS 10.14.6
• Version: v0.7.1

Is your feature request related to a problem? Please describe.
When I clean up node_modules I often want to save the installation for the future or when I am back in the node version, but that are a lot of steps to do.

Describe the solution you'd like
Moving the node_modules folder to an archive file, which is small and can be later unpacked.

Describe alternatives you've considered
no idea

Additional context
no

Describe the bug
When running npx npkill from my home directory on macos, this error message displays at the top of the results:

MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 data listeners added to [Socket]. Use emitter.setMaxListeners() to increase limit

To Reproduce
Steps to reproduce the behavior:

1. cd
2. npx npkill
3. See error

Expected behavior
I expect npkill to have high-enough resource limits to scan a typical macos development computer.

Screenshot

• OS: macos 10.14.6
• Version v0.7.1

Describe the bug
run npx npkill in the terminal with node v12.13.0 npm 6.14.1 throws this error: ERR! Cannot find module 'resolve'

To Reproduce
Steps to reproduce the behavior:
➜ ~ npx npkill
npm ERR! code MODULE_NOT_FOUND
npm ERR! Cannot find module 'resolve'
npm ERR! Require stack:
npm ERR! - /Users/estevanj/.nvm/versions/node/v12.13.0/lib/node_modules/npm/node_modules/normalize-package-data/lib/fixer.js
npm ERR! - /Users/estevanj/.nvm/versions/node/v12.13.0/lib/node_modules/npm/node_modules/normalize-package-data/lib/normalize.js
npm ERR! - /Users/estevanj/.nvm/versions/node/v12.13.0/lib/node_modules/npm/node_modules/read-package-json/read-json.js
npm ERR! - /Users/estevanj/.nvm/versions/node/v12.13.0/lib/node_modules/npm/node_modules/read-package-tree/rpt.js
npm ERR! - /Users/estevanj/.nvm/versions/node/v12.13.0/lib/node_modules/npm/lib/install.js
npm ERR! - /Users/estevanj/.nvm/versions/node/v12.13.0/lib/node_modules/npm/lib/npm.js
npm ERR! - /Users/estevanj/.nvm/versions/node/v12.13.0/lib/node_modules/npm/bin/npm-cli.js

npm ERR! A complete log of this run can be found in:
npm ERR! /Users/estevanj/.npm/_logs/2020-03-29T10_46_13_954Z-debug.log
Instalação de [ 'npkill@latest' ] falhou com código 1
➜ ~

Expected behavior
When I run npx npkill I should be able to run it without error.

• OS: Nome do Modelo: MacBook Pro

Describe the bug

Starting npkill triggers an HTTP request.

It seems to check for a new version, perhaps, judging by the error message, after I blocked the request.

To Reproduce
Steps to reproduce the behavior:

1. Start a prohibitive firewall
2. Start npkill
3. See request being intercepted by the firewall

Expected behavior

I expect npkill not to make any HTTP requests.

I think a tool like npkill that scans your entire drive should not make any potentially suspicious HTTP requests.

There are other, better mechanisms for checking versions.

Screenshots

• OS: macOS
• Version: v0.3.0

Additional context

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Open a terminal
2. Run npx npkill
3. The bottom-left corner displays a message: "Cannot read property 'path' of undefined"

Expected behavior
npkill runs normally and displays a list of directories

Screenshots
If applicable, add screenshots to help explain your problem.

• OS: MAC OS X 10.14.6
• Version: npkill v0.6.0

Is your feature request related to a problem? Please describe.
I ran npkill on /. The result was a terribly long list. I couldn't reach the bottom in reasonable time.

Describe the solution you'd like
Either automatically sort results by folder size or offer hotkey to do so

Describe alternatives you've considered
%

Very useful tool so far. Cleared 2gb in the first round, but couldn‘t get to the "bottom of it" for the above reason.

I'd like to see an Ethereum address added to the custom property of the FUNDING.yml file. This would allow a canonical address to send funds to. For example, I'm building a project that allows developers to setup one recurring donation that is split between all of their dependencies with an Ethereum address: https://sustainus.io

Describe the bug
--help does not print the list of commands out of view

To Reproduce
Steps to reproduce the behavior:

1. Open a terminal with a height less than 25 rows (v0.6.0)
2. Type npkill -h
3. You can see how the last rows do strange things, and omit the output of commands that do not fit in the terminal.

Expected behavior
It is expected to list all available commands as shown here
regardless of terminal size.

Screenshots

• OS: Tested in Arch. I imagine it applies to all systems.
• Version: Probably since the --help command was implemented.

Additional context
May need to change the system by which the command list is printed :(

I know its a known bug as per readme, but since there is no issue for it this will be used to keep track of it.

I am not really sure, why the tool claims the Git Bash on Windows has is not a TTY. I am using TTY features all the time ne my own projects. I am using the prompts and similar projects for keyboard navigation just fine there.

So I'll investigate what the problem here might be and provide a PR.

On MacOS, I ran it in my home directory and it said 600 GB. My laptop only has a 512 GB SSD.
There were many node_modules folders in my Yarn cache.

After running yarn cache clean, npkill said ~2 GB.

Describe the solution you'd like
Would be awesome to be able to hold shift + cursor arrow to skip 10 or 20 line positions because scrolling through thousands of directories takes a long time.

Describe alternatives you've considered
Trying to exclude folders but that doesn't work as mentioned here.

Is your feature request related to a problem? Please describe.
I'm always frustrated when I see mb (millibits) instead of MB (megabytes)

Describe the solution you'd like
I'd like to change mb to MB and gb to GB.

Describe alternatives you've considered
I have not considered any alternatives.

Additional context
Files to change:

• __tests__/result.service.test.ts
• src/constants/main.constants.ts
• src/controller.ts
• src/services/results.service.ts

Pull Request Link: #55

Feature Request.
I would save a lot of time if I could automate the process of filtering and deleting the folders. Then I could automate it with my backup plan, i.e. first delete node_modules of old projects, then borgbackup.

Describe the solution you'd like
another parameter which lets you filter (and/or delete) after a given number of days passed since the project has been touched. We could discuss whether the tool should look after the package.json or the youngest file in the node_modules folder (or the youngest file in the parent directory, aka project directory, of the node_modules folder).

You could use it like so:

npkill --filter-days-passed 50

It then shows only all projects which are older than 50 days

Describe alternatives you've considered
using find ..

Is your feature request related to a problem? Please describe.
Using the exclude option logs an error excludeDirs.flat is not a function. This is because the .flat method user here only exists from node 11.0.0.

Describe the solution you'd like
I'm not sure if other similar newer methods are used elsewhere in the code, but it'd be nice to document the node versions required. Ideally though, it'll be nice to use alternative methods that exist in older versions, or a polyfill. This would make the library more portable

Describe alternatives you've considered
It works without exclude. In my local node_modules/npkill, I added this polyfill from stackoverflow.

A more robust polyfill can be found here.

Additional context
Add any other context or screenshots about the feature request here.

Describe the bug
I've used npkill for the first time today without any issue during the first couples try.
But now, every time I try to run it, I got this error: RangeError [ERR_OUT_OF_RANGE]: The value of "err" is out of range. It must be a negative integer. Received 536870174

Screenshots

• OS: Mac OS 10.14.6
• npkill version: 0.4.2

Describe the bug
On MacOS, I get the following error when attempting to delete files:

The directory cannot be deleted. Do you have permission?

Have tried with sudo and non-sudo accounts

To Reproduce
Steps to reproduce the behavior:

1. Run npkill with or without sudo command.
2. Attempt to delete an item from the list displayed
3. See error

Expected behavior
Item is deleted with no error

Screenshots

• OS: MacOS 10.15.1
• Version: 0.6.0

The display units for this tool are mb and gb. Usually I think 8mb = 1MB, gb is the same, but I found the convertBToKb method in the code, the parameter name is bytes, then b is bit or byte?

I opened an issue on the wrong project 😱

Describe the bug
When npkill finishes searching it displays 0mb releasable space, despite showing multiple node_modules folders. On folder deletion, the program hangs. After five minutes, I killed the process with task manager and found that it succeeded at deleting the folder, but got stuck anyways.

To Reproduce
Steps to reproduce the behavior:

1. Run cmder
2. Run npkill
3. Select a node_modules folder and hit space

Expected behavior
The program shouldn't hang. Also, it should be able to calculate folder size.

Screenshots

• OS: Windows 7
• Version 0.6.0

Additional context
I suspect it may have something to do with file paths, you can see in the screenshots that the first part of the path uses one type of separator, and exactly after $PWD it switches separator type.

After a really long time (about half an hour) the program managed to unhang itself, after deleting a really small (< 1mb) node_modules folder. Also, after "unhanging", it calculated the size of two other really small node_modules folders. I was thinking maybe my hard drive was having some trouble, but Crystal Disk Info is reporting good HDD health.

Describe the bug
No directories found on OS X, regardless of directory
OS X 10.14.6
Node 10.16.0
Tested via yarn global install, and npx

To Reproduce
Steps to reproduce the behavior:
Run npkill
No directories found

Is your feature request related to a problem? Please describe.

I wish to search through all directories in ~ except a few directories. Those few directories have active projects that I know I am working on and I do not want to run npkill on them.

Describe the solution you'd like

Pass a list of exclude directories, something like npkill --exclude-dir ~/my-projects/* which should make sure that npkill doesn't try to search inside the directory ~/my-projects.

Describe alternatives you've considered

I haven't.

Additional context

Not necessary.

Describe the bug
I have installed node modules using pnpm and using npkill causes an error

To Reproduce
Steps to reproduce the behavior:

1. Run pnpm install in any node project
2. Try to use npkill through the command pnpx npkill
3. Select the project
4. Error

The following error happens on pretty much the whole .pnpm folder:

Error: ENOTEMPTY: directory not empty, rmdir 'C:\Repos\Testing\node_modules\.pnpm\registry.npmjs.org\yargs

• OS: Windows
• Version: v0.7.0

FYI, the pnpm folders use syslinks extensively. I understand this tool is not meant to support pnpm, but maybe the solution to such issue is as simple as changing a few lines and achieving full compatibility with pnpm.

Apparently, using rmdir command on Windows works.

Currently

-E, --exclude option accepts directories quotes to exclude. It would be nice to be able to do

-E 30

Which would exclude any N_M dirs with modifications of any enclosed files in the last 30 days. This would be a nice way not to npkill active work.

Describe the bug
I tried npkill and I got following error after few seconds
To Reproduce
Steps to reproduce the behavior:
$ npkill

• OS: Ubuntu 18 LTS
• Version 0.4.3

Additional context
ERROR:

      throw er; // Unhandled 'error' event
      ^

Error: spawn cut EMFILE
    at Process.ChildProcess._handle.onexit (internal/child_process.js:240:19)
    at onErrorNT (internal/child_process.js:415:16)
    at process._tickCallback (internal/process/next_tick.js:63:19)
Emitted 'error' event at:
    at Process.ChildProcess._handle.onexit (internal/child_process.js:246:12)
    at onErrorNT (internal/child_process.js:415:16)
    at process._tickCallback (internal/process/next_tick.js:63:19)

Instead of rm-ing the folders when a delete is triggered, it would be helpful to have an option that trashes them instead such as --trash. This is much safer and reversible.

Describe the bug

Users/kinglozzer/.nvm/versions/node/v6.9.0/lib/node_modules/npkill/lib/controller.js:267
            const { name, ctrl } = key;
                                   ^

TypeError: Cannot match against 'undefined' or 'null'.
    at ReadStream.process.stdin.on (/Users/kinglozzer/.nvm/versions/node/v6.9.0/lib/node_modules/npkill/lib/controller.js:267:36)
    at emitTwo (events.js:106:13)
    at ReadStream.emit (events.js:191:7)
    at emitKey (/Users/kinglozzer/.nvm/versions/node/v6.9.0/lib/node_modules/npkill/node_modules/keypress/index.js:406:12)
    at /Users/kinglozzer/.nvm/versions/node/v6.9.0/lib/node_modules/npkill/node_modules/keypress/index.js:363:7
    at String.forEach (native)
    at emitKey (/Users/kinglozzer/.nvm/versions/node/v6.9.0/lib/node_modules/npkill/node_modules/keypress/index.js:362:29)
    at ReadStream.onData (/Users/kinglozzer/.nvm/versions/node/v6.9.0/lib/node_modules/npkill/node_modules/keypress/index.js:48:14)
    at emitOne (events.js:96:13)
    at ReadStream.emit (events.js:188:7)

• OS: MacOS
• Version: v0.4.3

Additional context

The scan was still running, the first ~10 items were all items I wanted to delete, so I hit down+space repeatedly without waiting

Describe the bug
npkill exits unexpectedly on Windows 10 before it finishes loading the folders sizes.

\Jose\AppData\Roaming\npm-cache\_npx\35824\node_modules\npkill\lib\services\windows-files.service.js:18
throw err;                                                                                                                                                                                                                                                                                  
^
[Error: UNKNOWN: unknown error, lstat 'C:\Users\Jose\git\<hidden name>\<hidden name>\<hidden name>\<hidden name>\node_modules\.bin\uuid'] {
    errno: -4094,
    code: 'UNKNOWN',
    syscall: 'lstat',
    path: 'C:\\Users\\Jose\\git\\<hidden-name>\\<hidden name>\\<hidden name>\\hidden-name\\node_modules\\.bin\\uuid'
} 

To Reproduce
Steps to reproduce the behavior:

1. Open a powershell
2. Run npx npkill
3. Wait while npkill calculates folder sizes
4. Before it finishes caculating the sizes, the process exits unaxpectedly, showing an error

Expected behavior
npkill will continue to calculate folder sizes and let me to remove them

• OS: Windows 10 Pro. 10.0.18362
• Version v0.4.3

Additional context
Nothing to add. Feel free to ask for any extra details.

1335 MB is not that helpful. GB conversion is more helpful I think since people are more used to GB if it exceeds over 1023 MB :)

MacBook Pro (Retina, 13-inch, Early 2015)
OSX 10.14.6 (18G87)
Node 12.8.0
Ran with npx

nts.js:180
      throw er; // Unhandled 'error' event
      ^

Error: spawn cut EAGAIN
    at Process.ChildProcess._handle.onexit (internal/child_process.js:264:19)
    at onErrorNT (internal/child_process.js:456:16)
    at processTicksAndRejections (internal/process/task_queues.js:77:11)
Emitted 'error' event at:
    at Process.ChildProcess._handle.onexit (internal/child_process.js:270:12)
    at onErrorNT (internal/child_process.js:456:16)
    at processTicksAndRejections (internal/process/task_queues.js:77:11) {
  errno: 'EAGAIN',
  code: 'EAGAIN',
  syscall: 'spawn cut',
  path: 'cut',
  spawnargs: [ '-f', '1' ]
}

Happens everytime

Description

npkill lists the home directory as a node_modules directory:

Reproduction

1. Run npkill --sort size.
2. Wait for search to complete.
3. Do other tasks, and return to the process.
4. /Users/user/. will appear on the list.

I was able to reproduce this multiple times.

Expected Behavior

I expected for the home directory to not be listed.

Additional Information

I am using macOS Mojave 10.14, with npkill version 0.5.0, npm version 6.10.2, and node version 12.8.1.