vnegi10 / coinbaseproexchange.jl Goto Github PK

Although the old Coinbase Pro API endpoints still seem to work, they might get deprecated soon. We should switch to the new endpoints and URL as described here.

The newly added plot functions do not appear in the stable documentation.

It will be more informative to create plots of historical price vs time. UnicodePlots.jl can be used to achieve this right within the REPL.

Similar to vnegi10/CryptoDashApp.jl#51

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Instead of using @info in show_historical_data, we should throw an explicit error when unable to fetch historical data. Current implementation causes the function to return an empty DataFrame, which gives a missing column error later in the sequence.

julia> plot_historical_price("STORJ-EUR", 86400)
[ Info: 404 Not Found - Check if the pair ID is valid
ERROR: ArgumentError: column name "time" not found in the data frame since it has no columns
Stacktrace:
 [1] lookupname
   @ ~/.julia/packages/DataFrames/58MUJ/src/other/index.jl:410 [inlined]
 [2] getindex
   @ ~/.julia/packages/DataFrames/58MUJ/src/other/index.jl:422 [inlined]
 [3] getindex(df::DataFrames.DataFrame, ::typeof(!), col_ind::Symbol)
   @ DataFrames ~/.julia/packages/DataFrames/58MUJ/src/dataframe/dataframe.jl:557
 [4] plot_historical_price(pair::String, interval::Int64)
   @ CoinbaseProExchange ~/.julia/packages/CoinbaseProExchange/ZSSb7/src/plotpublic.jl:42
 [5] top-level scope
   @ REPL[35]:1

Instead of seconds, it will be easier to use hours and days as input to plot_historical_price("SOL-EUR", 86400).

Current logic in get_url function can be simplified by using a dictionary.