Git Product home page Git Product logo

wow-addon-candybuckets's Introduction

CandyBuckets

Candy Buckets makes it easier to track several world event objectives:

  • Hallow's End
  • Lunar Festival
  • Midsummer Fire Festival

Features implemented:

  • Simple overview on zone and continent views.
  • Works with the default map, probably not with other map related addons.

wow-addon-candybuckets's People

Contributors

vladinator avatar vladinator89 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

wow-addon-candybuckets's Issues

Co-ordinate list over-imposed on map

Many thanks for this VERY useful addon!

When I have CandyBuckets active, (version 9.0.1.201029) there is a list of map points overlaid on the map (see attached image). I have to zoom out & zoom in to remove them. Does not happen with CB disabled.
image

Few issues and possible improvements

Used this addon for this years Lunar Festival, and I found some issues and suggestions for improvement:

  • Notes on each icon what the name of the NPC is, and for instances name the name of the instance
    • The second part is kind of crucial, as instances are often bunched up.
  • Indoor and instance maps
    • Once you get inside the instance there is no indication where the NPC actually is.
    • As for indoor, a good example is the caves where Maraudon is inside, there are 3 entrances to this dungeon and an icon that points to the (correct) entrance to the dungeon would be very helpful.
  • Icons are currently rendered under POI icons on the map, making it impossible to get the tooltip to show, and it's easy to miss one because it's covered by a town/city POI.
  • ID 8647, add a note that you need to see Blasted Lands before the Draenor invasion, you do this with a buff
    • Preferably, add the NPC coordinates as well, or its own icon on the map (coords are 48.16, 7.29 by the way)
  • Most icons for dungeons, if not all of them in my case, as well as some outside didn't get removed after finishing the quest, had to /reload to make them disappear

Lastly, this is probably a personal preference; add some rounded borders on the icons to make them look better and stand out more.

Candy Buckets - wrong location

There were two wrong locations at Pandaria.

CandyBuckets quest hallow#32036 turned in at the wrong location. You were at 1/418/75.93/6.92 roughly 7.21 units away from the expected location. Please screenshot/copy this message and report it to the author. Thanks!

CandyBuckets quest hallow#32034 turned in at the wrong location. You were at 1/418/51.46/77.26 roughly 2.16 units away from the expected location. Please screenshot/copy this message and report it to the author. Thanks!

Candy Bucket wrong location

hi, had a message in WoW that a bucket was in the wrong location,
here are the details it gave me, hope this help and get addon btw :)
[20:03:36] CandyBuckets quest hallow#32020 turned in at the wrong location. You were at 2/418/28.36/50.73 roughly 2.84 units away from the expected location. Please screenshot/copy this message and report it to the author. Thanks!

It looks like ns.uimaps is not defined anywhere

Am I missing anything or ns.uimaps is not defined anywhere? Therefore GetChildrenNS and calls that use it seems to be useless as well. Quick instrumentation at GetChildrenNS shows that it never ever returned anything but nil and thus can be removed.

It's only called 19 times, so it isn't a performance problem, yet it distracts from reviewing rest of code.

Wrong Location for Iskaara Elder Nemaglek in The Azure Span

Iskaara Elder Nemaglek in The Azure Span

CandyBuckets quest lunar#73858 turned in at the wrong location. You were at 1/2024/12.91/49.05 roughly 65.91 units away from the expected location. [Click here to copy this message], then report it to the author. Thanks!

{ quest = 73858, side = 1, [2024] = {12.91, 49.05} }, -- 65.91, 伊斯卡拉

Fix for 9.0.1 Shadowlands pre-patch

The only change that seems to fix the Shadowlands pre-patch LUA errors is changing line 27 of core.lua:
local isCompleted = IsQuestFlaggedCompleted(questID)
to
local isCompleted = C_QuestLog.IsComplete(questID)

"Capital Cities" missing during the Midsummer Fire Festival?

I've used your map addons for years now (and that's coming from a person that limits them to a select few)... but I just finished my annual sweep of the Midsummer Fire Festival quests and noticed that the various "Stealing Flame" ones didn't show on the map.

Not really that big of a deal, since the capital cities are easy to remember... but I figured you might be interested.

http://www.wowhead.com/search?q=stealing+flame#quests:0+4+1+2

Nice work, regardless! ;^)

-TM

Quest id 32499 wrong location

Find this bonfire (Alliance) in another place that the addon indicated on map.
After that I saw this message in chat:
[00:26:53] CandyBuckets quest midsummer#32499 turned in at the wrong location. You were at 1/418/74.00/9.48 roughly 7.03 units away from the expected location. Please screenshot/copy this message and report it to the author. Thanks!

https://www.wowhead.com/quest=32499/honor-the-flame

Patch 7.2.5

Date: 2017-06-14 19:00:58
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\CandyBuckets\core.lua line 80:
table index is nil
Debug:
[C]: ?
CandyBuckets\core.lua:80: CheckCalendar()
CandyBuckets\core.lua:123: ?()
CandyBuckets\core.lua:15:
CandyBuckets\core.lua:15
[C]: ?
CandyBuckets\core.lua:39: QueryCalendar()
CandyBuckets\core.lua:28: ?()
CandyBuckets\core.lua:15:
CandyBuckets\core.lua:15

A few of the Lunar Festival coins only appear on a "single" map...

Another minor observation... almost all of the coin icons successfully appear on "multiple" maps (continent, zone, city, etc.), with the exception of:

http://www.wowhead.com/quest=8677/darkhorn-the-elder

Visible on the _Durotar_ map, but not on the _Kalimdor_ or _Orgrimmar_ maps.

http://www.wowhead.com/quest=29734/deepforge-the-elder
http://www.wowhead.com/quest=29735/stonebrand-the-elder

Both visible on the _Deepholm_ map, but not on the _Maelstrom_ map.

Thanks again for one of my favorite addons!
-TM

P.S. It'd also be nice if the _Azeroth_ map somehow indicated which continents still contained coins/candy/etc., but I'm guessing that something so minor probably isn't worth the effort... ;^)

Add a 'force enable' command or option

On my server, I noticed that sometimes an event is just missing in the Calendar, like for example the present Hallow's End one. This was quite frequent the last week, with approx. 1 of 3 logins the event just wasn't there, sometimes it comes up after 15 minutes or so, sometimes it comes up never.

As a result, Candy Buckets will be deactivated, not Candy Bucket's fault ofc, it just thinks there is no ongoing event.

To work-around that, I have deactivated all calendar-related checks in my core.lua, so that it is just enabled all the time for Hallow's End. This is OK, as I load Candy Buckets only if a relevant event is on, it is not part of my "normal" setups.

Assuming that I am not the only player with this issue, I propose to add a possibility to force-enable Candy Buckets in such cases. This could be something simple like /candybuckets force hallow or /cb force h, you get the idea. Just as an emergency for the current session if the client fails to load the events correctly, nothing to be stored in an SV file.

What I've said was experience from the last week of 9.2.7, let's see if this has improved somehow with 10.0.

But in any case, I think a 'force' command should be there. Never rely on Blizz, at least not until you can spot signs on the horizon that indicate that they might have begun to understand the meaning of the word "quality" ;) 1

Thanks for considering,

– Tom

Footnotes

  1. Normally, I would have assumed that the "quality" term is just missing in Blizz's world/vocabulary. But I've seen this term pop up in some of their notes, so I think it is a gigantic semantic issue on their side.

Bonfire in Vashj'ir

On horde character, after completing most of bonfires in Eastern Kingdom, saw that bonfire in Vashj'ir is marked as done despite not going there (on that character, I haven't been to that region). Re-logging didn't seem to fix that.
Edit. Restarting WoW did fix it.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.