vladimanaev / morrisjs-toggle Goto Github PK

Hi,

why toggle checkbox buttons can't work if use string in ykeys?

thanks

Great work on the plugin, does exactly what I need. However I found an issue, when using morris.js' setData() then trying to toggle, it would switch back to the old data set. I came up with a very quick solution:

1- Graph() function, line 40 change: this.origData = false;
2- setYKeys() function, line 130 change to:

Graph.prototype.setYKeys = function (yKeys) {
    if (this.origData === false) {
        var newData = [];

        $.each(this.morris.data, function(i, v){
            newData.push(v.src);
        });

        this.origData = newData;
    }

    this.setData(this.filterData(this.origData, yKeys));
};

3- Add toggleUpdateData() function:

Graph.prototype.toggleUpdateData = function () {
    this.origData = false;
};

Then, when using setData(), also call toggleUpdateData() which will update the data set for morrisjs-toggle. As I said this is a quick messy solution and there is probably a better way to resolve this, but hopefully this helps someone else.