vkdolea / age-system Goto Github PK

Piercing as damage type option - it halves Armor Rating

I noticed this in the expansion of an item I'd previously created using the system normal Create Item interface. This looks like it might be indicating a bug or possibly a missing bit of something. The hasPlayerOwner field for the item I was inspecting reads "Exception: TypeError: Cannot read property 'default' of undefined at ageSystemItem.get hasPlayerOwner [as hasPlayerOwner] (https://localhost/scripts/foundry.js:29367:30) at ageSystemItem.invokeGetter (:1:142)]". Granted this example is on an NPC sheet, but I get the same thing on items that are on a sheet for an actor owned by a player.

Also, I've noticed that the actor structure is populating the isPC attribute which is triggering a warning in the console stating that "The Actor#isPC attribute has been deprecated in favor of the more general Entity#hasPlayerOwner attribute". perhaps this is related?

Also review coding to handle damage rolls to ensure the ability portion is not passed to roll formula.

Description and Modificators are on different tabs. On chat Roll should show Description only.

Options given on dialog box:

Damage

1. Add Focus (boolen)
2. Add Stunt Die (boolean)
3. Add +1D6 or +2D6 (Stunt)
4. Add dice (prompt for quantity), plus Flavor text field
5. Add constant value, plus Flavor text field

Roll

1. Add constant value plus Flavor text field

Both

• Add option to Roll to GM (same effect as Click + Shift)

Currently, Fatigue is rolled using Power Focus and Willpower

It will make easier identifying keys for Active Effects

Shortcuts like @ability and @focusname.

1. Create functional image holder.
2. Reposition text input to better suit visualization.

For when characters carry several knives, swords, etc

Input field or modifier. Prompt user to add it to Dexterity o Speed

Add presets or a way to identify typical game Settings for each AGE game (The Expanse, Dragon AGE, Modern AGE, Fantasy AGE, Blue Rose).

Allows users to use their own images for those items

Dice so Nice is causing error when other player roll the dice - Dice so Nice can not find the user.color. It seems user data is incomplete. One's dice rolling won't show on other clients

Is there a way to inform the character's armor training, to avoid de decrease in defense when equipping an armor with armor penalty?

I am using the sheet to setup a Dragon AGE Campaign.

Current Behavior

Both the Defense and Speed decreases on equipping the armor

Intended Behavior

Only the Speed decreases, if able to inform the armor training.

When selecting and Focus on the list instead of typing, 2 error messages appear on console - it seems FoundryVTT expects <input type="text"/> to be filled in by typing only. No code breaking outcomes, tho.

It is missing a comma in the end of line 118 from fr.json file. The line is:
"userNotAvailable": "Le personnage {name} ({id}) n'est pas disponible."

The editor for the Chareacter-Features (below Drive, Quality and Downfall) is too small to use on Firefox (see first screenshot). Setting a min-height of about 100px for the enclosing div fixes this behaviour (see second screenshot).

Item Modifiers with active set to TRUE or with non zero data on value didn't have their field selected set to TRUE during migration of version 0.7.0. Happens for some users and not to others.

Values of each modifiers remains stored, tho.

Fix token getter

When adding <button></button> on Chat Message, clicking it causes Foundry client to refresh (currently, buttons a made out of div/span).

As GM, I want to be able to roll dice always using the setting in chat. I don't want to have to think about holding shift every time I want to roll some dice, especially since my chat window is telling me that the roll will be private (even though it really isn't). Also, it's a lot easier to make private rolls public, but it's a bit hard putting the toothpaste back in the tube, as it were.

Please add an option to use the chat setting for all rolls made by the GM instead of defaulting to public when not rolling from chat.

At the moment one can only whisper ability-based rolls, attacks, and damage. Would be neat to be able to whisper everything that's on a sheet.

Thanks for your work!

Check if it happpens with other item types as well.