Git Product home page Git Product logo

flexboxgrid-sass's People

Contributors

dancech avatar peterbrun avatar petervmeijgaard avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

flexboxgrid-sass's Issues

Display flex makes child elements fill the col width

Hi!

We've been using your library for a while now and i think its awesome!

Today we've tried to update to the new repository and the latest 5.0.3 version but found a "bug (?)"
When you add the default .col and for example .col--sm classes all childs inside that col are stretched to the full width of the column. This happens because the default col class also has a display: flex now.

There's also a variant .col--flex which also adds display: flex; which makes the initial display: flex; unnecessary right?

Is there way to prevent the streching in the current version?

Make row and col elements of container?

Good day!

Bootstrap grid classes are supposed to be used a s a system (I mean as a block in BEM). That means we can't use row outside of container and col outside of row. It seems logical to rename those classes according to BEM methodology the following way:

  • .layout or .grid instead of .container
  • .layout__row or .grid__row instead of .row
  • .layout__col or .grid__col instead of .col

What do you think?

Enhancement: Padding as variable

I've noticed padding default is defined within .row while it would be more flexible to set it as a variable. Just a thought.

Other than that the grid is really full featured and nicely documented.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.