React-Plugin does not respect the jsxImportSource from TSConfig about vite-plugin-react HOT 7 CLOSED

Notes:

• TSConfing "jsx": "react" is opt out of automatic runtime.
• TSConfig defined "jsxImportSource": "react" is default to current settings.
• Anything else, read pass on as is.

Did a go at it.

const jsxImportSrc = tsBuildConfig.compilerOptions.jsxImportSource
const jsxOption = tsBuildConfig.compilerOptions.jsx === "react"
  ? {}
  : jsxImportSrc === "react"
    ? {}
    : { jsxRuntime: "automatic" as const, jsxImportSrc, }


ReactPlugin({ ...jsxOption, })

Worked perfectly with others, like @emotion/react

    "jsx": "react-jsx",
    "jsxImportSource": "@emotion/react",

and

    "jsx": "react-jsx",
    "jsxImportSource": "react",

from vite-plugin-react.

Does esbuild support jsxImportSource? According to https://esbuild.github.io/content-types/#tsconfig-json only a few fields are supported which Vite passes. Maybe this is related to plugin-react and it's babel transform, but regardless it would be great if you can submit the PR so it's easier to view the proposed changes.

from vite-plugin-react.

All the heavy lifting is already done by the React plugin, this is purely a convenience feature. Making sure that we don't repeat configs and keep one single source of truth.

from vite-plugin-react.

Yes, esbuild does support jsxImportSource.

from vite-plugin-react.

Now that jsx transformation is done by esbuild and that the esbuild plugin correctly read this options, it should be as easy as removing this line https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react/src/index.ts#L152 for TS projects.

This should also enable multiple runtime per app that someone asked in the discussions.

But I don't know how to handle that for JS project (or more complicated, mixed projects)

from vite-plugin-react.

Hello @seivan. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with need reproduction will be closed if they have no activity within 3 days.

from vite-plugin-react.

Hi!
Just tested with the latest version of Vite and the plugin and it it's already working in fact (with one TS config that specify jsxImportSource and no options for the react plugin).
If you have a more complex usecase not supported please share a repro

from vite-plugin-react.