vitalwarley / ia2-p1 Goto Github PK

Again, the focus here is runGame method.

• Add NPCs
  https://github.com/latived/ia2-p1/blob/2c96606fc1dd7e5be32c6c8656978995c175c1f3/game.py#L41-L42
• Reflect on these control variables
  https://github.com/latived/ia2-p1/blob/2c96606fc1dd7e5be32c6c8656978995c175c1f3/game.py#L43-L46
  • dotTurn controls only two dots: player and NPC. As we want more NPCs, we need a way to control each one turn. The same is true for dotCanAtk and dotCanMove.
  • How about creating a Game class to control what players and NPCs are playing, who turn is, turn counter and others game parameters?
  • It is nice to keep in mind that any decision made here will impact in everything in this issue.
• Force all NPCs to be controlled in the same way or not?
  https://github.com/latived/ia2-p1/blob/2c96606fc1dd7e5be32c6c8656978995c175c1f3/game.py#L50
• This could be included in specific block for turn management.
  https://github.com/latived/ia2-p1/blob/2c96606fc1dd7e5be32c6c8656978995c175c1f3/game.py#L59-L70
• How to improve these lines?
  https://github.com/latived/ia2-p1/blob/2c96606fc1dd7e5be32c6c8656978995c175c1f3/game.py#L72-L89

The rest of the code for runGame almost certainly will be impacted by the decisions made from the answers above.

Comment the hell out of it

Track the logic behind it:

• Try to summarize the code flow in key actions, like "Set up players; Initiate main loop..."
• When variables are used, when are modified, when are unnecessary.
• When methods are called and what returns.
• See what parts are susceptible to encapsulate.