can't add and remove layer about deck.gl HOT 8 CLOSED

@wwwtyro this is becoming a critical issue for Shan's app.

The issue is related to the layer needing to register a new Program etc, it always seemed hard to fix in PhiloGL since it uses a declarative approach for setting up programs making it a little tricky to figure out how to add and remove them after initialization.

This should be much more straightforward to fix using luma.gl once the ongoing port is complete.

@heshan0131 We might want to extend the example code to add and removes layers in a way that reproduces the issue.

from deck.gl.

👍 It'd be great if I can get a reproducible example.

from deck.gl.

@wwwtyro I will edit the example code, and do a pull request?

from deck.gl.

That'll work, or you can just make a branch and push it and tell me where it's at so I can try it. :)

from deck.gl.

yes will do

from deck.gl.

@wwwtyro
example added in
https://github.com/heshan0131/deck.gl/tree/dynamic-layer-example

from deck.gl.

Thanks! I'll make sure it works when I get luma.gl working with deck.gl. :)

from deck.gl.

@heshan0131 Please retest this on the performance branch. Layer handling has been rewritten so if it is still an issue let us fix it in the right place.

from deck.gl.