Git Product home page Git Product logo

Comments (10)

Pessimistress avatar Pessimistress commented on May 10, 2024

Please provide a functional code snippet and dataset that reproduces your issue.

from deck.gl.

oishi4multisoup avatar oishi4multisoup commented on May 10, 2024

I'm sorry.
The drawings are confidential and cannot be made public.
The source for generating and updating GeoJsonLayer is as follows.

// Generating GeoJsonLayer
const drawing = new GeoJsonLayer({
    id: 'drawing',
    data: selectedDrawing.value,
    bounds: selectedDrawingBounds.value,
    coordinateSystem: COORDINATE_SYSTEM.CARTESIAN,
    target: [0, 0, 0],
    getLineColor: [128, 128, 128],
    stroked: true,
    filled: false,
    pickable: false
  })

// Update Layer
layers.value = renderLayers()
  deckgl.value.setProps({
    initialViewState: getViewState(),
    layers: layers.value
  })

from deck.gl.

Pessimistress avatar Pessimistress commented on May 10, 2024

Your bug report states that the steps to reproduce is simply "keep updating GeoJsonLayer 20 times." If that is true, then you should be able to reproduce the issue with ANY GeoJSON. If you cannot reproduce it with a public dataset, then the issue is specific to your own data.

As you can see we have over 100 bugs open right now. Any work you do to help us confirm the bug will get your issues resolved faster.

from deck.gl.

oishi4multisoup avatar oishi4multisoup commented on May 10, 2024

I’ll create a sample using a large-sized GeoJson that is publicly available, so please give me some time.

from deck.gl.

Pessimistress avatar Pessimistress commented on May 10, 2024

I don't know what the layers,value/deckgl.value are in your code, but it looks like you are using deck.gl with some framework or state management library. Some of these things, like Vue, are known to recursively modify bound data props, in which case it's not surprising that you are getting problems with a large nested object such as GeoJSON. I highly recommend you use the Chrome profiler to find out what function is using that CPU time before rushing to conclusions.

from deck.gl.

oishi4multisoup avatar oishi4multisoup commented on May 10, 2024

As you said, I'm using Vue 3.

from deck.gl.

Pessimistress avatar Pessimistress commented on May 10, 2024

This is a known problem for Vue in general. Putting a large complex object into the reactivity system is expensive and unnecessary.

markRaw

Some values simply should not be made reactive, for example a complex 3rd party class instance, or a Vue component object.

from deck.gl.

Pessimistress avatar Pessimistress commented on May 10, 2024

Closing this issue unless reproduceable in standalone deck.gl.

from deck.gl.

oishi4multisoup avatar oishi4multisoup commented on May 10, 2024

There was a slight improvement by changing ref to shallowRef, so it may not be a problem with Deck.gl. We will close it.

from deck.gl.

oishi4multisoup avatar oishi4multisoup commented on May 10, 2024

Thanks!

from deck.gl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.