We made some changes (like libsasshost usage #2 or replacement of hard coded directory separators #28 or AntiForgery token generation #16) which we may migrate to old storefront

@jarbi says:

Hello. I'm having some issues with the storefront "clothing" theme. I've set my currency symbol in admin and all works ok except that on the "Thank you" page the currency symbol is the default "kr" instead of the in admin defined "SEK".

I have located the issue to this line: https://github.com/VirtoCommerce/vc-storefront/blob/90089bbd18ad5eca2112e3d7a35876ec9ba34e86/VirtoCommerce.Storefront/Binders/CartTypesModelBinder.cs#L57

How to reproduce:
Add item to cart, go to checkout. finish order. When order is created then a "thank you" page is shown.
With in my case, wrong currency suffix

Hello. So i've modified the creationtime of order lineitems to be the same as cart. But when i sort them in the notification like this {% assign lineitems = customer_order.items | sort: 'created_date' %}they still render at random

The image above should be blue instead of white.

On Storefront for full .NET Framework all ok.

If user already logged in and then try to login with external provider account should merge with existing account

Version info:

• Storefront version: 3.0.5

Expected behavior

Storefront must provide configuration setting to disable memory cache on storefront.

Actual behavior

There is no setting for that

Add {% Layout %} tag to all templates which are don't use default layout
Checkout, Account

Change Page.liquid template to always render static content
{% layout page.layout %} {{ page.content | render }}

Add to templates\customers\reset_password.liquid new lines

	  <input type="hidden" value="{{ reset_password.token }}" name="customer[token]" id="token">
	  <input type="hidden" value="{{ reset_password.email }}" name="customer[email]" id="email">
``` for correct password reset

(optional) Now instead CustomerInfo we are using User type which encapsulated  Contact as property need to change all js and templates according to this fact. Also, these changes affected the Cart and QuoteRequest model. 
List of files for change:  `Checkout.liquid`, `main.js`, `account.js` and other 

Know questions:
IIS or Krestel?
Environment settings?
Caching?
Configurations (AppSettings, Connection strings)?
Application insight?

@vkrashenko commented on Wed Feb 07 2018

Steps to reproduce

1. Register in some store. For example in Electronics
2. Go to the platform and check that stores are NOT linked
3. Next go to the other store and try to login with your account from step 1.

Finally you will see next error, but successfully logged in,

Expected behavior

See staging content from robots.staging.tx

Actual behavior

See main robots.txt

Steps to reproduce

1. Add rule

<rule name="Robots.txt for production domain only" stopProcessing="true">
            <match url="robots.txt" />
            <conditions>
                <add input="{HTTP_HOST}" pattern="^(virtocommerce\.com)$" negate="true"/>
            </conditions>
            <action type="Rewrite" url="/robots.staging.txt" />
        </rule>

2. Open https://vc-public-qc.azurewebsites.net/robots.txt
3. Should see content from robots.staging.txt

wwwroot/cms-content/Themes/default

• Need to create new Liquid tag for AntiForgery token generation {{ anti_forgery }}

• Remove unconditional AntiForgery token generation from Form tag
  https://github.com/VirtoCommerce/vc-storefront-core/blob/master/VirtoCommerce.LiquidThemeEngine/Tags/FormTag.cs#L83

Current DotLiquid issues:

• Performance issue (regexp based tokenization significant reduce rendering time and leads to serious CPU load)
• Unable to define aliases for types and properties it leads to using two different models (Shopify and VCF) and mapping layer.

Сandidates projects for replacements:
https://github.com/mikebridge/Liquid.NET
https://github.com/sebastienros/fluid
https://github.com/lunet-io/scriban - looks very worthy

Instead of using hard coded values, use either Path.Combine or Path.DirectorySeparatorChar

https://github.com/VirtoCommerce/dotliquid
publish nuget package

The discovery paths of where template is resolved should be added at the time of resolution instead of after the fact using: _liquidThemeEngine.DiscoveryPaths.

Currently "_liquidThemeEngine.DiscoveryPaths" is simply a static method that is calculated based on preconfigured discovery folders paths. Instead find template should return a view object which when view view is not found contains collection of absolute paths view was searched in.

Expected behavior

Redirect to new correct url

Actual behavior

NullReferenceException: Object reference not set to an instance of an object. with rule

Steps to reproduce

1. Add a new rewritre rule into IISUrlRewrite.xml

        <rule name="Redirect Blogs to Blog" stopProcessing="true">
            <match url="^blogs/news/(.+)" />
            <conditions trackAllCaptures="true" />
            <action type="Redirect" url="blog/{R:1}" />
        </rule>

2. Open https://vc-public-qc.azurewebsites.net/blogs/news/agile-platform

3. Get error
   NullReferenceException: Object reference not set to an instance of an object.

Microsoft.AspNetCore.Rewrite.Internal.IISUrlRewrite.ConditionEvaluator.Evaluate(ConditionCollection conditions, RewriteContext context, BackReferenceCollection backReferences)
Microsoft.AspNetCore.Rewrite.Internal.IISUrlRewrite.IISUrlRewriteRule.ApplyRule(RewriteContext context)
Microsoft.AspNetCore.Rewrite.RewriteMiddleware.Invoke(HttpContext context)
Microsoft.AspNetCore.Diagnostics.StatusCodePagesMiddleware+d__3.MoveNext()
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
VirtoCommerce.Storefront.Middleware.ApiErrorHandlingMiddleware+d__3.MoveNext() in ApiErrorHandlingMiddleware.cs

depends on catalog:112

Should not generate exception, instead should say that theme folder is not defined or something in that sort.

As a developer, I want to use IIS Url Rewrite config file with vc-storefront-core solution.

Expected behavior

As example, I want migrate current rewrite_rules rules
https://github.com/VirtoCommerce/vc-content/blob/deploy/wwwroot/rewrite_rules.config

How to use
https://docs.microsoft.com/en-us/aspnet/core/fundamentals/url-rewriting?tabs=aspnetcore2x
https://metanit.com/sharp/aspnet5/24.1.php
https://metanit.com/sharp/aspnet5/24.2.php

Url where storefront core deployed
https://vc-storefront-core.azurewebsites.net

Any founded bugs you can write on this issue.

Some use cases for testing:

1. Categories navigation
2. Products filtration bt properties
3. Add / Remove products in cart
4. Checkout
5. Registration, Login, Google login
6. Anonymous cart merging when login
7. New addresses adding when new order placed
8. User cabinet (change password, add/edit/delete addresses, see order list)
9. Discounts (on product list, enter coupon in checkout)
10. Change currency, language
11. Blogs, pages

Should at the root of the project

https://github.com/VirtoCommerce/vc-module-core/tree/master/VirtoCommerce.Tools
Need to publish new Nuget version VirtoCommerce.Tools.Core

New abstractions should support the use of integration with distributed bus events.

As a Content Manager, I want to limit access to anonymous access for CMS pages.

want to block anonymous access to the page.

GIVEN Anonymous user
GIVEN CMS Page with Authorize = false.
WHEN Open CMS Page
THEN Should be redirected to login
THEN After registration I should be redirected to CMS Page and be able to see content.

Use authorize property to true/false

Set to true if you want to block anonymous access to the page.
Set to false if you want to allow anonymous access to the page.
Default value is false

Currently we have the following repos:
vc-storefront
vc-theme-*
vc-platform
vc-module-*

After migration to .NET Core we may want to have the following structure:
vc-core-storefront
vc-core-platform
vc-core-module-*

instead of
vc-storefront-core
vc-platform-core
vc-module-*-core

Currently, if you want to load some parts of product, you must specify resp_group query in URL. We must found the way to specify it in theme.

fail: Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware[0]
An unhandled exception has occurred: Failed to compile sass file "/Themes/Electronics/default/assets/default.scss.liquid"
Line:
Compiler error: The type initializer for 'LibSassHost.SassCompiler' threw an exception.

https://github.com/VirtoCommerce/vc-storefront-core/blob/master/VirtoCommerce.Storefront/Controllers/StaticContentController.cs#L133

@asvishnyakov commented on Fri Sep 15 2017

In ApiCartController add copies of AddItemToCart, ChangeCartItem, RemoveCartItem method, but allow to pass multiple items instead of single, i.e.

AddItemToCart([FromBody] AddCartItem cartItem) → AddItemToCart([FromBody] AddCartItem[] cartItems)

In CartBuilder add copies of AddItemAsync & AddLineItemAsync, etc. and allow to pass multiple items instead of single, i.e.:

public class CartItem
{
    public Product Product { get; set; }
    public int Quantity { get; set; }
}

AddItemAsync(Product product, int quantity) → AddItemsAsync(IEnumerable<CartItem> items)
AddLineItemAsync(LineItem lineItem) → AddLineItemAsync(IEnumerable<LineItem> lineItems)

Currently views are searched inside the following folders:

Themes/Clothing/default/templates
Themes/Clothing/default/snippets
Themes/Clothing/default/layout
Themes/Clothing/default/assets

The view like "index.liquid" should never be searched in any folder besides "templates".

Same goes with snippets (includes inside liquid), they should only be searched inside "snippets" folder. And layouts should only be seached inside "layout".

Version info:

• Browser version: Chrome 63
• Platform version: 2.13.19
• Storefront version: 3.0.5

Expected behavior

Storefront cache should be invalidated when theme files changed.

Actual behavior

Nothing happens when Azure blob provider used. Locally working normal.

Purpose

Prepare CMS proof of concept to demonstrate page rendering by providing a definition in JSON and defining visual blocks in the theme as snippets.

Requirements

• page definition (meta description) should be prepared manually in JSON format.
• simple visual blocks should be used for page definition: image and text
• use default (electronic) theme

Acceptance criteria

• GIVEN three files are prepared: page definition in JSON format, two liquid snippets for representing image and text blocks WHEN open test page on storefront THEN page with sample image and text should be displayed

Definition of Done

• Documentation: About Json page, How to create json page, How to customize UI block snippet
• Release vc-storefront-core with Json pages

Add the ability to add and edit a user's photo on the storefront

Version info:

• Platform version: 2.13.19
• Storefront version: 3.0.5

Expected behavior

Storefront should process address with BillingAndShipping type as both address for billing and shipping

Actual behavior

Storefront ignore addresses with this type

-[ ] Installation from source code
-[ ] Installation precompiled version
-[ ] Deploy to Azure from Visual Studio
-[ ] Deploy to Azure from GitHub
-[ ] List of changes

Known candidate for replacement https://github.com/Taritsyn/LibSassHost

To replicate, set envrionmental variable to clothing on startup, so it opens clothing store first and then switch to electronics store:

  "environmentVariables": {
    "VirtoCommerce:DefaultStore": "Clothing",
    "ASPNETCORE_ENVIRONMENT": "Development"
  },

You get this incorrect homepage:

https://docs.microsoft.com/en-us/azure/azure-functions/functions-bindings-storage-blob

https://github.com/VirtoCommerce/vc-storefront-core/blob/master/VirtoCommerce.Storefront/Domain/ContentBlobProviders/AzureBlobContentProvider.cs#L203

See example how it did for FileSystemContentBlobProvider
https://github.com/VirtoCommerce/vc-storefront-core/blob/master/VirtoCommerce.Storefront/Domain/ContentBlobProviders/FileSystemContentBlobProvider.cs#L96

We should invalidate cache when add external login into current account.

For example when we use AddLoginAsync
https://github.com/VirtoCommerce/vc-storefront-core/blob/21710b9c30989aa3a9fec270a45a61ad41d01c33/VirtoCommerce.Storefront/Domain/Security/CustomUserManager.cs#L137

Expected behavior

Add external login and see correct externalLogins collection when I load account info.

Actual behavior

Add external login. See empty externalLogins because we cached it in FindByEmailAsync, FindByNameAsync and etc.
I can resolve issue by storefront restart only.

Steps to reproduce

1. Sign-in
2. Assign external login (Google, Facebook) into current account
3. See wrong status or Call /storefrontapi/account and see empy externalLogins ((