vircadia / vircadia-metaverse Goto Github PK

I had some old domains with associated place names.
I deleted the domains.
The place names were also deleted (which shouldn't have happened.)

Iamus Dashboard v0.0.1f
Metaverse Version: 2.2.8

My https://dashboard.vircadia.com/domain page is showing a bunch of "domains" associated with old place names from my testing. I've deleted the place names in the https://dashboard.vircadia.com/places page but the domains still show with the deleted place names listed. The "delete" icon doesn't delete the domains.

Server settings page editing of places needs debugging.
See vircadia/vircadia-native-core#759

Clean install of server on Windows.
In server start-up wizard, skip step 2 (to do with getting a place name).
In server settings table there is no temporary place name listed.
Press the "Get a temporary place name" button.
There is still no temporary place name listed.

Version: Vircadia-Alpha-PR668-c4e4b61_9e8dc88f.exe

Looking in https://dashboard.vircadia.com/places it would appear that two temporary place names were created during the above: the first probably during the wizard and the second after clicking the button.

Not implemented. Log message is:
procAllDebug: GET /api/v1/users/connections?per_page=1000&page=1&sort=username,ASC
procAllDebug: body: {}
procCreateError: no response so returning 404
procFinalError: generating final error
^[[0mGET /api/v1/users/connections?per_page=1000&page=1&sort=username,ASC ^[[33m404 ^[[0m0.761 ms - -^[[0m

A domain that is not registered will keep talking to the metaverse-server and they just keep creating log errors (cannot find domain).
Decide if a dummy entry should be created or if errors should be suppressed.

So domains that where shutdown with a users still logged in do not continue to always have a user count.

When setting an entity field, the field validate function can return 'false' which ends up returning a 'failed' to the user. There is no information on why the field setting failed. For instance, setting an accounts email could fail because the email is poorly formed or because it is not unique.

Do something to the Permissions.validateFunction so it returns other information on a failure so the user has a clue as to why it failed.

2020.2.3
On a domain that allows anonymous connections
If logged in, the following message is reported in the program log every 5 seconds:

[DEBUG] [hifi.networking] Metaverse session ID changed to "d8f8d897-13d2-4352-8f3b-bb7fb0746042"

If not logged in, the problem does not occur.

There is a Bash script to generate the version number and probably other Linux'isms that prevent building under straight Windows.

Doesn't seem to be working for anyone anymore, however it was working not more than approx 36-48 hours ago (from posting this.)

There is /api/v1/user/places/placename as a legacy operation but there also seems to be a /api/v1/places/placename.
Also accept placeId.

After connecting my account in step 1 of the wizard, in step 2 I elected to create a place name. However, the Web page displayed is just blank - https://metaverse.vircadia.com/live/user/places .

I don't already have any Place Names registered so I elected the "Create new place" button, which opened the blank browser tab.

Remove account specified in Place -- it's just a mapping to the domain.
Create an Explore/Beacon formatted fetch:
[ { "Domain Name": string,
"Owner": string,
"Visit": "hifi://IP:port/address",
"People": number
},
...
]

this seems to be generated by the domain-server and I presume it means to delete any pending connection request.

Usernames should be able to be upper/lower case and should include other characters (dot, underscore, dash). Matching names should be case-insensitive.

Currently, Iamus just logs to stdout. This should be fixed to output to the database or files that can be rotated and otherwise managed.

Currently, domain tokens have a long life (one year). Domains can come and go and this can cause tokens to pile up.

Create an API operation or add a token timeout that removes tokens for inactive domains before the expiration date. Have a config file option to set the inactive time (N months?).

The new metaverse login page (within interface) gives you the option to sign in with either email or account name. Account name works fine, but attempting to use email address gives you the message "username or password is incorrect."

vircadia/vircadia-native-core#769 if the domain-server wizard encourages you to put in a sane default then we can allow the randomized first place name to never be the same name as the domain-server, so it's slightly more clear what is what.

Analyze requests and figure out best indexes.
Will be fetching lots of things based on friends and connections.

It would seem that if you get a temporary place name (the domain-server will automatically do this on your first run) then once you connect the server with your account, the domain ID & the place name will not get associated to your account afterwards even though it should...?

One example of the potential issue in action as reported by user "Jaye".

Oct 10 10:57:53 v1 domain-server[2862]: [10/10 10:57:53] [CRITICAL] [default] PAGE: Public key upload failed from AccountManager to QUrl("https://metaverse.vircadia.com/live/api/v1/domains/13122642-4415-4087-a665-4b31eba1825f/public_key") "Host requires authentication"

Log in with dashboard. Go to "Profile". Paste URL into hero image section. Press "save". Get error.

Log entry is simply:
procAllDebug: POST /api/v1/account/157866ad-b78f-4fa4-9eec-fdf1dc3d6120/field/images_hero?asAdmin=false
procAllDebug: body: {"set":"https://files.misterblue.com/vircadia/images/MisterblueGuy-AnimeBoy-Hero.jpg"}
setupMetaverseAPI: created new session for 192.64.118.213:45336
finishMetaverseAPI: response: {"status":"failure","error":"value could not be set"}
^[[0mPOST /api/v1/account/157866ad-b78f-4fa4-9eec-fdf1dc3d6120/field/images_hero?asAdmin=false ^[[33m400 ^[[0m12.495 ms - 53^[[0m

I don't have a place connected to my domain. But (according to my account dashboard) a temporary place has been associated with my domain - "cyan-condor". But the Settings > Places table is empty.
I would expect:

1. The temporary place to be listed in the table.
2. There be a row with a "+" sign to choose / create a place.

PR370 Places table ...

Expected Places table (from similar 2020.2.5 server setup) after clicking the "+" button ...

Integrate friend existence to user account fetching permissions, etc.

This should apply to creation and renaming of a place. With federation, you will still be able to have the same place name as another person on another metaverse, it will be denoted like so [email protected] and [email protected]

Designed for place discovery
Include num_users, etc
Add filtering... "?per_page=10&order=decending,user_num

The domain settings page points the user the "metaverse-server-url/usr/places" to create places. This link should be redirected to "https://dashboard.vircadia.com?metaverse=metaverse-server-url&page=places"

And built Docker file can be in the Github repository.
SHould also figure out how to and setup configuration to do "releases".

At the moment, an account creates a token with DOMAIN scope and gives that to the domain to use for metaverse-server access. This means that the metaverse-server kinda has to assume that a domain using that token is associated with the account that created that token.
It would be Way Better if there was a request that explicitly associated the account with the domain making the domain management association official.
This would also make Place creation and management easier as it would be explicit that this account manages this domain and places.

a GET /api/v1/users/Firstname%20Lastname/public_key fails because the username is not URL decoded before searching.

Fix, at least, accountFromParams()

There should be some rate limiting of incoming requests.

Current implementation creates/expires Sessions for IP:port. Could be basis for own implementation. If not doing own leaky-bucket implementation, consider removing Sessions completely. Possible library: https://www.npmjs.com/package/leaky-bucket

Explore available nodejs/expressjs rate limiting packages:
https://www.npmjs.com/package/express-rate-limit
https://www.npmjs.com/package/rate-limiter-flexible
https://www.npmjs.com/package/express-brute
https://www.npmjs.com/package/express-limiter

On the "Get Domain Token with Account" page, it can appear that nothing happens when you click the "Get Token" button. This is because the token info is put in the rectangular box underneath the dialog and not necessarily visible.

Suggestion: Put the domain token in the blank space in the dialog box, under the bottom horizontal rule.

https://i.gyazo.com/d0d47a56b0e34e072fe55e12a8e10723.jpg

Add 'emailVerified' flag to account.
Optionally email verification email (if out-bound email server specified)
Have web page landing page that comes from the email sent.
Integrate it into the Requests collection.

Iamus no longer sending profile picture url back for self when requested from user api.